Hi,
Please provide your valuable feedback.

Description

This Module provides simple way to add static server path to call files like, (Images, CSS, JS, ico) from static server.
This module is use to enhance performance as it includes static files from sub-domain or static server
you just need to navigate to admin/config/system/files-static-url Configuration -> System -> Static Server Url and add static path for CSS, Imgaes, JS and add extension, defined extensions will be call from defined static urls.

Project page

https://www.drupal.org/sandbox/zeeshan_khan/2390723

Git

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/zeeshan_khan/2390723.git static_server
cd static_server

Automatic Pareview
http://pareview.sh/pareview/httpgitdrupalorgsandboxzeeshankhan2390723git

Reviews

[D7] Functional content
[D7] Webform Panels
[D7] Tether Stats

Files: 
CommentFileSizeAuthor
static_server.zip1.86 KBzeeshan_khan

Comments

zeeshan_khan’s picture

Issue summary: View changes
PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxzeeshan_khan2390723git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

zeeshan_khan’s picture

Thanks a lot for reviewing my project :)
Yes I reviewed and fixed all the issues those came across by running pareview.sh

Many Thanks

zeeshan_khan’s picture

Priority: Normal » Major
Status: Needs work » Fixed
zeeshan_khan’s picture

GIT clone command:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/zeeshan_khan/2390723.git static_server
cd static_server

sumitmadan’s picture

This application review should be closed by git admin after you get git vetted user role. You should keep this is needs review state if you think no issues pending that are reported by someone. Also you should assign it to yourself too.

zeeshan_khan’s picture

Assigned: zeeshan_khan » Unassigned
Status: Fixed » Needs review
zeeshan_khan’s picture

naveenvalecha’s picture

deepakaryan1988’s picture

This module seems to be alright but there should one thing still to do.
You should do variable_del in the .install for whatever you have set the variables in the variable table.

Thanks,
Deepak Kumar

deepakaryan1988’s picture

Status: Needs review » Needs work
zeeshan_khan’s picture

Hi Deepak,

Thanks for providing your valuable feedback,
I have added .install file with variable_del for all the variables I'd set.

Thanks

zeeshan_khan’s picture

Status: Needs work » Needs review
naveenvalecha’s picture

Status: Needs review » Reviewed & tested by the community

@deepakaryan1988,
Its best practice to remove the code used variables from the module.Have you seen any other application blocker made you to stop this to RTBC.if it is then specify.

Automated Review

Review of the 7.x-1.x branch (commit 6f8f80c):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).

    <p></p>
    <p>FILE: /var/www/drupal-7-pareview/pareview_temp/static_server.install<br>
    --------------------------------------------------------------------------------<br>
    FOUND 1 ERROR AFFECTING 1 LINE<br>
    --------------------------------------------------------------------------------<br>
     3 | ERROR | Missing short description in doc comment<br>
    --------------------------------------------------------------------------------</p>
    

    Time: 65ms; Memory: 5.25Mb<br>
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Source: http://pareview.sh/ - PAReview.sh online service

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes : Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
No: Does not Follows the guidelines for in-project documentation and/or the README Template.Update your Read me file.
Code long/complex enough for review
[Yes: Follows / No: Does not follow] the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements
Coding style & Drupal API usage
  1. static_server.module : Wrong doc comment in static_server_admin_setting_form
  2. static_server.module : function static_server_admin_setting_form you should move this to a separate file .admin.inc because the code in .module file execute on each page request.
  3. Its best practice to add hook_help in the module.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

This review uses the Project Application Review Template.

Specify on the project page if the module works only for public files.

Not seen any application blocker.Setting this to RTBC :)

naveenvalecha’s picture

Title: Static Server 7.x » [D7] Static Server
Issue summary: View changes
zeeshan_khan’s picture

Hi Naveen,

Thanks for the review, I have fixed readme.txt issues also.

zeeshan_khan’s picture

Issue tags: +PAReview: Reviewed
mpdonadio’s picture

Assigned: Unassigned » mpdonadio
Issue tags: -PAReview: Reviewed

Assigning to myself for next review, which may be tomorrow morning.

mpdonadio’s picture

Assigned: mpdonadio » Unassigned
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

Sorry for the delay; the flu ran through my household...

Automated Review

pareview.sh http://git.drupal.org/sandbox/zeeshan_khan/2390723.git

Review of the 7.x-1.x branch (commit 94150cf):

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation. DIfferent enought from CDN in my mind.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party code
Yes: Follows the guidelines for 3rd party code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
No: Does not follow the guidelines for project length and complexity.
Secure code

Not seeing any problems.

Coding style & Drupal API usage

(+) You can move your setting form to an include; this helps with memory footprint.

In general, single quotes strings are preferred over double quoted ones.

static_server_file_url_alter() has the wrong docblock. It should be "Implements hook_file_url_alter()."

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

So, this really only implements three hooks and a form. I don't think this shows enough Drupal API samples to warrant an exception to single project promotions. Please confirm that you are OK with this, and that you are OK with "static_server" being the namespace. Personally, I think "static_asset_paths" would be better (but you would also have to refactor your module to use the new name. Please respond, and let me know what you want to do.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

zeeshan_khan’s picture

Hi mpdonadio,

Hope everything is fine now at your household!

This is a simple project to add static server to your web site for the speed enhancement, I guess naming convention is fine for now
and please give me the rights to promote this project as a single full project. This project is gonna be a good help for those who wants to have the same functionality.

zeeshan_khan’s picture

Status: Postponed (maintainer needs more info) » Needs review
mpdonadio’s picture

Assigned: Unassigned » mpdonadio

I will take care of this later today.

mpdonadio’s picture

Assigned: mpdonadio » Unassigned
Status: Needs review » Fixed

Thanks for your contribution, zeeshan_khan!

I promoted your sandbox into a full project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

zeeshan_khan’s picture

Thank you very much mpdonadio, for your time and suggestion, I will definitely look into it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.