[D7] Static Server [#2391173]

Comment	File	Size	Author
	static_server.zip	1.86 KB	zeeshan_khan

Comment #1

zeeshan_khan CreditAttribution: zeeshan_khan commented 11 December 2014 at 07:43

Issue summary:

View changes

Log in or register to post comments

Comment #2

PA robot CreditAttribution: PA robot commented 11 December 2014 at 11:23

Status:

Needs review

» Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxzeeshan_khan2390723git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Log in or register to post comments

Comment #3

zeeshan_khan CreditAttribution: zeeshan_khan commented 11 December 2014 at 15:41

Thanks a lot for reviewing my project :)
Yes I reviewed and fixed all the issues those came across by running pareview.sh

Many Thanks

Log in or register to post comments

Comment #4

zeeshan_khan CreditAttribution: zeeshan_khan commented 11 December 2014 at 15:45

Priority:	Normal	» Major
Status:	Needs work	» Fixed

Log in or register to post comments

Comment #5

zeeshan_khan CreditAttribution: zeeshan_khan commented 12 December 2014 at 05:35

GIT clone command:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/zeeshan_khan/2390723.git static_server
cd static_server

Log in or register to post comments

Comment #6

sumitmadan CreditAttribution: sumitmadan commented 12 December 2014 at 05:47

This application review should be closed by git admin after you get git vetted user role. You should keep this is needs review state if you think no issues pending that are reported by someone. Also you should assign it to yourself too.

Log in or register to post comments

Comment #7

zeeshan_khan CreditAttribution: zeeshan_khan commented 12 December 2014 at 06:56

Assigned:	zeeshan_khan	» Unassigned
Status:	Fixed	» Needs review

Log in or register to post comments

Comment #8

zeeshan_khan CreditAttribution: zeeshan_khan commented 12 December 2014 at 07:48

Issue summary:	View changes
Issue tags:	-static server module	+PAreview: review bonus

Log in or register to post comments

Comment #9

naveenvalecha

He/Him

Hindi

CreditAttribution: naveenvalecha commented 12 December 2014 at 08:16

Issue tags:

+PAreview: single application approval

Log in or register to post comments

Comment #10

deepakaryan1988

Hindi

CreditAttribution: deepakaryan1988 commented 12 December 2014 at 09:17

This module seems to be alright but there should one thing still to do.
You should do variable_del in the .install for whatever you have set the variables in the variable table.

Thanks,
Deepak Kumar

Log in or register to post comments

Comment #11

deepakaryan1988

Hindi

CreditAttribution: deepakaryan1988 commented 12 December 2014 at 09:17

Status:

Needs review

» Needs work

Log in or register to post comments

Comment #12

zeeshan_khan CreditAttribution: zeeshan_khan commented 12 December 2014 at 16:50

Hi Deepak,

Thanks for providing your valuable feedback,
I have added .install file with variable_del for all the variables I'd set.

Thanks

Log in or register to post comments

Comment #13

zeeshan_khan CreditAttribution: zeeshan_khan commented 13 December 2014 at 04:40

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #14

naveenvalecha

He/Him

Hindi

CreditAttribution: naveenvalecha commented 13 December 2014 at 09:52

Status:

Needs review

» Reviewed & tested by the community

@deepakaryan1988,
Its best practice to remove the code used variables from the module.Have you seen any other application blocker made you to stop this to RTBC.if it is then specify.

Automated Review

Review of the 7.x-1.x branch (commit 6f8f80c):

Coder Sniffer has found some issues with your code (please check the Drupal coding standards).

<p></p>
<p>FILE: /var/www/drupal-7-pareview/pareview_temp/static_server.install<br>
--------------------------------------------------------------------------------<br>
FOUND 1 ERROR AFFECTING 1 LINE<br>
--------------------------------------------------------------------------------<br>
 3 | ERROR | Missing short description in doc comment<br>
--------------------------------------------------------------------------------</p>

Time: 65ms; Memory: 5.25Mb<br>

No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Source: http://pareview.sh/ - PAReview.sh online service

Manual Review

Individual user account: Yes: Follows the guidelines for individual user accounts.
No duplication: Yes: Does not cause module duplication and/or fragmentation.
Master Branch: Yes : Follows the guidelines for master branch.
Licensing: Yes: Follows the licensing requirements.
3rd party assets/code: Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md: No: Does not Follows the guidelines for in-project documentation and/or the README Template.Update your Read me file.
Code long/complex enough for review: [Yes: Follows / No: Does not follow] the guidelines for project length and complexity.
Secure code: Yes: Meets the security requirements
Coding style & Drupal API usage

This review uses the Project Application Review Template.

Specify on the project page if the module works only for public files.

Not seen any application blocker.Setting this to RTBC :)

Log in or register to post comments

Comment #15

naveenvalecha

He/Him

Hindi

CreditAttribution: naveenvalecha commented 13 December 2014 at 09:55

Title:	Static Server 7.x	» [D7] Static Server
Issue summary:	View changes

Log in or register to post comments

Comment #16

zeeshan_khan CreditAttribution: zeeshan_khan commented 13 December 2014 at 18:18

Hi Naveen,

Thanks for the review, I have fixed readme.txt issues also.

Log in or register to post comments

Comment #17

zeeshan_khan CreditAttribution: zeeshan_khan commented 15 December 2014 at 05:52

Issue tags:

+PAReview: Reviewed

Log in or register to post comments

Comment #18

mpdonadio

he/him

English

Philadelphia/PA/USA (UTC-5)

CreditAttribution: mpdonadio commented 17 December 2014 at 14:42

Assigned:	Unassigned	» mpdonadio
Issue tags:	-PAReview: Reviewed

Assigning to myself for next review, which may be tomorrow morning.

Log in or register to post comments

Comment #19

mpdonadio

he/him

English

Philadelphia/PA/USA (UTC-5)

CreditAttribution: mpdonadio commented 23 December 2014 at 19:15

Assigned:	mpdonadio	» Unassigned
Status:	Reviewed & tested by the community	» Postponed (maintainer needs more info)

Sorry for the delay; the flu ran through my household...

Automated Review

pareview.sh http://git.drupal.org/sandbox/zeeshan_khan/2390723.git

Review of the 7.x-1.x branch (commit 94150cf):

No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation. DIfferent enought from CDN in my mind.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party code

Yes: Follows the guidelines for 3rd party code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

No: Does not follow the guidelines for project length and complexity.

Secure code

Not seeing any problems.

Coding style & Drupal API usage

(+) You can move your setting form to an include; this helps with memory footprint.

In general, single quotes strings are preferred over double quoted ones.

static_server_file_url_alter() has the wrong docblock. It should be "Implements hook_file_url_alter()."

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

So, this really only implements three hooks and a form. I don't think this shows enough Drupal API samples to warrant an exception to single project promotions. Please confirm that you are OK with this, and that you are OK with "static_server" being the namespace. Personally, I think "static_asset_paths" would be better (but you would also have to refactor your module to use the new name. Please respond, and let me know what you want to do.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Log in or register to post comments

Comment #20

zeeshan_khan CreditAttribution: zeeshan_khan commented 24 December 2014 at 06:08

Hi mpdonadio,

Hope everything is fine now at your household!

This is a simple project to add static server to your web site for the speed enhancement, I guess naming convention is fine for now
and please give me the rights to promote this project as a single full project. This project is gonna be a good help for those who wants to have the same functionality.

Log in or register to post comments

Comment #21

zeeshan_khan CreditAttribution: zeeshan_khan commented 13 January 2015 at 09:49

Status:

Postponed (maintainer needs more info)

» Needs review

Log in or register to post comments

Comment #22

mpdonadio

he/him

English

Philadelphia/PA/USA (UTC-5)

CreditAttribution: mpdonadio commented 13 January 2015 at 14:40

Assigned:

Unassigned

» mpdonadio

I will take care of this later today.

Log in or register to post comments

Comment #23

mpdonadio

he/him

English

Philadelphia/PA/USA (UTC-5)

CreditAttribution: mpdonadio commented 13 January 2015 at 18:29

Assigned:	mpdonadio	» Unassigned
Status:	Needs review	» Fixed

Thanks for your contribution, zeeshan_khan!

I promoted your sandbox into a full project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.