Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.
As noted previously I normally I prefer not to comment on issues in this queue in a way that would slow them down, however the applicant reached out directly via Slack.
Quick glancing the code I'm not sure if this qualifies as single author any longer.
A sizeable amount of the code was refactored as part of fixing phpcs by another developer in https://git.drupalcode.org/project/progresscirclebar/-/commit/a82fc1b516..., this accounts for a reasonable size of the php code base, and has removed the chance for reviewers to see how the applicant would fix the concerns on their own.
Leaving as NR for second opinion on if this is suitable for review. I have not done any automated, or in depth manual review beyond the review of the commit logs.
This thread has been idle, in the needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).
If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.
Comments
Comment #2
zeeshan_khan commentedComment #3
avpadernoComment #4
cmlaraCorrecting metadata so the issue appears on the list of applications to be reviewed.
Comment #5
cmlaraAs noted previously I normally I prefer not to comment on issues in this queue in a way that would slow them down, however the applicant reached out directly via Slack.
Quick glancing the code I'm not sure if this qualifies as single author any longer.
A sizeable amount of the code was refactored as part of fixing phpcs by another developer in https://git.drupalcode.org/project/progresscirclebar/-/commit/a82fc1b516..., this accounts for a reasonable size of the php code base, and has removed the chance for reviewers to see how the applicant would fix the concerns on their own.
Less review blocking commits (though they often do hold up reviews) like adding a README that complies with the D.O. project templates were also done by a 3rd party in https://git.drupalcode.org/project/progresscirclebar/-/commit/080c82b2e0...
I will also note that a single line commit https://git.drupalcode.org/project/progresscirclebar/-/commit/d4bbd07c19... was originally authored by a different developer in #3370545: Add missing configure route to info file. though they do not appear to be credited on the commit itself.
Leaving as NR for second opinion on if this is suitable for review. I have not done any automated, or in depth manual review beyond the review of the commit logs.
Comment #6
avpadernoI agree with the previous comment.
We need another project to review, where most of the commits have been done from the person who creates the application.
Comment #7
vinaymahale commentedComment #8
avpadernoI am removing the reported manual reviews for other applications, as per Review bonus, since this application has been already reviewed.
Comment #9
avpadernoI am changing priority as per Issue priorities.
Comment #10
rushikesh raval commentedThis thread has been idle, in the needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).
If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.