[D7] Functional content

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxSpadXIII2164153git

I'm a robot and this is an automated message from Project Applications Scraper.

For review by me

Manual Review

- Remove the packaging lines from the .info. These will be added when the module is published.
- All variables used in your module should be removed in hook_uninstall().
- You must use check_plain() in functional_content_admin_config() for example where you do '#title' => $view_info['view_label'] . ' - ' . $view_info['display_label'] (filter_xss() or filter_xss_admin() are alternatives to check_plain() if you want to allow some tags here). Same for all your #description values, you should apply check_plain() in functional_content_admin().

functional_content.install : module_load_include('module', 'functional_content'); Wrong syntax and No need to load module file here because you can call the functions defined in module file in any file.I found there is no usage of this.Is it ?

The module is already disabled, which makes drupal not load the .module anymore. When uninstalling the module, I need to load its .module so I can use the defines to remove the variables.

There is no need to load the module file because you are getting the variables directly from the variables table and removing them using the variable_del.
So I have not seen any use of the module load include.we should not use it at all.
This is not a release blocker but you should remove it.

Another thing that I have noticed that your commits are not linked with your drupal profile. See the git instructions properly https://www.drupal.org/project/2164153/git-instructions So that the commits will display on your user profile page.This will show your contribution on your profile as well.

Automated Review

Yes. You can check: http://pareview.sh/pareview/httpgitdrupalorgsandboxspadxiii2164153git

Manual Review

Individual user account

Yes. You can read https://www.drupal.org/node/272587

No duplication

I would like read your explanation about why is better this method to enable the block for a specified node id with the standard block settings.

Master Branch

Yes. You can check: https://www.drupal.org/node/1127732

Licensing

Yes. You can check: https://www.drupal.org/licensing/faq

3rd party code

It's ok, too: https://www.drupal.org/node/422996

Code long/complex enough for review

Yes. You can check: https://groups.drupal.org/node/195848

Secure Code

Yes, you can check
+ https://www.drupal.org/writing-secure-code

Coding style & Drupal API usage

In .info you must introduce entity_reference_autocomplete as dependency.

Hi SpadXIII,

I tried to review your module by following your installation and configuration steps everything worked fine to me but at the end I couldn't find my view block on that node page, I followed these steps.

1. Create a view with a block display
2. Create a node and remember its node id
3. Go to the functional content settings
4. Enable the functional content for the view block you just created
5. Optionally have the module generate a context; enter the context name, tag
and select the region for the view block
6. Save the settings and go to the functional content nodes
7. Enter the node id from the node you created step 3
8. If you did generate the context, you're ready to go! Just browse to the node
you created in step 3 and see the marvelous view appear in the region you
selected!
If you did not choose to automatically generate the context, you can create
your own; just select the correct Functional Content-callback in the
Callback conditions, etc. - This step didn't work out

Any idea?

Review of the 7.x-1.x branch (commit d226353):

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. So you are storing your configuration int he variable table. That will not scale if you have many functional content node configured on your site, right? The whole variable table is loaded into memory on every single page request, so I would suggest to use your DB table.
2. functional_content.api.php: functional_content_functional_content() should be hook_functional_content().
3. functional_content_node_access(): why do you prevent node deletion here? Please add a comment.
4. _functional_content_item_name(): doc block is wrong. What info required?
5. functional_content__callback(): why do you need !arg(2) here? Please add a comment.
6. functional_content_node_load(): why do you need to slow down global node loads by adding your stuff here? Can't you load the functional content stuff only when it is actually needed? Please add a comment.

But that a re not application blockers, otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to patrickd as he might have time to take a final look at this.

no objections for more than a week, so ...

Thanks for your contribution, SpadXIII!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.