[D7] Bulk apply comment settings

Hi Tom,

Found a few issues on http://pareview.sh/ here:

http://pareview.sh/pareview/httpgitdrupalorgsandboxtomclopez2331441git

Darren

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I installed the module from Git link above, turned it on, went to the comment section for an existing content type, checked the 'Bulk Apply Comment settings', hit Save. I received the following error:

PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'name' in 'where clause': UPDATE {node} SET comment=:db_update_placeholder_0 WHERE (type = :db_condition_placeholder_0) AND (name = :db_condition_placeholder_1) ; Array ( [:db_update_placeholder_0] => 2 [:db_condition_placeholder_0] => feed_importer [:db_condition_placeholder_1] => bulk_apply_comment_settings ) in bulk_apply_comment_settings_form_node_type_form_submit() (line 30 of /var/www/mysite.ash/html/modules/bulk_apply_comment_settings/bulk_apply_comment_settings.module).

Additionally, the same thing happens with all content types on my test site.

I have re-installed and am not getting the error. Great job @T-Lo!

@T-lo this module looks really great!

Just one suggestion, I'd recommend using the batch API to process the comment changes. So that you won't run into issues when scaling to large numbers of nodes.

https://www.drupal.org/node/180528
https://api.drupal.org/api/drupal/includes!form.inc/group/batch/7

@T-lo, thankyou for your contribution!

Automated Review

Best practice issues identified by pareview.sh / drupalcs / coder. None. Good Work

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

No: Follows the licensing requirements

3rd party code

Yes: Follows the guidelines for 3rd party code.

README.txt/README.md

Yes/No: Follows the guidelines for in-project documentation and the README Template.

Code long/complex enough for review

No: Follows the guidelines for project length and complexity. WIll proceed with single project promotion.

Secure code

Yes. If "no", list security issues identified.

Coding style & Drupal API usage

1. (*) bulk_apply_comment_settings_form_node_type_form_submit(): In following code you have used the batch api, that's not the best way to use BatchAPI. You should only add the operation once, and let the operation iterate over a set number of results, using the sandbox to mark how far it got each time.
   

   foreach ($nodes as $node) {
         $node->comment = $form_state['values']['comment'];
         $batch['operations'][] = array('node_save', array($node));
       }
   

2. hook_help() is missing in your module.
3. bulk_apply_comment_settings_install(): do not juggle with module weights as this is not reliable. Is it really required in your case, please add your comment on this.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

First point looks blocker to me, preventing RTBC. Other than this module looks good to me, appreciate your module idea.

As I am not a git administrator, so I would recommend you, please help to review other project applications to get a review bonus. This will put you on the high priority list, then git administrators will take a look at your project right away :-)

Thanks Again!

Assigning to myself for next review.

Automated Review

Review of the 7.x-1.x branch (commit c04325a):

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Manual Review

My blocking issues from #11 have been addressed, batch api code looks good.

Correct admistrator spelling in Readme, also make it similar to README Template.

Else Project page and Doc/comments looks good to me. Good Work!

Nothing major jumped out at me, also removing single project promotion tag as now module having 5 functions and source code is 124 lines long that makes you eligible for "create full projects" permission :).

I am not seeing any blocking issues. Assigning to mpdonadio for a second look if he has time, in past he also posted resolution for same http://drupal.stackexchange.com/questions/26224/mass-node-update-e-g-dis....

Automated Review

Best practice issues identified by pareview.sh / drupalcs / coder. Please don't copy/paste all of the results unless they are short. If there are a lot, then post a link to the automated review and mention that problems should be addressed.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements

3rd party code

Yes: Follows the guidelines for 3rd party code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and the README Template. Could be a little better, though.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes. If "no", list security issues identified.

Coding style & Drupal API usage

bulk_apply_comment_settings_module_implements_alter() should have a comment why it is needed. Looks like you are just making sure it is the last one?

The limit in the batch should really be a variable, preferable exposed via a setting form.

The docblock for bulk_apply_comment_settings_batch_update_nodes() should mention that it is the batch callback.

bulk_apply_comment_settings_batch_update_nodes() only really needs to query for the nid, which will simplify this query and make it much quicker.

Since you don't need ->addTag('node_access) for these (this is an admin thing, so bypassing access control is OK), you can convert these to static db_query() calls.

This should also have an action associated with it for the admin/content page for people who don't have VBO installed.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

This module squeaks by the our recomendatins for full vetted access, but it looks like evrything is done properly, and the application shows understanding of multiple APIs.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Thanks for your contribution, T-lo !

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.