[D7] Multi Criteria Content Rating

Hi,

Could you please share the links of projects for which you performed manual review.

Prajwal

Hi @sebto,

Help to review other project applications to get a review bonus. This will put you on the high priority list, then git administrators will take a look at your project right away :-)

Hi,

Thanks for the contribution, mean while some small suggestions if you like to update.

Automated Review as some warnings and errors
http://pareview.sh/pareview/httpgitdrupalorgsandboxyelban2330529git

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.

No duplication
Yes
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements
3rd party code
Yes: Follows the guidelines for 3rd party code.
README.txt/README.md
Yes
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
YES
Coding style & Drupal API usage

1) i dont the schemas defined getting used.
2) delete the defined schemas in unistall hook
3) Looks like you are updating node object in multi_criteria_content_rating_rating_full_results but the node object is not accepted as reference.
4) Not a good practice
$output = ' $max_range) . '%;">' .
(number_format($avg, 2) + 0) . '';
$output = '

';

Try preparing a renderable array and use drupal render.

Did just a first round of review, will do some more testing around.

Prajwal

Hi sebto,

The pareview warnings should be cleaned up for coding standards.

I'll take a closer look at the code now.

Running through all the code now, some small things:

multi_criteria_content_rating.install

incorrect comment for the hook uninstall:

/**
 * Implements hook_schema().
 */

multi_criteria_content_rating.admin.inc

Spelling mistake "Allowd" suggest "Allowed" in form item title

 $form['multi_criteria_content_rating_node_types'] = array(
    '#type' => 'checkboxes',
    '#title' => t('Allowd Content types'),
    '#options' => multi_criteria_content_rating_get_node_types_options(),
    '#default_value' => variable_get('multi_criteria_content_rating_node_types', array())
  );

Duplicated form item title:

$form['multi_criteria_content_rating_max_range'] = array(
    '#type' => 'textfield',
    '#title' => t('Maximum of rating range'),
    '#default_value' => variable_get('multi_criteria_content_rating_max_range', 10)
  );
  $form['multi_criteria_content_rating_coloring'] = array(
    '#type' => 'textarea',
    '#title' => t('Maximum of rating range'),
    '#default_value' => variable_get('multi_criteria_content_rating_coloring', multi_criteria_content_rating_coloring_default())
  );

The item "multi_criteria_content_rating_coloring" could do with some decent instructions or perhaps splitting into multiple feilds

Until you've saved a new formatter via the admin form the first time, the "Node type" dropdown is empty, the first submit also gives the following error:

Notice: Undefined index: id in multi_criteria_content_rating_add_criteria_form_elements_submit() (line 92 of . .. . /multi_criteria_content_rating/multi_criteria_content_rating.admin.inc).

It looks like these could be solved by either:
Disabling creation of new formatters until the allowed content type section had been filled in.
Or, allowing all node types by default, adding the function "multi_criteria_content_rating_get_node_types_options" as the default value of the variable "multi_criteria_content_rating_node_types"
You've got it with a blank array as the default value in several places

$form['entity_view_modes']['new']['type'] = array(
    '#type' => 'select',
    '#title' => t('Node type'),
    '#options' => array(
      '0' => t('None')
    ) + variable_get('multi_criteria_content_rating_node_types', array())
  );

I get the following Fatal PHP error when I visit a node I'm expecting to see the rating on:

Fatal error: Cannot access empty property in /home/codio/workspace/sites/all/modules/multi_criteria_content_rating/multi_criteria_content_rating_criteria_operations.class.inc on line 94

#

I can't see where the variable "mc_content_rating_term_fields" is ever set to anything other than an empty array which seems to explain that.

It looks like you meant to use the variable you set in the admin here:
variable_set('multi_criteria_content_rating_term_fields', $allowd_fields);

(also further misspelling of "allowed" throughout as "allowd")

unless I'm mistaken the same variable name issue is present in includes/views/multi_criteria_content_rating_views_handler_rating_avg.inc
the variable "mc_content_rating_max_range" isn't referenced anywhere else, although there is a "multi_criteria_rating_max_range" used elsewhere

/**
   * Overrides the parent render.
   */
  public function render($values) {
    module_load_include('class.inc', 'multi_criteria_content_rating', 'multi_criteria_content_rating_user_ratings');
    drupal_add_css(drupal_get_path('module', 'multi_criteria_content_rating') .
       '/multi_criteria_content_rating.css');
    $max_range = variable_get('mc_content_rating_max_range', 10);
    $content_vote_result = MultiCriteriaContentRatingUserRatings::getUserRatingsResultForContent($values);
    $total = 0;
    foreach ($content_vote_result as $vote) {
      $total += $vote->value_avg;
    }
    $avg = $total / count($content_vote_result);
    return multi_criteria_content_rating_rating_summary_results_output($avg, $max_range);
  }

it's worth noting the two variables "mc_content_rating_max_range" and "mc_content_rating_term_fields" aren't removed by the uninstall_hook, so if you used to use these variablew names they won't be cleared on uninstall and could still be present in your dev environment

A similar naming issue in multi_criteria_content_rating_criteria_modes.class.inc gives a PDO error when the variable is used in the "getCriteriaMode" function, as the table "mc_content_rating_criteria_modes" isn't created in the hook_schema.
The correct table is probably "multi_criteria_content_rating_criteria_modes"

class MultiCriteriaContentRatingCriteriaModes {

  /**
   * The name of table which criteria modes are stored in.
   */
  private static $tableName = 'mc_content_rating_criteria_modes';

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.