[D7] Taxonomy Server

A bunch of errors and warnings from PAreview:
http://pareview.sh/pareview/httpgitdrupalorgsandboxspajennios2185537git

Notable:
- The .info file references a nonexistent .test file.
- Bunch of unused variables.
- Unexecutable code following 'return;' statements (line 143 the most egregious example).
- Lots of missing or ill-formatted comments.

As has been recommended to me already, consider $GLOBALS['user'] instead of global $user (line 195). Of course, that $user variable isn't actually being used in that function (taxonomy_server_form_alter()), so you should just remove it altogether.

Module installed fine, but it wasn't clear what to do next. The module doesn't setup any services, and I didn't know how I should configure my own. Thus, on a fresh system, enabling this module doesn't provide functionality described in the README.md file. Going to /api/taxonomy_server_vocabulary just throws back a "Page not found" error.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2267611

Project 2: https://www.drupal.org/node/2299771

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2299771

Project 2: https://www.drupal.org/node/2267611

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Your dev branch is still containing several warnings as I see on pareview. Mostly in the documentation which bugs could be easily corrected. (ex.: comments longer than 80 characters.) (If you need some help check the official documentation.)

Also you should use only the 7.x-1.x branch (as you see on pareview warning), so merge your fixes to 7.x-1.x.

Hi paJenniOs,
Here are my reviews and comments about your module:

Automated Review

Please update the issue summary and add a link to the project page.

Webmasters are currently quite busy with all the project applications and prefer projects with a review bonus.
Please help reviewing and put yourself on the high priority list, then they will take a look at your project right away :-)

Also noticed there isn't activity lately in this issue.

If you are still working on this module please put this issue back to Needs review,
otherwise if you have abandoned this module please close this issue to help the webmasters work.
https://www.drupal.org/node/894256#unsupported-module

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi SpaJenniOs,

1) Sandbox project page link is missing in your issue Summary.

2) Add correct git clone command in your issue Summary.
Correct git clone command will be:
git clone --branch 7.x-1.x http://git.drupal.org/project/taxonomy_revision.git

3) No need to use quote in package name in *.info file.
It should be
package = Taxonomy

4) It would be be better if your *.info file look like

name = Taxonomy revision
description = Adds revision support for taxonomy terms.
core = 7.x
package = Taxonomy
dependencies[] = taxonomy
dependencies[] = entity

files[] = views/views_handler_argument_taxonomy_term_revision_id.inc
files[] = views/views_handler_field_taxonomy_term_revision.inc
files[] = views/views_handler_field_taxonomy_term_revision_link_delete.inc
files[] = views/views_handler_field_taxonomy_term_revision_link_revert.inc

5) In README.txt file, line no. 32
It should be /admin/modules instead of admin/build/modules

6) You should provide the hook_help to allow site builders to find information about your module using Drupal UI.

Hi, Please correct your git link, as this requires your password for cloning.

Hi,

Great job.!! :)

But there is a problem in your git command.
The proper way should be "git clone --branch 7.x-1.x http://git.drupal.org/project/taxonomy_revision.git taxonomy_revision".
It would be great if you can fix them up. :)

Hi there, some suggestions from my review of your module:

1. Include some more info on the sandbox project page. https://www.drupal.org/node/997024 may help.

2. The README.md could also do with some added content: Module summary. When would someone need to use your module? The info file alludes to a logging feature but this is not mentioned in the README.

3. As above, the help provided by hook_help could also be expanded.

4. I would personally recommend using something like $account = $GLOBALS['user'] rather than global $user.

5. It would seem that your permissions system is not enabled. I would suggest getting this up to speed before deploying.

Hope that helps.

Updated git command, it requires https in url.

Hi! Great module! However, I am a bit lost directly after installing. Is the taxonomy_server_sample_service required or should I set up my own services? I saw you've put a lot of effort in the README, perhaps you can explain a little better how the configuration should be done?

Also, I've run an automated review and you still have some issues. You can check them here: http://pareview.sh/pareview/httpsgitdrupalorgsandboxspajennios2185537git

Most of them are docs related so they should be easy to fix.

One last thing: your branch name is 7.x while it should be 7.x-1.x so it is clear on what version you are working.

Keep up the good work!

Here's my report:

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

No: Does not follow the guidelines for master branch. The current working branch is 7.x instead of 7.x-1.x.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template. However, some extra config instructions would be nice.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

Code looks good in general. A lot of todo's, though.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.