Make "create a new revision" collapsed by default

Tagging

I don't see clear differences?

None of the screenshots show that. Also, this is a configurable default, not an enforced default!

You can configure it for each content type at admin/structure/types/manage/article → Publishing options → Default options → Create new revision.

Please also take into account the implications beyond visual noise of having this disabled by default: it will mean that by default, Drupal will not protect the user against accidental mistakes, by creating a new revision each time!

I think the correct fix is not to separate this out in another collapsable item, but only opening this by default when a revision message is required. By default its not in core, therefore it will stay collapsed. A patch for that should be simple, and resolve Kevin's concerns.

@tkoleary No, essentially - unless the "message" part of the revision is required. It will not collapse by default. Which means that it will still make a revision, but its not open by default anymore unless the message part is required.

I don't understand #9.

The revision log message has never been required. There is no way to make it required. Plus, when it's optional, the user should be able to enter such a message anyway.

So how then will the user be able to enter a revision log message?

Or are you arguing that there should be a new setting besides the "Create new revision by default" setting, called something like "Require a log message when creating a new revision"?

I am arguing for the latter, adding that checkbox. Since its optional, you can always expand it - I don't see any trouble there.

There is already something like this on d.o, when you change a docs page.

#14: how would you expand it if it is invisible?

d.o docs pages just "hide" it in a fieldset, that is open by default? How is that hidden by default? Surely we don't want another fieldset?

I'm extremely confused. Clear before vs. after mocks would be most helpful.

resized

Patch for review

@shumer: There is a small typo: '#title' => t('Add log messge'),

Typo still exists: '#title' => t('Add log messge'),

I am at Drupalcon Austin and I'm reviewing this patch.

I was going to reroll this patch because it is stale, and I got it rerolled but I'm not going to upload it because after further consideration, I've decided that I don't like the proposed change. I feel that the extra checkbox for "Add log message" Overcomplicates the decisions the user has to make. Whether the log message field is displayed to the user or not, it is not required and adding the extra toggle visibility box just gets in the way.

Tried out the patch, it does need a reroll. But it doesn't seem a necessary addition.

What it does is add another checkbox for the user to add a message, but on checking this checkbox it only makes the add message textarea show up. It doesn not even make the revision message required. This infact seems to be an unneccesary addition to what is already present.

Moving this to minor priority.

But rerolling the patch anyway, for others to try out. Maintainers please close issue if this will not be worked upon.

Triggering testbot on patch in #28. Regardless of any decision to proceed, it would be nice to know if patch is clean.

Reroll of #28.

+++ b/core/modules/node/src/NodeForm.php
@@ -150,10 +150,24 @@ public function form(array $form, FormStateInterface $form_state) {
+      '#access' => $node->isNewRevision() || user_access('administer nodes'),

Fatal error: Call to undefined function Drupal\node\user_access() in /home/sa08b0b10dc8ddca/www/core/modules/node/src/NodeForm.php on line 157

user_access function deprecated.
You should be use $current_user->hasPermission('administer nodes') instead user_access()
See core changes user_access() got converted to a method on the user/accountInterface

OK here is the patch with the reroll, the interdiff and looks like that :)

The summary is not clear what was proposed!

/admin/structure/block/block-content uses nearly the same widget so it makes sense to unify them

#34 is no way, also no reason to abuse a cleaned node form

Hey guys!
To make block "revision information" collapsable it's enough to remove overriden this block in theme seven.
I do not know why it has been done, but file /core/themes/seven/seven.theme contain next code:

  $form['revision_information']['#type'] = 'container';
  $form['revision_information']['#group'] = 'meta';

To make this block collapsed by default need to correctly set "#open" key in node form

The patch goes wrong way imo too. Also it pointless to scroll down to actually change authoring

I'd prefer to get rid of that element "revision_information" in favour of current approach.

It makes sense to input log message only when creating revision (checkbox checked)

so maybe just move code from seven to default implementation at least?

@tkoleary Isn't it a special snowflake because we wish to elevate that one?

We're going to look at this at DrupalCon LA.

It's unclear what needs to be done here, so we're removing the "Novice" tag.

Any reason to have this checkbox when creating a node? this is a first revision anyway!
Also node edit form has revision collapsed by default but should have open when there's revisions already

IS should be updated after usability review

Seven has been removed from core. This was discussed in #frontend and markconroy said that this should move to the 'theme system' component. I am doing that now.