[meta] Don't call theme() directly anywhere outside drupal_render()

$> grep -r " theme(" . | wc -l
358

This should be fun. :)

I'll also add some tasks as well.

there could be a lot of novice issues for sprint

Denote that the remaining task list isn't comprehensive.

I added a link to https://api.drupal.org/api/drupal/core%21includes%21theme.inc/function/c... which has the number of calls to theme() as 192.

What to do, if we have this situation?

function theme_image_crop_summary($variables) {
  return theme('image_resize_summary', $variables);
}

@Samvel suppose better remove useless functions so introduce one theme_image_effect_summary() and convert similar calls to new function

Simplify conversion instructions after IRC discussion

I'd prefere

function theme_image_crop_summary($variables) {
  // #theme image_resize_summary expects 'foo' and 'bar'.
  $image_resize_summary = array(
    '#theme' => 'image_resize_summary',
    '#foo' => $variables['foo'],
    '#bar' => $variables['bar'],
  );
  return drupal_render($image_resize_summary);
}

We are working today with this issue during Code Sprint UA.

Thank you to both. Clear for me.

@InternetDevels, sorry, not specially.

Remove block issue from 'fixed' section - no theme() calls there.

How would that be done correctly, though? That's not clear to me.

Before code:

 <div  class="field field-name-field-tags field-type-taxonomy-term-reference field-label-above clearfix" data-edit-id="node/1/field_tags/und/teaser"><h3 class="field-label">Tags: </h3><ul class="links"><li class="taxonomy-term-reference-0" rel="dc:subject"><a href="/drupal/taxonomy/term/1" typeof="skos:Concept" property="rdfs:label skos:prefLabel" datatype="">ghfghh</a></li></ul></div>

After code:

<div class="field field-name-field-tags field-type-taxonomy-term-reference field-label-above clearfix" data-edit-id="node/1/field_tags/und/teaser"><h3 class="field-label">Tags: </h3><ul class="links"><li class="taxonomy-term-reference-0" rel="dc:subject"><a href="/drupal/taxonomy/term/1" typeof="skos:Concept" property="rdfs:label skos:prefLabel" datatype="">ghfghh</a></li></ul></div>

Patch seemed to work! The visuals of the cite looked the same after the patch. In addition the code also looks the same!

cleanup

moar cleanup

cleanup

.

reorg

reorg

reorg

reorg

forum

yes, #22 was a cross post. sorry about that :)

tax needs work

for colors

reorder

unpostpone

spacing

up

reorg

reorg

reorg

update

reorg

reorg

moved to completed:

Updated issue summary.

Updated issue summary.

Updated issue summary.

Updated issue summary.

Updated issue summary.

Updated issue summary.

reorg

reorg

reorg

Move up taxonomy

reorg

reorg

reorg

reorg

up

Reshuffle

up

I've noticed conversions of low level tests around theme() and theme hook implementation output that should not be converted. These tests are a different kind of animal and need a different kind of review. Splitting off test files would speed up these issues, especially for the issues where conversion of the normal files is considered a "Novice" task. See for example #2009670: Replace theme() with drupal_render() in simpletest module and #2009674: Replace theme() with drupal_render() in system module.

up

up

Fixing spelling of "temporarily"

seeing if summary needs update

nr

up

up

Cleared up a misunderstanding around the update system and the update module, as they are two different things.

up

up

up

up

up

reorder

p

f

up

Update

update

update

up

tests

up

up

up

Update issue list

Fix formatting :P

system.module issue ready, updated summary.

The beta blocker #2173655: Refactor theme() to _theme(); make it a private API to discourage module developers from circumventing the renderable build system is postponed on this, which makes this critical and a beta blocker as well. If it gets close to beta and this isn't done, we might want to consider doing the rename first and not blocking the beta on cleanups here.

moved install.core.inc from needs patch to needs review

Move authorize.php up the totem pole ( from needs fix to needs review )

moving items to fixed.

form.inc moved to fixed.

tablesort.inc moved to review by the community

looking at comment #1

grep -r " theme(" . | wc -l
358

Count now stands at
123

Remaining - a review on 2 remaining NOVICE patches and a CRITICAL issue can be put to bed.

All issues In the hands of the core committers now

We missed one #2190427: Replace theme() with drupal_render() in form.inc. I patched it and tested it on /node/add/article.

Otherwise any remaining instances of theme() are in comments or tests. I'll address the remaining comment instances in #2173655: Refactor theme() to _theme(); make it a private API to discourage module developers from circumventing the renderable build system.

core/includes moved to fixed

I just committed the last of these from the meta issue. WOOT!

But unfortunately, I found a few more. :(

./core/modules/simpletest/lib/Drupal/simpletest/WebTestBase.php:    $output = theme($callback, $variables);
./core/modules/system/lib/Drupal/system/Tests/Theme/TableTest.php:    $this->content = theme('table', array('header' => $header, 'rows' => $rows, 'sticky' => TRUE));
./core/modules/system/lib/Drupal/system/Tests/Theme/TableTest.php:    $this->content = theme('table', array('header' => $header, 'rows' => $rows, 'attributes' => $attributes, 'caption' => $caption, 'colgroups' => $colgroups, 'sticky' => FALSE));
./core/modules/system/lib/Drupal/system/Tests/Theme/TableTest.php:    $this->content = theme('table', array('header' => $header, 'rows' => array(), 'empty' => t('No strings available.')));
./core/modules/system/lib/Drupal/system/Tests/Theme/TableTest.php:    $this->content = theme('table', array('rows' => $rows));
./core/modules/system/lib/Drupal/system/Tests/Theme/ThemeTest.php:   *   - $variables['attributes'] as passed in to theme()
./core/modules/system/lib/Drupal/system/Tests/Theme/ThemeTest.php:   * Test that theme() returns expected data types.
./core/modules/system/lib/Drupal/system/Tests/Theme/ThemeTest.php:    // theme_test_false is an implemented theme hook so theme() should return a
./core/modules/system/lib/Drupal/system/Tests/Theme/ThemeTest.php:      $output = theme('theme_test_foo', array('foo' => $example));
./core/modules/system/lib/Drupal/system/Tests/Theme/ThemeTest.php:    // suggestionnotimplemented is not an implemented theme hook so theme()
./core/modules/system/lib/Drupal/system/Tests/Theme/ThemeTest.php:    $output = theme(array('suggestionnotimplemented'));
./core/modules/system/lib/Drupal/system/Tests/Theme/TwigDebugMarkupTest.php:    $output = theme('node', node_view($node));
./core/modules/system/lib/Drupal/system/Tests/Theme/TwigDebugMarkupTest.php:    $this->assertTrue(strpos($output, "CALL: theme('node')") !== FALSE, 'Theme call information found.');
./core/modules/system/lib/Drupal/system/Tests/Theme/TwigDebugMarkupTest.php:    $output = theme('node', node_view($node2));
./core/modules/system/lib/Drupal/system/Tests/Theme/TwigDebugMarkupTest.php:    $output = theme('node', node_view($node));
./core/modules/system/tests/modules/theme_test/lib/Drupal/theme_test/EventSubscriber/ThemeTestSubscriber.php:      $GLOBALS['theme_test_output'] = theme('more_link', array('url' => 'user', 'title' => 'Themed output generated in a KernelEvents::REQUEST listener'));
./core/modules/system/tests/modules/theme_test/lib/Drupal/theme_test/ThemeTestController.php:    return theme('theme_test_template_test');
./core/modules/system/tests/modules/theme_test/lib/Drupal/theme_test/ThemeTestController.php:    return theme(array('theme_test__suggestion', 'theme_test'), array());
./core/modules/system/tests/modules/twig_theme_test/lib/Drupal/twig_theme_test/TwigThemeTestController.php:    return theme('twig_theme_test_php_variables');
./core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php:    return theme($this->themeFunctions(),
./core/modules/views/lib/Drupal/views/Plugin/views/row/RssFields.php:    return theme($this->themeFunctions(),
./core/modules/views/lib/Drupal/views/Plugin/views/style/Rss.php:    $output = theme($this->themeFunctions(),

It might be that the test-related ones need to stay there, but at least core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php and core/modules/views/lib/Drupal/views/Plugin/views/style/Rss.php should be looked into more.

There are a ton of other instances grep picks up, but they're all in comments, including out-dated ones that no longer make sense for the code below now that it's been converted to render arrays. The issue that deprecates theme() is definitely going to have its work cut out for it.

All sub-issus have been addressed. This critical is closed.

Sorry, but did you see #60? I'm not sure that's true, just yet...

I agree with #65, we should rename theme() to _theme()

We've already renamed theme to _theme. Is this what you are referring to?

#2173655: Refactor theme() to _theme(); make it a private API to discourage module developers from circumventing the renderable build system

I just looked through a grep of _theme() and couldn't find any instances that shouldn't be there. Someone else want to verify?

Yes that's it's own issue, that is either fixed or has one sub-issue left.