Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().

CommentFileSizeAuthor
#5 batching-2.png16.9 KBjessebeach
#5 drupal_render-batch-2177643-3-proof.txt1.06 KBjessebeach
#3 drupal-replace_theme_function_with_drupal_render-2177643-3.patch1010 bytesInternetDevels
#1 drupal-replace_theme_function_with_drupal_render-2177643-1.patch1010 bytesInternetDevels
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Status: Active » Needs review
FileSize
drupal-replace_theme_function_with_drupal_render-2177643-1.patch1010 bytes

Patch attached.

Status: Needs review » Needs work

The last submitted patch, 1: drupal-replace_theme_function_with_drupal_render-2177643-1.patch, failed testing.

InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Status: Needs work » Needs review
FileSize
drupal-replace_theme_function_with_drupal_render-2177643-3.patch1010 bytes

Incorrect file has been sent above. This one should be good.

jessebeach’s picture

jessebeach CreditAttribution: jessebeach commented

Looks good. Let's hope the bot likes it.

jessebeach’s picture

jessebeach CreditAttribution: jessebeach commented
Status: Needs review » Reviewed & tested by the community
FileSize
drupal_render-batch-2177643-3-proof.txt1.06 KB
batching-2.png16.9 KB

To test this patch, apply the supplied testing patch, then enable the batch_test module. Navigate to /batch-test/multistep and run a multi-step batch.

You should then see the following page.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 1c0a852 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.