Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().

CommentFileSizeAuthor
#9 drupal_remove_theme_core_lib-2008954-9.patch4.29 KBmarkie
#7 drupal_remove_theme_core_lib-2008954-7.patch4.08 KBmarkie
#4 drupal_remove_theme_core_lib-2008954-4.patch4.08 KBmarkie
#2 drupal_remove_theme_core_lib-2008954-2.patch0 bytesmarkie

Comments

thedavidmeister’s picture

thedavidmeister commented
Issue tags: +Novice
markie’s picture

markie commented
Status: Active » Needs review
StatusFileSize
new drupal_remove_theme_core_lib-2008954-2.patch0 bytes

4 files altered.

markie’s picture

markie commented
Assigned: Unassigned » markie

forgot to call dibs.

markie’s picture

markie commented
StatusFileSize
new drupal_remove_theme_core_lib-2008954-4.patch4.08 KB

and.. it tends to help to save the files BEFORE doing your git diff.. Novice doesn't even scratch the surface.

Status: Needs review » Needs work

The last submitted patch, drupal_remove_theme_core_lib-2008954-4.patch, failed testing.

thedavidmeister’s picture

thedavidmeister commented 
-      $content = theme('maintenance_page', array('content' => filter_xss_admin(t(config('system.maintenance')->get('message'), array('@site' => config('system.site')->get('name'))))));
+      $build = array(
+        '#theme' => 'maintenance_page',
+        'content' => filter_xss_admin(
+          t(config('system.maintenance')->get('message'), array('@site' => config('system.site')->get('name')))
+        ),
+      );
+      $content = drupal_render($build);

You missed the # for #content.

markie’s picture

markie commented
Status: Needs work » Needs review
StatusFileSize
new drupal_remove_theme_core_lib-2008954-7.patch4.08 KB

updated #content

thedavidmeister’s picture

thedavidmeister commented
Status: Needs review » Needs work

A minor styling thing, but we're only using $build when using #theme would conflict with another variable already in the local scope. Check the notes on the parent issue for more details :)

markie’s picture

markie commented
Status: Needs work » Needs review
StatusFileSize
new drupal_remove_theme_core_lib-2008954-9.patch4.29 KB

updated per request

thedavidmeister’s picture

thedavidmeister commented
Status: Needs review » Reviewed & tested by the community

this looks fine to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 5d83ca5 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.