Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().

CommentFileSizeAuthor
#7 replace_theme_by_drupal_render-2008974.patch5.21 KBdrupee
#3 book-replace_theme_with_drupal_render_in_book_module-2008974-3.patch5.28 KBK15.Multik

Comments

thedavidmeister’s picture

thedavidmeister commented
Issue tags: +Novice
internetdevels’s picture

internetdevels commented
Assigned: Unassigned » internetdevels

Will be done today during Code Sprint UA.

K15.Multik’s picture

K15.Multik commented
Assigned: internetdevels » Unassigned
Status: Active » Needs review
Issue tags: +CodeSprintUA
StatusFileSize
new book-replace_theme_with_drupal_render_in_book_module-2008974-3.patch5.28 KB

Patch attached.

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Reviewed & tested by the community

#3 nice work
RTBC

catch’s picture

catch
he/him
Primary language English
commented
Issue tags: -Novice, -CodeSprintUA

#3: book-replace_theme_with_drupal_render_in_book_module-2008974-3.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice, +CodeSprintUA

The last submitted patch, book-replace_theme_with_drupal_render_in_book_module-2008974-3.patch, failed testing.

drupee’s picture

drupee commented
Assigned: Unassigned » drupee
Status: Needs work » Needs review
Issue tags: -CodeSprintUA
StatusFileSize
new replace_theme_by_drupal_render-2008974.patch5.21 KB

Let's try it now.

drupee’s picture

drupee commented

#7: replace_theme_by_drupal_render-2008974.patch queued for re-testing.

siccababes’s picture

siccababes commented
Status: Needs review » Reviewed & tested by the community

I applied the patch cleanly, tested the book module, and it worked as expected! This seems good to go.

siccababes’s picture

siccababes commented

whoops, accidental double post!

drupee’s picture

drupee commented

@siccababes,

What do you mean by "accidental double post" ? can you please explain?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed fa6444e and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.