Support from Acquia helps fund testing for Drupal Acquia logo

Comments

InternetDevels’s picture

Status: Active » Needs review
FileSize
2.34 KB

Patch attached.

joelpittet’s picture

After pondering the doc changes for a while, I'm ok with these changes, could use a second opinion from the doc master @Cottser. But RTBC from me.

star-szr’s picture

Status: Needs review » Needs work
+++ b/core/includes/tablesort.inc
@@ -9,7 +9,7 @@
- * All tables created with a call to theme('table') have the option of having
+ * All tables created with a call to drupal_render() have the option of having

I would sooner change instances of theme('table') and theme_table to '#theme' => 'table', that applies to all the doc changes here.

InternetDevels’s picture

InternetDevels’s picture

Status: Needs work » Needs review
Wim Leers’s picture

Status: Needs review » Needs work
Issue tags: +quickfix
+++ b/core/includes/tablesort.inc
@@ -9,7 +9,7 @@
+ * All tables created with a call to '#theme' => 'table' have the option of having

80 col rule violation?

martin107’s picture

Status: Needs work » Needs review
FileSize
2.62 KB
0 bytes

trivial coding standard quickfix

martin107’s picture

FileSize
600 bytes
joelpittet’s picture

Maybe this will read better if reads "with a call to" changed to "when rendering a"

martin107’s picture

FileSize
2.62 KB
508 bytes

Updated comments only.

martin107’s picture

My IDE reports that many of the use statements in this file are unused and that

use Drupal\Core\Database\Connection;
use Drupal\Core\Database\Query\SelectExtender;
use Drupal\Core\Database\Query\SelectInterface;
use Drupal\Component\Utility\Url;

could be reduced to

use Drupal\Component\Utility\Url;

is that beyond the scope of this issue?

star-szr’s picture

@martin107 - yep, definitely out of scope here.

jessebeach’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
21.66 KB

The comments look fine and and the sort icon renders.

screenshot tablesort icon on a table header

catch’s picture

Opened #2189729: Factor out tablesort-indicator.html.twig as a follow-up. Patch here looks fine - will try to remember to get it next time I'm committing stuff.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.