Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
theme system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
20 Jan 2014 at 21:00 UTC
Updated:
29 Jul 2014 at 23:17 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
internetdevels commentedPatch attached.
Comment #2
joelpittetAfter pondering the doc changes for a while, I'm ok with these changes, could use a second opinion from the doc master @Cottser. But RTBC from me.
Comment #3
star-szrI would sooner change instances of
theme('table')andtheme_tableto'#theme' => 'table', that applies to all the doc changes here.Comment #4
internetdevels commentedComment #5
internetdevels commentedComment #6
wim leers80 col rule violation?
Comment #7
martin107 commentedtrivial coding standard quickfix
Comment #8
martin107 commentedComment #9
joelpittetMaybe this will read better if reads "with a call to" changed to "when rendering a"
Comment #10
martin107 commentedUpdated comments only.
Comment #11
martin107 commentedMy IDE reports that many of the use statements in this file are unused and that
could be reduced to
is that beyond the scope of this issue?
Comment #12
star-szr@martin107 - yep, definitely out of scope here.
Comment #13
jessebeach commentedThe comments look fine and and the sort icon renders.
Comment #14
catchOpened #2189729: Factor out tablesort-indicator.html.twig as a follow-up. Patch here looks fine - will try to remember to get it next time I'm committing stuff.
Comment #15
catchCommitted/pushed to 8.x, thanks!