Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().
Is this include file necessary? can we move this to a #pre_render
function on the table
element in theme.inc
?
Comment | File | Size | Author |
---|---|---|---|
#13 | tablesort-2.png | 21.66 KB | jessebeach |
#10 | interdiff-7-10.txt | 508 bytes | martin107 |
#10 | tablesort-10.patch | 2.62 KB | martin107 |
#8 | interdiff4-7.txt | 600 bytes | martin107 |
#7 | tablesort-7.patch | 2.62 KB | martin107 |
Comments
Comment #1
InternetDevels CreditAttribution: InternetDevels commentedPatch attached.
Comment #2
joelpittetAfter pondering the doc changes for a while, I'm ok with these changes, could use a second opinion from the doc master @Cottser. But RTBC from me.
Comment #3
star-szrI would sooner change instances of
theme('table')
andtheme_table
to'#theme' => 'table'
, that applies to all the doc changes here.Comment #4
InternetDevels CreditAttribution: InternetDevels commentedComment #5
InternetDevels CreditAttribution: InternetDevels commentedComment #6
Wim Leers80 col rule violation?
Comment #7
martin107 CreditAttribution: martin107 commentedtrivial coding standard quickfix
Comment #8
martin107 CreditAttribution: martin107 commentedComment #9
joelpittetMaybe this will read better if reads "with a call to" changed to "when rendering a"
Comment #10
martin107 CreditAttribution: martin107 commentedUpdated comments only.
Comment #11
martin107 CreditAttribution: martin107 commentedMy IDE reports that many of the use statements in this file are unused and that
could be reduced to
is that beyond the scope of this issue?
Comment #12
star-szr@martin107 - yep, definitely out of scope here.
Comment #13
jessebeach CreditAttribution: jessebeach commentedThe comments look fine and and the sort icon renders.
Comment #14
catchOpened #2189729: Factor out tablesort-indicator.html.twig as a follow-up. Patch here looks fine - will try to remember to get it next time I'm committing stuff.
Comment #15
catchCommitted/pushed to 8.x, thanks!