theme_tablesort_indicator() renders an image via an img tag. It looks like we could just have a link with a class on it and add the icon via CSS instead?

Comments

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Title: Factor out theme_tablesort_indicator() » Factor out tablesort-indicator.html.twig()
Issue tags: +Twig, +theme system cleanup, +Needs accessibility review

That sounds like a neat idea to me, as long as we can retain accessibility.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Issue tags: +frontend
star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr commented
Title: Factor out tablesort-indicator.html.twig() » Factor out tablesort-indicator.html.twig
mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford commented

As long as there's a link to click on, we'll probably be fine.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr as a volunteer commented
Status: Active » Closed (duplicate)

Okay #1973418: Remove tablesort-indicator.html.twig, use CSS instead has more discussion (and actually is older), so closing in favour of that one.