Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().

CommentFileSizeAuthor
#4 locale-3.png86.23 KBjessebeach
#3 interdiff-2177667-1-3.txt681 bytesInternetDevels
#3 drupal-replace-theme-with-drupal-render-in-locale_bulk_inc-2177667-3.patch1017 bytesInternetDevels
#1 drupal-replace-theme-drupal-render-localebulkinc-2177667-1.patch1.03 KBInternetDevels
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Status: Active » Needs review
FileSize
drupal-replace-theme-drupal-render-localebulkinc-2177667-1.patch1.03 KB

Patch attached.

Status: Needs review » Needs work

The last submitted patch, 1: drupal-replace-theme-drupal-render-localebulkinc-2177667-1.patch, failed testing.

InternetDevels’s picture

InternetDevels CreditAttribution: InternetDevels commented
Status: Needs work » Needs review
FileSize
drupal-replace-theme-with-drupal-render-in-locale_bulk_inc-2177667-3.patch1017 bytes
interdiff-2177667-1-3.txt681 bytes

New try.

jessebeach’s picture

jessebeach CreditAttribution: jessebeach commented
Status: Needs review » Reviewed & tested by the community
FileSize
locale-3.png86.23 KB

A simple replacement of theme() with drupal_render().

This patch can be tested at the following path after enabling the locale module: /admin/config/regional/translate/import

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed e35f411 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.