Replace theme() with drupal_render() in history module

Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().

To Test

Step 1: Go to views page (under structure).
Step 2: Enable Tracker
Step 3: Follow the path
Step 4: Make sure the time under "last post" is accurate.

Comment	File	Size	Author
#11	history-replace_theme_with_drupal_render-2009578-11.patch	823 bytes	giammi
#11
#7	history-replace_theme_with_drupal_render-2009578-7.patch	830 bytes	giammi
#7
#2	history-replace_theme_with_drupal_render-2009578-2.patch	813 bytes	InternetDevels
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

InternetDevels’s picture

Comment #1

InternetDevels CreditAttribution: InternetDevels commented 2 June 2013 at 08:17

Assigned:

Unassigned

» InternetDevels

We are working today with this issue during Code Sprint UA.

Log in or register to post comments

InternetDevels’s picture

Comment #2

InternetDevels CreditAttribution: InternetDevels commented 2 June 2013 at 13:31

Assigned:	InternetDevels	» Unassigned
Status:	Active	» Needs review
Issue tags:		+CodeSprintUA

File	Size
history-replace_theme_with_drupal_render-2009578-2.patch	813 bytes

Patch attached.

Log in or register to post comments

Comment #3

3 June 2013 at 04:36

Status:

Needs review

» Needs work

The last submitted patch, history-replace_theme_with_drupal_render-2009578-2.patch, failed testing.

Log in or register to post comments

Comment #4

thedavidmeister CreditAttribution: thedavidmeister commented 3 June 2013 at 11:35

Status:

Needs work

» Postponed

Unfortunately, because #type is actually a reserved key in renderable arrays we'll need to do this first #2010672: Rename 'type' variable of theme_mark to 'status'.

Log in or register to post comments

Comment #5

thedavidmeister CreditAttribution: thedavidmeister commented 13 June 2013 at 23:47

Status:

Postponed

» Needs work

mark has been fixed and is now #mark_type. This is no longer postponed.

Log in or register to post comments

giammi’s picture

Comment #6

giammi CreditAttribution: giammi commented 15 June 2013 at 09:28

Assigned:

Unassigned

trying...

Log in or register to post comments

giammi’s picture

Comment #7

giammi CreditAttribution: giammi commented 15 June 2013 at 09:51

Status:

Needs work

» Needs review

File	Size
history-replace_theme_with_drupal_render-2009578-7.patch	830 bytes

Patch attached

Log in or register to post comments

Comment #8

thedavidmeister CreditAttribution: thedavidmeister commented 15 June 2013 at 09:57

Status:

Needs review

» Needs work

unfortunately there's a whitespace issue in the patch in #7

Log in or register to post comments

Comment #9

thedavidmeister CreditAttribution: thedavidmeister commented 16 June 2013 at 07:49

Status:	Needs work	» Needs review
Issue tags:	-Novice, -CodeSprintUA

#7: history-replace_theme_with_drupal_render-2009578-7.patch queued for re-testing.

Log in or register to post comments

Comment #10

16 June 2013 at 09:02

Status:	Needs review	» Needs work
Issue tags:		+Novice, +CodeSprintUA

The last submitted patch, history-replace_theme_with_drupal_render-2009578-7.patch, failed testing.

Log in or register to post comments

giammi’s picture

Comment #11

giammi CreditAttribution: giammi commented 16 June 2013 at 19:35

Assigned:	giammi	» Unassigned
Status:	Needs work	» Needs review

File	Size
history-replace_theme_with_drupal_render-2009578-11.patch	823 bytes

Removed trailing spaces

Log in or register to post comments

Comment #12

16 June 2013 at 20:00

Status:	Needs review	» Needs work
Issue tags:	-Novice, -CodeSprintUA

The last submitted patch, history-replace_theme_with_drupal_render-2009578-11.patch, failed testing.

Log in or register to post comments

derheap’s picture

Comment #13

derheap CreditAttribution: derheap commented 17 June 2013 at 10:16

Status:

Needs work

» Needs review

#11: history-replace_theme_with_drupal_render-2009578-11.patch queued for re-testing.

Log in or register to post comments

Comment #14

17 June 2013 at 11:22

Status:

Needs review

» Needs work

The last submitted patch, history-replace_theme_with_drupal_render-2009578-11.patch, failed testing.

Log in or register to post comments

hussainweb’s picture

Comment #15

English

CreditAttribution: hussainweb commented 17 June 2013 at 12:33

Status:	Needs work	» Needs review
Issue tags:		+Novice, +CodeSprintUA

#11: history-replace_theme_with_drupal_render-2009578-11.patch queued for re-testing.

Log in or register to post comments

Comment #15.0

adamcowboy CreditAttribution: adamcowboy commented 18 June 2013 at 21:33

Issue summary:

Added how to test.

Log in or register to post comments

Comment #16

adamcowboy CreditAttribution: adamcowboy commented 18 June 2013 at 21:38

Status:

Needs review

» Reviewed & tested by the community

I tested it and it worked well. I also made a how to test section.

Log in or register to post comments

Comment #17

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 19 June 2013 at 20:49

Status:

Reviewed & tested by the community

» Fixed

Committed f6367c5 and pushed to 8.x. Thanks!

Log in or register to post comments

Comment #18

3 July 2013 at 20:50

Automatically closed -- issue fixed for 2 weeks with no activity.

Log in or register to post comments

Comment #18.0

(not verified) CreditAttribution: commented 3 July 2013 at 20:50

Issue summary:

Fixed errors from last post.

Log in or register to post comments