Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#14 | twig-replace_themes_page-2010086-14.patch | 1.85 KB | IshaDakota |
#14 | interdiff.txt | 608 bytes | IshaDakota |
#9 | twig-replace_themes_page-2010086-9.patch | 1.81 KB | jenlampton |
#7 | 2010086_replace-theme-system_7.patch | 1.64 KB | somepal |
#7 | interdiff_2010086_replace-theme-system.txt | 1.64 KB | somepal |
Comments
Comment #1
helga.cheberakha CreditAttribution: helga.cheberakha commentedWDG (Ukraine,Kharkov) want to implement this on Code Sprint UA.
Comment #2
andypostupdated summary with related issues
Comment #3
helga.cheberakha CreditAttribution: helga.cheberakha commentedComment #5
helga.cheberakha CreditAttribution: helga.cheberakha commentedComment #7
somepal CreditAttribution: somepal commentedcould not apply #5, throws fatal:corrupt patch at line 41.
re-rolling.
Comment #8
thedavidmeister CreditAttribution: thedavidmeister commentedDon't do this, explicitly set each variable that #theme 'image' is expecting. Please see the issue summary for the parent issue for more details.
missing trailing commas in here.
Comment #9
jenlamptonneeded a reroll too, so...
Comment #10
azinoman CreditAttribution: azinoman commentedComment #11
azinoman CreditAttribution: azinoman commentedI set the theme to the default and changed the theme a few times. I encountered no errors, everything looks good! Changing to reviewed and tested by the community.
Comment #12
star-szrThe markup is changing here but shouldn't - we are missing the no-screenshot__text div.
Comment #13
IshaDakota CreditAttribution: IshaDakota commentedComment #14
IshaDakota CreditAttribution: IshaDakota commentedFixed markup change noted in #13.
Comment #16
IshaDakota CreditAttribution: IshaDakota commented#14: twig-replace_themes_page-2010086-14.patch queued for re-testing.
Comment #17
heddnSeem to be missing a call to theme('system_themes_page') in system.admin.inc @ line 221.
Comment #18
hussainweb@heddn, I think this issue only covers the theme() calls in theme_system_themes_page(). It seems all other calls are being sorted out in #2009674: Replace theme() with drupal_render() in system module.
Comment #19
hussainwebBTW, the patch looks good and applies cleanly.
Comment #20
heddn@hussainweb, good clarification. I agree this looks RTBC.
Comment #21
YesCT CreditAttribution: YesCT commentedThis issue was RTBC and passing tests on July 1, the beginning of API freeze.
Comment #22
alexpottCommitted 1a0f40d and pushed to 8.x. Thanks!
Comment #23.0
(not verified) CreditAttribution: commentedUpdated issue summary.