I installed latest CKEditor in my libraries folder (4.8.0.230f715) and updated WYSIWYG to latest version: 7.x-2.x(233670fb). This version is however "not verified". Found the issue https://www.drupal.org/project/wysiwyg/issues/2916245 and it seems like the same.

A patch will be attached shortly to allow version 4.8.0 to also be verified.

Comments

lily.yan created an issue. See original summary.

lily.yan’s picture

kpaxman’s picture

Status: Active » Needs review
jkdev’s picture

@lily.yan ,Hello,

We all want to use the bleeding edge versions,
but this is big change from 4.6.2 to 4.8.0

We need to do this carefully, and if the change will break modules that currently leveraging the WYSIWYG api, this could not proceed (IMHO).
The way to do this is to open issues, on all failed to adapt modules, and see if we can contribute patches to support 4.8.0 in parallel to 4.6.2.
After those patches will be released (or at least RTBC), we can proceed to release our new version to WYSIWYG.

There is two ways to hook to WYSIWYG (please refer to the api).

The first is to use the hook_wysiwyg_plugin which is "Only to be used for native (internal) editor plugins". (but many module builders use it anyway)

The other is hook_wysiwyg_include_directory which is the proper way. (media module for example)

Please test at least some major modules that leverage the WYSIWYG - CKEditor implementation, with 4.8.0

I've tried to find some modules that uses WYSIWYG - CKEditor, by searching wysiwyg

Some of the projects I have found:

(to rapid this process, maybe this can be done by some script: download the project, use grep to find occurrences of one of the two hooks mentioned above.)

kpaxman’s picture

@jkdev would you say the same for https://www.drupal.org/project/wysiwyg/issues/2916245 ?

  • TwoD committed 61e1521 on 6.x-2.x
    - #2916245, #2951295 by leanderl, lily.yan, jkdev, kpaxman, aitala:...
  • TwoD committed 86c1683 on 7.x-2.x
    - #2916245, #2951295 by leanderl, lily.yan, jkdev, kpaxman, aitala:...
twod’s picture

Status: Needs review » Fixed
Related issues: +#2916245: Support for CKEditor 4.7.3.dee99e2

Thank you for reporting, patching and testing this!
There will be a new release marking 4.9.2 as verified due to the recent security issue in some earlier versions.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

liam morland’s picture