Wrong Run in thread options for an individual cron job [#3277629]

Problem/Motivation

After increasing the Maximum number of launcher threads at admin/config/system/cron/settings/launcher the Run in thread options for an individual cron job remain as -- Any --, -- Fixed -- & 1

Steps to reproduce

Increase Maximum number of launcher threads at admin/config/system/cron/settings/launcher
Check Run in thread options for an individual cron job

Proposed resolution

$max_threads = isset($this->configuration['launcher']['max_threads']) ? $this->configuration['launcher']['max_threads'] : 1;

Should be altered to use the main module configuration not the individual cron job configuration

Comment	File	Size	Author
#7	ultimate_cron-3277629-7.patch	4.21 KB	keszthelyi
#7	8.x-2.x: PHP 7.3 & MySQL 5.7, D9.5 31 pass, 1 fail

Issue fork ultimate_cron-3277629

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

8.x-2.x changes, plain diff MR !13
Check out this branch
3277629-wrong-run-in compare
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

28 April 2022 at 08:53

intrafusion created an issue. See original summary.

Comment #2

4 May 2022 at 08:02

intrafusion opened merge request !13

Comment #3

intrafusion

English

Edinburgh, UK

CreditAttribution: intrafusion commented 4 May 2022 at 08:03

I have made a simple issue fork which pulls max_threads out of the global config via \Drupal::config('ultimate_cron.settings')->get('launcher.max_threads');

This is a preliminary fix to make sure the correct config is being pulled through, but the final fix will probably need dependency injection

Comment #4

8 June 2022 at 09:39

golddragon007 made their first commit to this issue’s fork.

Comment #5

golddragon007 CreditAttribution: golddragon007 at European Commission and European Union Institutions, Agencies and Bodies, Petend commented 8 June 2022 at 09:46

I pushed here a small thread fix also, to be able to use multiple threads. Conditions:
You have to set for every cron job one by one which thread it must run.
You must use wget on the cron URL with ?thread=X where X is a positive round number, like 1,2,3,4...