Drupal by default sends Password Reset URL by email to user's email id in password recovery mail, but Reset Password Email OTP module sends random generated OTP by email instead of URL to the user.

Reset Password Email OTP Module provide a block to enter username or email of user and send OTP on his email for verification.
Once OTP verification completed this module allow user to enter new password.

Project link

https://www.drupal.org/project/reset_password_email_otp

Comments

Rajan Kumar created an issue. See original summary.

Nishant’s picture

Nishant CreditAttribution: Nishant at Melity commented

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications, What to cover in an application review, and Drupal.org security advisory coverage application workflow.

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

vishal.kadam’s picture

vishal.kadam
Location Mumbai
CreditAttribution: vishal.kadam as a volunteer commented
Title: [8.x-1.x] Reset Password Email OTP » [1.0.x] Reset Password Email OTP
Issue summary: View changes
Status: Active » Needs review
shashank5563’s picture

shashank5563 CreditAttribution: shashank5563 commented

Hey Rajan,

I see that there is a D8 module available, so it might be better to merge your project into the existing D8 one:
https://www.drupal.org/project/reset_password_email_otp

I've found following modules that might be similar, maybe it's good to describe why yours differs from these similar ones:

https://git.drupalcode.org/project/forgot_password
https://www.drupal.org/project/reset_pass_email_otp_auth

Also, Fix the phpcs issue.

vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,php  web/modules/reset_password_email_otp/

FILE: /web/modules/reset_password_email_otp/README.md
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-----------------------------------------------------------------------------------
 13 | WARNING | Line exceeds 80 characters; contains 97 characters
 14 | WARNING | Line exceeds 80 characters; contains 128 characters
 21 | WARNING | Line exceeds 80 characters; contains 104 characters
 37 | WARNING | Line exceeds 80 characters; contains 139 characters
-----------------------------------------------------------------------------------


FILE: /web/modules/reset_password_email_otp/src/Form/EmailOTPCheck.php
----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------


FILE: /web/modules/reset_password_email_otp/src/Form/ResetPasswordMailOTPConfig.php
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------


FILE: /web/modules/reset_password_email_otp/src/Plugin/Block/EmailOTPFormBlock.php
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------


FILE: /web/modules/reset_password_email_otp/src/EmailPassOTPContents.php
------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------


FILE: /web/modules/reset_password_email_otp/reset_password_email_otp.install
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------


FILE: /web/modules/reset_password_email_otp/reset_password_email_otp.module
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
shashank5563’s picture

shashank5563 CreditAttribution: shashank5563 commented
Status: Needs review » Needs work
vishal.kadam’s picture

vishal.kadam
Location Mumbai
CreditAttribution: vishal.kadam as a volunteer commented

FILE: src/Form/EmailOTPCheck.php

  /**
   * {@inheritdoc}
   */
  public function fapisetPasswordPageThree(array &$form, FormStateInterface $form_state) {

{@inheritdoc} is used if you are overriding or implementing a method from a base class or interface.

Rajan Kumar’s picture

Rajan Kumar CreditAttribution: Rajan Kumar at Melity commented

@vishal.kadam updated function comment as your suggestion. thanks for review my project.

Rajan Kumar’s picture

Rajan Kumar CreditAttribution: Rajan Kumar at Melity commented
Status: Needs work » Needs review

@shashank5563 thanks for reviewing my project.

I have fixed README file WARNING | Line exceeds 80 characters issue while other phpcs issue are not identify by coder. May be we are using different version.

Updated code committed in latest version.

Similar name project

How they are different?

Reset Password Email OTP Auth module helps in achieving Two-factor authentication (2FA) by sending and validation OTP via email. This will enhance the authentication process of reset password workflow by adding email OTP verification. While Reset Password Email OTP module does not override password reset process, its provide a new block which will take username or email from user and then send otp to his email, once OTP will verified then it provide a separate password reset form.

shashank5563’s picture

shashank5563 CreditAttribution: shashank5563 at Melity commented

Its looks fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

cmlara’s picture

cmlara
he/him
CreditAttribution: cmlara commented
Status: Needs review » Closed (duplicate)

The applicant already appears to have the permission to opt projects into security coverage.

Individual projects are not reviewed, only one application from an applicant needs to be completed, afterwards the applicant
receives the security opt-in permission and can opt projects in on their own.

This appears to be a duplicate of #3356457: [1.0.x] MD WordsCloud