Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mexicoder’s picture

Status: Active » Needs review
FileSize
2.7 KB

Patch to select only certain fields in the dbtng_example db_select.

Status: Needs review » Needs work

The last submitted patch, 1: dbtng-select-fields-2073851.patch, failed testing.

minakshiPh’s picture

Issue summary: View changes
Status: Needs work » Needs review
FileSize
2.9 KB

Re-rolled the patch.

Thanks!!!

Status: Needs review » Needs work

The last submitted patch, 4: dbtng_select_fields-2073851-4.patch, failed testing.

minakshiPh’s picture

Status: Needs work » Needs review

Test has passed.

Kindly review.
Thanks!

Manav’s picture

Assigned: Unassigned » Manav
Manav’s picture

Assigned: Manav » Unassigned
Status: Needs review » Needs work

Patch failed locally for latest 7.x-1.x branch, even tested on simpletest.me shows the same result.

navneet0693’s picture

Assigned: Unassigned » navneet0693
navneet0693’s picture

Suggestion is appreciable. Re-rolled the patch in #1

navneet0693’s picture

Assigned: navneet0693 » Unassigned
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: dbtng_select_fields-2073851-10.patch, failed testing.

navneet0693’s picture

Status: Needs work » Needs review
Mile23’s picture

Retesting #10.

Status: Needs review » Needs work

The last submitted patch, 10: dbtng_select_fields-2073851-10.patch, failed testing.

navneet0693’s picture

Status: Needs work » Needs review

Retesting, making sure that testing has correct parameters.

Status: Needs review » Needs work

The last submitted patch, 10: dbtng_select_fields-2073851-10.patch, failed testing.

navneet0693’s picture

Status: Needs work » Needs review
FileSize
3.58 KB
783 bytes

Status: Needs review » Needs work

The last submitted patch, 18: dbtng_select_fields-2073851-18.patch, failed testing.

Berdir’s picture

+++ b/token_example/token_example.info
@@ -2,10 +2,7 @@ name = Token example
 core = 7.x
-; Since someone might install our module through Composer, we want to be sure
-; that the Drupal Composer facade knows we're specifying a core module rather
-; than a project. We do this by namespacing the dependency name with drupal:.
-dependencies[] = drupal:token
+dependencies[] = token

this makes no sense.

token in core is *not* a module, it's just an API. If you do not depend on the token module project/contrib, then you must not have a dependency at all.

navneet0693’s picture

Status: Needs work » Needs review
FileSize
3.56 KB
514 bytes
Mixologic’s picture

You had your namespacing incorrect. If you depend on a module, then the namespacing should be in the format of

dependencies[] = <projectname>:<modulename>

Where projectname is the name of the project as hosted by drupal.org, and modulename is the name of the module within the project, which is sometimes, but not always the same. In this case your dependencies should be:

dependencies[] = token:token
dependencies[] = drupal:system (>= 7.40)
Mixologic’s picture

(oh, just re-read what berdir said, yes, if you do not need the token *module* then you dont need it as a dependency)

navneet0693’s picture

Status: Needs review » Needs work

The last submitted patch, 24: dbtng_select_fields-2073851-24.patch, failed testing.

navneet0693’s picture

Status: Needs work » Needs review
Mile23’s picture

Status: Needs review » Needs work
+++ b/token_example/token_example.info
@@ -2,10 +2,7 @@ name = Token example
 core = 7.x
-; Since someone might install our module through Composer, we want to be sure
-; that the Drupal Composer facade knows we're specifying a core module rather
-; than a project. We do this by namespacing the dependency name with drupal:.
-dependencies[] = drupal:token
+dependencies[] = token

We want to add back this comment as well.

navneet0693’s picture

Added a child issue: #2841202: Remove dependency declaration on token in token_example.info. to update token_example.info separately. As we learned on IRC via Mixologic that

We cannot make changes to dependencies in an info file in a patch and and have the testbot know what you wanted. Because they are not resolved at test time, they are resolved at commit time. so if we added drupal:token in another patch, we cant fix it in this one. We need to remove it, and commit that first. Then this patch can be viewed independently

Mile23’s picture

OK. Fixed the dependencies issue for CI in #2841202: Remove dependency declaration on token in token_example.info. so we can run tests.

+++ b/token_example/token_example.info
@@ -2,10 +2,7 @@ name = Token example
-; Since someone might install our module through Composer, we want to be sure
-; that the Drupal Composer facade knows we're specifying a core module rather
-; than a project. We do this by namespacing the dependency name with drupal:.
-dependencies[] = drupal:token
+dependencies[] = token:token

Now we don't want to change this dependency at all.

navneet0693’s picture

Re-testing #10

navneet0693’s picture

Mile23’s picture

+++ b/dbtng_example/dbtng_example.module
@@ -257,6 +257,34 @@ function dbtng_example_entry_load($entry = array()) {
+/**
+/**

#10 has this.

navneet0693’s picture

Status: Needs work » Needs review
navneet0693’s picture

Status: Needs review » Needs work

+++ b/dbtng_example/dbtng_example.module
@@ -257,6 +257,34 @@ function dbtng_example_entry_load($entry = array()) {
+/**
+/**
#10 has this.

@Mile23 ouch! missed that. Removing it.

navneet0693’s picture

Status: Needs work » Needs review
FileSize
413 bytes
2.82 KB
Manav’s picture

Assigned: Unassigned » Manav
Manav’s picture

Hi @navneet0693

Patch is works fine for me. The only issue is coding standard. Please check and submit this patch again. Attaching 2 screen-shot for the same.

  1. Screen-shot for showing old result set before applied the patch and
  2. Screen-shot for new result set after applied this patch.

PHP version: 5.6
Mysql: 5.5
Drupal: 7.x

Manav’s picture

Assigned: Manav » Unassigned
Status: Needs review » Needs work
navneet0693’s picture

Status: Needs work » Needs review
FileSize
1.55 KB
2.87 KB

Thanks @Manav, for pointing out what i missed :)

Manav’s picture

Assigned: Unassigned » Manav
Status: Needs review » Reviewed & tested by the community

The last submitted patch #39 is works fine for me. showing the expected result according to the issue description.

Drupal: 7.x
PHP ver: 5.6
Mysql: 5.5

@navneet0693 for your quick fixes. :)

Manav’s picture

Assigned: Manav » Unassigned
valthebald’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x-1.x. Thanks everyone!

  • 903f31a committed on 7.x-1.x
    Issue #2073851 by navneet0693, mexicoder, minakshiPh, Manav: Select only...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.