Terminology wrong around "Request new password"

"Request login by email" is literally correct. Is it acceptable?

#3: request_login_text-734536-3.patch queued for re-testing.

#3: request_login_text-734536-3.patch queued for re-testing.

Could this be "Request login link via e-mail"? or is that too long? It's more explicit.

The title should be longer and more explicit than the link text, I think.
Incidentally, there is some inconsistency in "email" versus "e-mail".

~/www/8.x$ egrep -r " t\('[^']*\be-mail\b" includes modules themes | wc -l
69
~/www/8.x$ egrep -r " t\('[^']*\bemail\b" includes modules themes | wc -l
14

Re-rolled with longer/more explicit text in both link and title.

Marked #255518: Usability: Request new password button incorrectly named as duplicate.

In #255518: Usability: Request new password button incorrectly named there was good discussion about the pretty standard language "Forgot your password?". What if we set the non-logged in links and the /user tab to "Forgot your password?" but set the button to "Request login link by e-mail" and the link titles to "Send a one-time login link to the account e-mail address"?

Here is a patch with these suggestions included.

Looks good. Though, I do always wonder about the efficacy of putting anything important in the title attribute. screen-reader / keyboard only users will have 0 access, and most other people only get access on hover, after they have already made a decision.

Hmm the patch failed because line #1054 of system.test expects the password reset link to be $this->drupalPost('user/password', $edit, t('E-mail new password'));. Should I re-roll the patch with an updated line #1054 for system.test as well?

Should I re-roll the patch with an updated line #1054 for system.test as well?

Yes.

This seems like quite a bad direction, can we please research and adapt industry standards on this?

Here is #9 with the system.test update.

@Bojhan, what are you referring to when you say "This seems like quite a bad direction"?

It changes the wording to something you will never see on any other website, but Drupal websites.

@Bojhan, could you be more specific as to which wording is something you will never see on any site but a Drupal site?

"Forgot your password?" is pretty standard wording, which is why I'm recommending it for the link text and tab title. I'm recommending the less common, but more accurate wording requested in earlier posts for the link titles.

@rocket_nova Hmm, am I reading the patch wrong? Can you provide screens for review?

@Bojhan, Here are some screens to review. I tried to get the hover states as well.

Re-rolled after #22336: Move all core Drupal files under a /core folder to improve usability and upgrades core directory structure for Drupal 8 was changed.

Re-rolled patch from #22 to accommodate #1326172: Improve wording of the "Current password" field description on the user edit form.

Oops. Missed a test.

"Request login link by e-mail" for the action link label seems too long and confusing. How about "Send instructions" ?

@rafamd: as pillarsdotnet and rfay said in #18, we're trying to make this more explicit. I think "Send instructions" is too vague.

re 30: ok, sounds reasonable.

Looking at the screenshots (thanks for suggesting them @Bojhan, they ease evaluation), I've one more comment. In the user edit screen "Current password" field description, the wording is "Reset password" and in the other scenarios it's "Forgot your password?". Why using different terminology for basically the same thing?

One more thought ... how about "Send login link by e-mail" instead of "Request login link by e-mail".

Sounds more friendlier, and straightforward. "Request" can imply there are additional steps involved, such as an administrator intervention, etc. while "Send" sounds more automatic.

setting better tag

@rafamd That seems in line with the other language changes. Here is a patch to that effect.

Nice.

What about #31 ? Why don't we use "Forgot your password?" all times instead of having "Reset password" in some places ?

That will bring consistency, as we are speaking of the same functionality every time (even links point to the same place).

FYI, #75924: Include fields for resetting password on the one-time password reset page has also tackled changing the language of the password reset feature, so I think this issue may be a duplicate.

This still a concern in D8? Unassigned issue too.

It'd be an improvement IMHO.

The patch would need a re-roll including what I mentioned on #35 (the last two screenshots shown in #20 still use 'Reset password' instead of the standard 'Forgot password?' we are introducing).

D8 uses "Reset password" ans "Send password reset instructions via email" consistently on the user login form and the user account form. I've attached some screenshots. I think this means we can mark this issue as fixed.

Sorry, rather than marked as fixed, this should probably be re-rolled for 7.x, using the terminology from 8.x.

We have to be careful about introducing new translatable strings on this form in a stable release though (since it's such a commonly-used end-user-facing form).

However maybe we could consider changing the button text from "E-mail new password" to "Request new password" (since that reuses an existing translated string) - I think that would be an improvement (though contrary to the title of this issue)? It could break some people's automated tests but may be worth it since the current button text is basically just plain wrong.

Linking to the issue that changed this in Drupal 8.

However maybe we could consider changing the button text from "E-mail new password" to "Request new password"

As pointed out there though, losing the word "e-mail" from this form may not be great as the user doesn't know what to expect. (Although after they submit the form the confirmation message does tell them they were sent an email.)

Perhaps we should close this issue and open the other for a backport discussion instead (since that is where the most recent relevant discussion from Drupal 8 is).

We can also name it to "Password Recovery" instead of "Request New Password"

patch re-rolled for Drupal 7.x

changes made as:
"E-mail new password" to "Request new password"
"Request new password" to "Reset your password"
"Request new password via email" to "Send password reset instructions via e-mail"

patch re-rolled for 7.x in accordance with this issue to maintain consistency in d7 and d8.

Applied the patch mentioned in #51 and tested the terminology change successfully in D7. Attached the screen print for reference.

Changing to the correct status

This is a better terminology. Good work.
The patch worked for me.

Patch still seems to apply, setting back to rtbc.

Phew, hard to decide.

Yes, this is great. But the strings are not translated.

Assigning to Gabor to get feedback if we can implement those strings hidden in core, wait for translations to catch up (or copy from D8) and then release this.

Let's put it back to "needs review" for that for now.

Those are interesting ideas, but I mentioned in IRC that (a) it might take a very long time for all translations to catch up (either Drupal 7 or 8), and (b) people sometimes override these kinds of strings locally via settings.php or the admin UI (even on an all-English site) which is an issue with breaking "translations" as well.

That's why https://www.drupal.org/node/1527558 has always been very strict about not changing end-user-facing strings (as opposed to admin-facing strings) unless it's a really serious issue.

However, as I also mentioned on IRC, I've been wondering if we could add some kind of opt-in "fallback" translation mechanism to Drupal, whereby if a translation is available for the original string but not the new string, it falls back on displaying the original translated string in preference to the new untranslated string. (As far as I know, WordPress has a system similar to that.) With that in place we could potentially start changing translatable strings much more aggressively, and get issues like this one fixed.

I need to look into it a little more (and probably file a separate issue) although I don't have time for that right at this moment.

@David_Rothstein The opt-in does sound like a good idea but the string must have been changed for some good reason so imho an option which would allow us to define new translations for some specific languages would be even better.

I like the idea of #59...

I just had a client who was very confused by the /user/password page as he could not understand why the email he received did not contain his new password, even though the tab says 'Request new password' and the button link says "E-mail new password." Is applying the current patch the recommended way to make this process more user friendly?

I ended up using the String Overrides module to:
Change 'Request new password' to 'Reset your password' (patterned after D8)
Change 'E-mail new password' to 'Submit' (patterned after D8), but I think 'E-mail reset instructions' or 'E-mail instructions' could also work

Then, I displayed a block on /user/password with the following text (patterned after D8)
"After clicking Submit, a link to reset your password will be sent to your registered email address."

Finally, I enabled the simple_pass_reset module to eliminate the one-time login form.

I'm sure there a many ways to accomplish this, but the above solution immediately cleared up the confusion for my client.

"Request for account reset/recovery" might sound more prominent.

I believe this is outdated.