Problem/Motivation
When the user puts in the wrong the password the reloaded page shows "Have you forgotten your password?" which can be instead written as "Forgotten your password?"
as seen across many the web on many other sites.

Proposed Resolution
Change the text to "Forgotten your password?"

Before
before.png
After
after.png

CommentFileSizeAuthor
#21 ForgotPassword.png28.24 KBjoyceg
#19 2691025-18.patch2.66 KBtherealssj
#12 After_patch.JPG70.27 KBTruptti
#12 Patch_applied.JPG67.89 KBTruptti
#12 Before_patch.JPG84.1 KBTruptti
#7 Forgotten-password-message-changed-2691025-5-8.patch2.67 KBajalan065
#5 2691025-3.patch2.67 KBtherealssj
#2 2691025-2.patch2.12 KBtherealssj
after.png83.3 KBtherealssj
before.png85.02 KBtherealssj
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

therealssj created an issue. See original summary.

therealssj’s picture

therealssj CreditAttribution: therealssj commented
FileSize
2691025-2.patch2.12 KB

Here is a patch for it.

therealssj’s picture

therealssj CreditAttribution: therealssj commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2691025-2.patch, failed testing.

therealssj’s picture

therealssj CreditAttribution: therealssj commented
FileSize
2691025-3.patch2.67 KB

Missed the change at one place.

therealssj’s picture

therealssj CreditAttribution: therealssj commented
Status: Needs work » Needs review
ajalan065’s picture

ajalan065 CreditAttribution: ajalan065 as a volunteer and at Google Summer of Code commented
FileSize
Forgotten-password-message-changed-2691025-5-8.patch2.67 KB
ajalan065’s picture

ajalan065 CreditAttribution: ajalan065 as a volunteer and at Google Summer of Code commented

Sorry, I ended up working on this in parallel to @therealssj. Saw the previous test failed, so uploaded the patch

nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
CreditAttribution: nicrodgers at Welsh Government commented

I'm not sure I agree with the motivation of this patch. Yes, it can be shorter, but the shorter version doesn't sound nearly as friendly or helpful. What's the benefit of this change?

therealssj’s picture

therealssj CreditAttribution: therealssj commented

@nicrodgers The main motivation was the fact that out of all websites that i have ever registered on drupal was the only one which displayed "Have you forgotten your password". mostly it would be something like 'Forgot your password?', 'Forgot?', 'Lost your password?' or as above 'Forgotten your password?'
As for benefit, it shorter and coveys the same message?
I was more in favor of 'Forgot your password?' though.

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Related issues: +#734536: Terminology wrong around "Request new password"
Truptti’s picture

Truptti CreditAttribution: Truptti at Axelerant commented
FileSize
Before_patch.JPG84.1 KB
Patch_applied.JPG67.89 KB
After_patch.JPG70.27 KB

Verified the patch in #7 on drupal 8.2.x local site.On applying the patch forgot password message is displayed as
'Unrecognized username or password. Forgotten your password?'
Attached snapshot for reference.Marking as Reviewed and Tested by community.

Truptti’s picture

Truptti CreditAttribution: Truptti at Axelerant commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Issue tags: +Needs usability review

fwiw I think 'Forgotten your password?' is friendlier.

'Have you forgotten your password?' can sound a bit passive aggressive, like 'Have you forgotten who you're talking to?', especially if you know you mis-typed it and haven't forgotten it at all. Speaking from experience :(

Since this is something that probably millions of people see a year, tagging for usability review.

yoroy’s picture

yoroy CreditAttribution: yoroy at Roy Scholten commented
Issue tags: -Needs usability review +Usability

Nice little tweak, I like it. Agree with @catch the shorter version is friendlier and less assuming. I don't know about "forgot" vs. "forgotten".

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs review

I'd go for 'Forgot'. I don't think there's much in it, but saves characters. It also allows for having temporarily forgotten the password - like 'I forgot my keys', whereas forgotten implies a more permanent state.

yoroy’s picture

yoroy CreditAttribution: yoroy at Roy Scholten commented
Status: Needs review » Needs work

Ok lets do that. One more updated patch please :)

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented

While we're here, google informs me there was a discussion about this on stackexchange, and it slightly preferred 'Forgot password?'

http://english.stackexchange.com/questions/670/is-it-correct-to-use-forg...

therealssj’s picture

therealssj CreditAttribution: therealssj commented
FileSize
2691025-18.patch2.66 KB

Here :)

yoroy’s picture

yoroy CreditAttribution: yoroy at Roy Scholten commented
Status: Needs work » Needs review
joyceg’s picture

joyceg CreditAttribution: joyceg commented
FileSize
ForgotPassword.png28.24 KB

The patch applies well.
Good work.

yoroy’s picture

yoroy CreditAttribution: yoroy at Roy Scholten commented
Status: Needs review » Reviewed & tested by the community

I saw the same as in #21 using simplytest.me. Good to go!

  • catch committed 0905f0f on 8.2.x 
    Issue #2691025 by therealssj, ajalan065, Truptti, joyceg, yoroy, catch:...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 0905f0f and pushed to 8.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.