As part of the Bug Smash Initiative, we are triaging issues that are marked "Postponed (maintainer needs more info)", or tagged with "Needs steps to reproduce" and "Needs screenshots".
We had a discussion in Slack #bug-smash about guidelines for when it is OK to close an old issue and wanted to record that as well as opening it up for wider feedback.
Consensus on Slack was that if an issue meets these three criteria, it should be closed:
- Report consists only of an error or description of an error with no steps to reproduce
- Someone replied asking for steps to reproduce >6 months ago
- No steps were provided and/or it is only reproducible in the reporter's site
This proposal only applies to a relatively narrow set of issues, and many of these are already closed as part of the initiative triage. So I think there is a more broad discussion to be had about stale issues and not just ones that meet these somewhat obvious criteria.
The idea of automating this came up as well, which is something that has been discussed before in #156704: Dealing with "postponed (maintainer needs more info)" issues and #1230642: Automatically mark "postponed (maintainer needs more info)" issues to "closed (cannot reproduce)".
Comments
Comment #2
pameeela commentedComment #3
pameeela commentedI think I am -1 on automating this, because:
But it is certainly possible that (as @catch said in #1230642: Automatically mark "postponed (maintainer needs more info)" issues to "closed (cannot reproduce)":
I guess it is a question of what is worse:
Comment #4
cilefen commented+1 to this. Also, I suggest going beyond bugs and also considering the issue type. For example (I just made these up):
Comment #5
catchI think the suggestion in the issue summary is good, although I do think 6 months is more than enough time for someone to get back with steps to reproduce.
With support requests we run the risk of closing them before anyone replied, but this is already the case. Eventually with much less in the queues, there's more chance of any one active issue being replied to and resolved, or people finding what they're looking for instead of creating duplicates.
IMO both of these could be automated, a big question is whether that could be enabled for contrib modules too (maybe opt-in?).
Feature requests are a lot trickier because there is a lot of overlap between tasks and feature requests, and some things are valid but get forgotten. For example I just opened #3156396: Use assertSameSize() to check same size of two countable variables, it is arguably a task, someone might work on it next week or in five years.
Comment #6
larowlan+1 from me too, and I think if we made it automated you would need to be able to configure it per project, so that's out of scope here.
I think here we just need to agree on the idea and the number of months and move it to Rtbc then fixed
Comment #7
pameeela commentedComment #8
cilefen commented@catch I would argue that's a task. In my day job, I consider a feature to be something an end-user may notice. But on the other hand, if a testing framework adds API, that's a feature.
Comment #9
quietone commented+1.
@larowlan, is that the number of months since the last comment?
Comment #10
johnwebdev commented+1 on automation.
The number of issues looks scary at first sight, but then you realize many of them are either outdated, duplicates etc. For instance there are > 1000 feature/tasks for 7.x that can be closed.
Support requests could be automatically closed after n time, if the last reply is not from the one who created it.
I also think the flow described in issue looks great 👍
Comment #11
andrewmacpherson commentedPlease DON'T close accessibility issues on any of the grounds mentioned in the comments so far, because...
A problem with closing issues by policy (especially automatically) is that they may have been wrongly classified in the first place. It's fairly common to find issues with the wrong category, component, or project. These issues likely won't have been seen by others who could provide more information. Closing them makes it even less likely they will ever be seen.
I'm against closing issues merely because they are old...
If issues were marked "postponed", that explicitly means that it's worth returning to later. These shouldn't be closed just because time has passed. Rather, they need to be re-assessed for relevance, preferably by someone who understands the topic/subsystem/module. It's great when a reason has been given for postponement, but this isn't always the case.
If they were marked "needs steps to reproduce" and no steps have been provided yet, that doesn't mean the issue is no longer relevant, or that the bug has gone away. It just means that it still needs more information to describe the problem. There are a lots of reasons why the original reporter may not have been able to provide steps to reproduce:
#3:
The "your issues" link on d.o user profiles leads to a list of open issues only. Closing an issue won't attract attention to it. On the contrary, it will just disappear from the default "your issues" list.
Re. #4:
There are features which we must introduce because we can't achieve WCAG or ATAG conformance without them. It's often a struggle to get community interest in these, let alone find contributors to help make them happen (and we certainly can't rely on companies for that). Please don't make me have to add a certain number of comments to get it over the N threshold, or hustle for relevancy.
Comment #12
pameeela commentedUpdated the IS to reduce >1 year to >6 months.
I think that we have reached a consensus that automating this is problematic as we are not going to be able to find a set of rules that avoids closing valid issues.
Marking this needs review, if people are happy with this policy then the issue can go to RTBC then fixed.
I think that we should open separate policy issues for support and feature requests that were mentioned here, as this issue is pretty specific to a common type of bug report.
Comment #13
pameeela commentedComment #14
mmjvb commentedSuggest to make it clear in the title that this issue is about bug reports.
Comment #15
pameeela commentedGood point @mmjvb. Updated.
Comment #16
simeI support this policy. I have been looking through the "Needs more info" there is a lot of noise from old "Postponed maintainer needs more info" issues.
Can the point in #11 be handled? Perhaps via a list of tags that should not be closed?
Comment #18
quietone commentedAdding other related issues concerning management of the issue queue.
Comment #23
smustgrave commented+1 for this.
Comment #24
pameeela commentedI think that this issue should be marked RTBC and then fixed. I totally understand the concerns raised in #11 but I think several years of this initiative have shown that we are taking a cautious approach to this and treating every issue with care.
For my part, having triaged probably >1000 issues, I have never come across an accessibility bug that matched the description here. There are a large number of bugs against accessibility, but they tend to be well documented, and even if they are old or stale, we would never close one that was established to be valid.
On a broader level, I think the approach taken by the initiative has been exemplary. Of course, mistakes are made -- I reopened an issue a few weeks ago that was closed in error because it wasn't understood. But even that shows the system working, as I wouldn't have ever seen the issue except that I saw it was updated!
Of course, I created this issue so I won't mark it RTBC but curious whether anyone else has input now that we have a few years of progress to point to.
Comment #25
quietone commentedReading #11 and #16 I decided to look at the evidence. There are 25 issues tagged bugsmash and accessibility that have been closed for reasons other than fixed.
won't fix: 2
works as designed: 7
cannot reproduce: 6 (includes several IE 11 issues)
outdated: 10 (includes several IE 11 issues)
I opened all the issues and read how they were closed. I didn't find that any of them were closed improperly. I do agree with @pameeela in #14 that the Bugsmash triagers are "taking a cautious approach to this and treating every issue with care.".
I have added the proposed text to the initiative docs, https://www.drupal.org/community-initiatives/bug-smash-initiative/issue-...
Comment #26
borisson_The concerns in #11 are very valid, but as remarked in #24 and #25 we've been very careful about this in the past and will continue to do so.
I think writing down, and consistently following this policy, while still being careful is a good improvement in the maintenance of the issue queues.
Comment #27
lauriii+1 for the proposed policy, as a more manageable issue queue benefits everyone by increasing our efficiency. I believe that it's essential for us to emphasize that closing stale issues doesn't mean disregarding bugs or problems. Issues are being closed because they are lacking next steps due to insufficient information.
We should always respect reported problems and strive to understand them. However, if we cannot proceed on an issue due to inadequate information, it holds little value in the queue. While #11 brings up valid concerns, I don't believe that maintaining a queue filled with unactionable issues addresses those issues.
Comment #28
g-brodieiSaw this issue from bug smash initiative channel from @quietone to check wordings on policy page.
+1 on the policy change. I’ve read through the threads and notice a slight wording diff on the policy page.
On policy page:
If the stale issue meets these criteria, it should be closed:
On the issue summary:
if an issue meets these three criteria, it should be closed:
I believe the word `three` would make it clearer for future readers (not native English speaker) to understand the criteria, thanks!
Comment #29
quietone commentedThanks!
I have updated the page.
Comment #30
g-brodieiChecked the page, wording changed as suggestion, thanks!
Set to RTBC
Comment #31
g-brodiei