Fix multilingual site's layout edit context issue with TypeError: Argument 1 passed to UrlHelper::buildQuery() must be of the type array, null given

From https://www.drupal.org/project/layout_builder_modal/issues/3101572#comme...

Had the issue only when I updated Drupal core to 8.8.0
for the rout_parameters value

1. Tested to send an empty string '' it worked but the automated test failed
2. Tested to send NULL it worked but the automated test failed
3. Tested to send an empty array UrlHelper::buildQuery([]) it worked but the automated test failed

In my opinion it could be handled from Drupal core.
It could be that the automated tests should be changed

Remaining todo :

• Fix the automated tests

Please try this patch - it will show which group fails and then we could find why params is not initialized

The error in related issue shows that some contextual link wrongly build

+++ b/core/modules/contextual/contextual.module
@@ -177,7 +177,7 @@ function _contextual_links_to_id($contextual_links) {
-    $route_parameters = UrlHelper::buildQuery($args['route_parameters']);
+    $route_parameters = ((isset($args['rout_parameters']) && is_array($args['rout_parameters'])) ? UrlHelper::buildQuery($args['route_parameters']) : UrlHelper::buildQuery([]));

there's typo `s/rout/route`

Patch from #19 tested and working @RajabNatshah :)

I'm glad the issue is moving forward

@davidferlay If the patch is working for you, what is the exact warning message that is logged? That will help us fix the problem at the source.

Hi @longwave,

The initial error I was encountering is described in detail here : https://www.drupal.org/project/layout_builder_modal/issues/3101572

Hope it helps

Thanks for filing this bug report and for fixing it. Bug fixing is very valuable. However in order to commit a bug fix we need an automated to test to prove that we've fixed the bug and ensure that we don't break it again in the future. For more information about writing tests in Drupal 8 see the following links:

1. https://www.drupal.org/docs/8/testing
2. https://api.drupal.org/api/drupal/core%21core.api.php/group/testing/8.7.x

Also some steps to reproduce the problem would be great so we can see why the problem is happening and perhaps address the root cause rather than the symptoms.

#19 worked great and fixed my WSOD when attempting to edit the layout via Layout Builder on any content type or node. This was able to be successfully applied against 9.06.

Edit: Also works on 9.07

I am now on Drupal 8.9.7 as the patch is to core I was unwilling to apply however disabling my layout modal at least allows to load the layout page.

Thanks @davidferlay for the hint #17 proceeding without layout modal module.

Per #23 : "Also some steps to reproduce the problem would be great so we can see why the problem is happening and perhaps address the root cause rather than the symptoms."

We will really need some steps to reproduce this or a failing automated test that demonstrates the problem otherwise we have no idea if we are fixing a problem or just hiding a problem.

The previous patch deleted to many contextual links.
I wasn't able to translate the inline blocks anymore with the core sync patch.
My version works but probably isn't perfect.

Re-roll patch #19 to be working with patch #143 from issue Admin toolbar and contextual links should always be rendered in the admin language (if set)

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Patch for D10. Tested on D10.1.2

I have the patch for "Allow synced Layout override Translations: translating labels and inline blocks" 2946333-d10-307.patch installed and there was no configure block icon when hovering over the block when using my 3101231-D10.patch.

I have fixed the missing $args['route_parameters'] (they are availabe in $contextual_links['layout_builder_block_translation'] or $contextual_links['layout_builder_inline_block_translation']) and everything now works.

Not sure that this is the best place for this fix so have also posted in the "Allow synced Layout override Translations: translating labels and inline blocks" issue queue. But it is here if anyone else has this problem.

Credits to Gauravvvv, but added the patch to the wrong issue:

I have fixed the cc failure, added use statement for ClientException and updated elseif condition, Attached patch and interdiff for same

Just as comment #36, I use a patch from Admin toolbar and contextual links should always be rendered in the admin language (if set) and just encountered this issue. I've rerolled the patch from comment #44 to apply on the (latest) MR #4604.

patch #44 works on D10.4.6 however patch #45 fails to apply.
patch #44 works on D11.1.6 however patch #45 fails to apply.

Recommend continuing with patch #44 and ignoring patch #45

Patch #44 resolves the bug, prevents WSOD when using layout_builder on a node page in the other language.

#44 & #45 wouldn't apply on 11.1.8

Thanks for reviving this issue. Unfortunately still need to add clear steps to reproduce to the summary. Also will need test coverage.

I have added patch #47, which was working fine.

I'm in a bit of a hurry, but I updated the MR which mirrors the patch #47 to remove the unknown Client Exception, and adjust the route params fallback to an empty array. Tested with 11.3+ and layout_builder_st + layout_builder_modal. Enabling layout_builder_modal has caused the issue for me.