CommentFileSizeAuthor
#24 2962649-24.patch3.94 KBnikhil_110
#23 2962649-nr-bot.txt144 bytesneeds-review-queue-bot
#10 interdiff2962649-7-10.txt5.34 KBaleevas
#10 2962649-10.patch3.94 KBaleevas
#7 drupal-add_target_blank_on_file_fields-2962649-7.patch4.04 KBbarig
#5 drupal-add_target_blank_on_file_fields-2962649-5.patch3.11 KBbarig

Comments

edurenye created an issue. See original summary.

cilefen’s picture

cilefen commented
Version: 8.0.x-dev » 8.6.x-dev

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

barig’s picture

barig commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Active » Needs review
StatusFileSize
new drupal-add_target_blank_on_file_fields-2962649-5.patch3.11 KB

Hi !

I created a patch for file core module to allow choosing "New tab" on file field formatter settings.

I don't think it can be merged as is since it only works for "Generic file" formatter but it's what I needed (and hope what other people could need).

Regards,
Barig

Status: Needs review » Needs work

The last submitted patch, 5: drupal-add_target_blank_on_file_fields-2962649-5.patch, failed testing. View results

barig’s picture

barig commented
StatusFileSize
new drupal-add_target_blank_on_file_fields-2962649-7.patch4.04 KB

I rerolled the patch with the schema file updated so automatic tests won't fail ;-)

barig’s picture

barig commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: drupal-add_target_blank_on_file_fields-2962649-7.patch, failed testing. View results

aleevas’s picture

aleevas
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new 2962649-10.patch3.94 KB
new interdiff2962649-7-10.txt5.34 KB

Here is my patch.
Fixed failed test.
Also I've renamed this new field from new_tab to open_in_new_tab.
Such fullname looks more clear for me.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.9 was released on November 6 and is the final full bugfix release for the Drupal 8.7.x series. Drupal 8.7.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.8.0 on December 4, 2019. (Drupal 8.8.0-beta1 is available for testing.)

Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

pakmanlh’s picture

pakmanlh
he/him
Primary language Catalan
Location Barcelona
commented

Tested #10 in 8.7 and worked like a charm.
Many thanks for this excellent feature! 💚

Anonymous’s picture

Anonymous (not verified) commented

Tested #10 in 8.8 and it worked perfectly fine. Thanks.

idebr’s picture

idebr commented

There is an ongoing discussion whether links should open in a new window, see #2702881: [policy, no patch] Formalize how external links are handled in core

Potential downsides are reduced accessibility and security concerns.

BalajiDS’s picture

BalajiDS commented
Issue summary: View changes

Patch #10 in 8.8.6 and it worked perfectly fine thanks @aleevas

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

jlbellido’s picture

jlbellido
Primary language Spanish
commented

Just verified #10 on 9.1.5 and worked like a charm.

Thanks

vikashsoni’s picture

vikashsoni commented

Thanks for patch #10 it worked perfectly fine. Thanks....

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 2962649-nr-bot.txt144 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

nikhil_110’s picture

nikhil_110 commented
StatusFileSize
new 2962649-24.patch3.94 KB

Attached patch against Drupal 9.5.x

Patch #10 is not applied for Drupal 9.5.x so Inter-diff file is not added.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.