Allow views to provide the canonical entity URL of all entities, not just nodes.

I like this approach more

1. +++ b/core/modules/views/config/schema/views.field.schema.yml
   @@ -191,6 +191,12 @@ views.field.entity_link:
   +    output_raw:
   +      type: boolean
   +      label: 'Output the URL as text'
   

   What about using "output_url"?

2. +++ b/core/modules/views/tests/src/Kernel/Handler/FieldEntityLinkTest.php
   @@ -112,9 +130,14 @@ protected function doTestEntityLink(AccountInterface $account, $expected_results
   +          $path = strpos($template, 'canonical') !== 0 ? $entity->url($template, $info[$template]['options']) : $entity->url('canonical', $info[$template]['options']);
   

   I'm confused, this line looks just wrong. Its two times basically the same function call

Should we provide an update path here?

Yeah you are right, we don't need one as long we just add new options. On the other hand, its nice to reduce the amount of random additions to config. An update makes it pretty clear, what caused the config change.

1. +++ b/core/modules/views/views.post_update.php
   @@ -237,5 +237,30 @@ function views_post_update_boolean_filter_values() {
   +function views_post_update_entity_link_url() {
   

   When we are in post update we can actually use entity api, can't we? I guess it doesn't really make a difference though.

2. +++ b/core/modules/views/views.post_update.php
   @@ -237,5 +237,30 @@ function views_post_update_boolean_filter_values() {
   +          if (isset($field['plugin_id']) && $field['plugin_id'] === 'entity_link') {
   +            $view->set("display.$display_name.display_options.fields.$field_name.output_url", FALSE);
   +            $view->set("display.$display_name.display_options.fields.$field_name.absolute", FALSE);
   +            $save = TRUE;
   +          }
   

   Let's not override anything which is already there, you never know

Let's see whether someone complains :)

Well, I’m certainly not going to complain!

Adding the issue in the Group project that sparked this issue when Lendude realised the best solution was to have the capability here.

Won't the node_path plugin still appear in the UI as a semi-duplicate here?

If that's the case, should we look at removing it from the UI, converting it in the update to the generic one, and also convert (in config presave) for default config so it never gets used unless someone's explicitly extended it?

Tested as follows:

1. I can confirm raw_entity_link-2810097-18.patch applies cleanly to Drupal 8.3.x HEAD.
2. Adding the patch provides new options on an entity view's field "Link to [entity type]", tested as follows:
   1. As admin, navigate to edit the view "Who's new".
   2. In the modal dialogue, click "ADD" by the view display's fields, and click the checkbox by "Link to user" and submit.
   3. In the modal dialogue, there are two new checkboxes: "Output the URL as text" and "Use absolute link (begins with 'http://')".
   4. Clicking the first checkbox, and then optionally clicking the second, yields a plaintext URL with or without the protocol and path.
3. I'm not an expert, but I just want to flag the fact that the update function views_post_update_entity_link_url() is never explicitly called anywhere to update existing views on 8.2.x=>8.3.x. Is it called by some kind of autodiscovery magic?

Apart from the minor query #3 above, this looks great. Before/after screenshots attached for the testing done in #2.

@lendude then that all checks out fine. Looks good to me (see screenshots).

Moving to RTBC.

1. +++ b/core/modules/views/config/schema/views.field.schema.yml
   @@ -191,6 +191,12 @@ views.field.entity_link:
   +    output_url:
   +      type: boolean
   +      label: 'Output the URL as text'
   

   This is a strange label. I couldn't guess what it does from the name. Maybe output_url_as_text? I'm not sure what is best here.

2. +++ b/core/modules/views/src/Plugin/views/field/EntityLink.php
   @@ -45,4 +59,34 @@ protected function getDefaultLabel() {
   +    // Only show the 'text' field if we don't want to output the raw URL.
   +    $form['text']['#states']['visible'][':input[name="options[output_url]"]'] = ['checked' => FALSE];
   

   Nice that the UI does this.

3. +++ b/core/modules/views/views.module
   @@ -828,3 +829,40 @@ function views_view_delete(EntityInterface $entity) {
   +function views_view_presave(ViewEntityInterface $view) {
   

   Really nice to see module installs being coped with ++

Also we need a CR and

+++ b/core/modules/node/src/Plugin/views/field/Path.php
@@ -14,6 +14,9 @@
+ *
+ * @deprecated in Drupal 8.x, will be removed before Drupal 9.0.
+ *  Use @ViewsField("entity_link") with 'output_url' set.

This needs to follow the new https://www.drupal.org/node/2856615. We need to flesh out how a whole class is example - perhaps this issue can provide the example!

Adding some novice tasks for DrupalDevDays that will make this issue easier to approve.

Update the issue summary

Embed before and after screenshots in the issue summary

adding some tags for Mentored Core Sprint, Baltimore 2017.

I've reviewed #27 in the same method that #19 reviewed the patch. #27 applies cleanly against 8.4.x with the new options for "Use absolute link (begins with "http://")" and "Output the URL as text". This should be RTBC if the CR is good to go.

I *think* this might have been a bit of a spurious error. Let’s just retest before thinking otherwise...

Hi,
I patched my Drupal 8.3.2 successful but the only thing that is not working is translation.
For me the taxonomy term link is always displayed in my base language and is not displayed in the translated version when I switch the site to another language.

Adding the patch provides new options on an entity view's field "Link to [entity type]",i.e. two additional check boxes
1) Output the URL as text
2) Use absolute link (begins with "http://")
which allow views to provide the canonical entity URL of all entities, not just nodes.
here are the screenshots of before applying patch and after applying patch .

Just run through this again and tested that we can, indeed, now add links to entities that appear just as the text url of the entity.

Agreed that the translation thing is a bug but not necessarily in the scope of this issue as the same bug appears elsewhere. Indeed, it does make sense that this patch will make it easier to create a follow on issue to address the translation bug.

Assuming automated tests pass soon, I’m inclined to mark as RTBC when that happens.

BTW - what is stopping this going into 8.4?

Test fails looked like the db had gone away?? Retest...

Yes, thought so. Was just a random dB fail

Looks good, couple of minor observations that could be addressed if we have to reroll - more about complexity/readability than actual changes.

Retesting as last patch was one month ago

1. +++ b/core/modules/views/src/Plugin/views/field/EntityLink.php
   @@ -23,9 +24,22 @@ public function render(ResultRow $row) {
   +      $text = $this->getUrlInfo($row)->toString();
   +    }
   +    else {
   +      $text = parent::renderLink($row);
   +    }
   +    return $text;
   

   any reason not to just return $this->getURl...?

   Avoids both the else and the $text variable and makes the code easier to follow as reduces cyclic complexity

2. +++ b/core/modules/views/src/Plugin/views/field/EntityLink.php
   @@ -23,9 +24,22 @@ public function render(ResultRow $row) {
   +    return $this->getEntity($row)->toUrl($template, ['absolute' => $this->options['absolute']]);
   

   We could use ->toUrl($template)->setAbsolute($this->options['absolute']) here and avoid the magic array keys (yes they are Drupal's speciality I know)

Fixed my own nits

+++ b/core/modules/views/views.module
@@ -861,3 +862,40 @@ function views_view_delete(EntityInterface $entity) {
+          }
+        }
+        elseif (isset($field['plugin_id']) && $field['plugin_id'] === 'node_path') {
+          // Convert the use of node_path to entity_link.

Only one comment. We should probably add a trigger_error(... E_USER_DEPRECATED) here, however it's not deprecated as such until the upgrade path has run.

Opened a follow-up for this here #2913850: Trigger E_USER_DEPRECATED from config entity presave bc layers

Committed f1aa6b3 and pushed to 8.5.x. Thanks!