Usability Issue - Block configuration form

Re-rolled patch in comment #2 for Drupal 8.6.x
see file uploaded called: 2789241-block-config-form-user-msg-8.6.x.patch

Do you mean this should have a period? "Allow individual users to customize the visibility of this block in their account settings"

Re-rolled for 8.7.x WITH period at the end

I think I jumped the gun. Here is the patch for v8.6.x WITH period

Submitting re-roll after issue version was updated to current development branch

I'll try one last time! I got an error when I tried to test the other patch that said "file corrupted" so something was screwed up. This one was able to apply cleanly.

Thanks for all the re-rolling Elissa
The second description

-      unset($form['user_role']['roles']['#description']);
+      $form['user_role']['roles']['#description'] = $this->t('Allow individual users to customize the visibility of this block in their account settings.');

is unfortunately quite wrong.
How about:
Show block only if the user has at least one of the selected roles. No roles being selected will show to all users.

Uploading re-rolled patch for 8.7.x with more specific wording

Looks good to me
Quick note, when you upload a patch, you can set the status to needs review that will automatically trigger the test bot and if the test fails will automatically set it back to needs work - and even better it is clear from issue queue lists what the issues status is, without having to go back to it after the test succeeds.

Hm the content type one sounds odd. Based on the text it would apply to a views page that displays at least one of those types which is not true, is it? AFAIK it would apply to a page that displays a single node of one of those content types. Am I mistaken here?

Also if you can avoid the "(s)" that would be best. Like in the second description by wording it slightly differently, no need for an "(s)".

Good correction! How about:

"Show this block only if the node is of the selected content type. If you select no types, there will be no type-specific limitation."

Attached reroll against #18 #23

Tested out and there is no description appearing for content type.

Patch for 10.1.x. Please review.

This still needs an issue summary update per #31 please.

The Needs Review Queue Bot tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because there is a clear path forward after updating the issue summary. Because this is a regression from Drupal 7, perhaps we should also add a simple test for description so I added the Needs tests tag.

Novice issue reserved for the Mentored Contribution during the DrupalCon Portland 2024 contribution day. After 2024.05.08, this issue returns to being open to all. Thanks

removing my comment

First step is to rebase the patch against Drupal 11

Attempted re-roll against latest dev and pushed to issue fork.

I have rerolled the patch for Drupal 11.x. Please review it. Since I'm not familiar with writing tests, issue is open for adding tests and other relevant tags.

Please look at the tags before putting into review. Appears to be a reroll

First time contributors, update-in the issue with patricia_1

Problem/Motivation

Visibility controls in Blocks configurations are missing from help text in Drupal 8 .

Steps to reproduce

Blocks can be found at "/admin/structure/block"

Proposed resolution

Insert help text the same way as it was in Drupal 7 for Content Type and Roles.

Remaining tasks

Change code that inserts the "Help text"

Original report by [SwapS]

Updated issue summary

Thanks for your work on this issue.

So the issue summary update did not really happen here:

• It needs to be in the issue summary field, not a comment.
• It needs to specifically describe what the problem is, and how to fix. Currently, it's very vague. This issue is apparently a regression, so we should detail specifically what the regression is.
• Look at the screenshots in #8. In this case, a screenshot is perhaps worth 1000 words, or at least 100? If HEAD does not look like that, and it is desirable to have that help text, then we should update the Issue Summary's "User interface" section with "Before" and "After" subheaders that show HEAD without those descriptions and the merge request with it.

If we determine that is the case, then we need an automated test so that this will not regress again.

Thanks everyone!

The Drupal Contribution Mentoring team is triaging issues for DrupalCon Nara 2025, and we are reserving this issue for Mentored Contribution during the event. After November 19, this issue returns to being open to all. Thanks!

Hello from DrupalCon Nara! I'll be reviewing this issue today. This is my first time contributing.

When I checked this issue, it had already been fixed in Drupal 11.x.
This text appears Show this block only if the user has at least one of the selected roles. If you select no roles, the block will show to all users. after a fresh install. Please see the screenshot.

Can I have another tester verify?

I confirmed #68 is also appears in my view as well.