Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Follow up for #1498674: Refactor node properties to multilingual
Problem/Motivation
Code readability and maintainability - the code requires tidy-up beyond scope of original "refactor node properties to multilingual" issue, and this tidy should not hold up progress on the original issue.
Proposed resolution
Implement tidy-up once #1498674: Refactor node properties to multilingual is completed.
Remaining tasks
- Clean up code
- Clean up variable names
- Code re-flow improvements
User interface changes
None expected.
API changes
None expected.
Original report from 1498674 comment 296
It's great to see that the numbers are finally better with the updated patch. I think the storage code could use some more clean-up, variable name & code-flow improvements etc., but that a) does not need to hold up this great work in any way b) that clean-up will need to go beyond of what this patch introduces - thus deserves its own issue anyway. -> followup.
Comments
Comment #13
quietone CreditAttribution: quietone as a volunteer commentedI do support code cleanup but the Issue Summary is too vague to implement. I read the comment in the other issue and skimmed the patch as well. When the comment was written the patch had
125 files changed, 1160 insertions, 592 deletions. The lack of specifics here for the clean up make that a big task to figure out.Given that is 10 years old with no activity, that the code may have changed in that time I am closing this as outdated.