Automated Drupal 10 compatibility fixes

Hi,
i will review this patch.

Verified patch #2 on Drupal 10 Patch applied successfully

Testing Steps:

1. Install drupal 10
2. clone the branch on drupal (8.x-1.x-dev) on drupal 9 and checked deprecated code uisng upgrade status module
3. Added some changes in info.yml file and provide a patch as said upgrade status module and Applied patch #4 and #2 again checked
deprecated code on drupal 9
4. Then installed module on drupal 10
5. check module installed sucsessfully or not

module has been installed succesfully but after installing module on my drupal 10 site ,site not working properly showing errors in recent log messages, it can be moved to needs work.
thanks and regards

patch in #4 works for me

module has been installed succesfully but after installing module on my drupal 10 site ,site not working properly showing errors in recent log messages, it can be moved to needs work.

Given #4, moving to NW. #4, can you please provide the error messages? That would be very helpful.

There were 2 issues in the above patch #4
1. The manage display page throwing website encountered error. Logs displayed following error

ArgumentCountError: Too few arguments to function Drupal\image\Plugin\Field\FieldFormatter\ImageFormatter::__construct(), 9 passed in /app/modules/contrib/svg_image/src/Plugin/Field/FieldFormatter/SvgImageFormatter.php on line 49 and exactly 10 expected in Drupal\image\Plugin\Field\FieldFormatter\ImageFormatter->__construct() (line 75 of /app/core/modules/image/src/Plugin/Field/FieldFormatter/ImageFormatter.php)

2. The code was using /Drupal calls and not dependency injection

I have fixed these issues along with other coding standard issues

@ameymudras Thanks for testing and updating the patch and providing an interdiff.

This module needs functional testing on Drupal 10. Adding general instructions:

https://www.drupal.org/community-initiatives/contribution-events-initiat...

This is working for me in Drupal 9.5 and 10.1. Here are the steps for manual testing:

1. Create a new gitpod.io instance
2. Install and enable the module
3. Go to Article > edit field_image
4. Under the field "Allowed file extensions", add "svg"
5. Create a new Article and upload an SVG image
6. Try the responsiveness of the SVG. It doesn't work yet.
7. Install and enable SVG Image Responsive
8. Reload the article that was just created. The SVG should become responsive.

Thanks for the updated patch and testing. Removing testing tag.

I took a quick look at the interdiff and nothing jumped out at me so keeping as RTBC.

ConfigManagerInterface::findConfigEntityDependents() is deprecated so I updated #7 to replace it.

I have reviewed and checked Patch #12 this works for drupal 9.4 and drupal 10.0. and 10.0.1
Screenshots of the compatibility on 9.4 and the Uploaded svg image on 10 have been attached for reference:

varify patch #2 and #4 module succesfully installed but site is not working and log displayed errors ,it can be moved to need work and need testing for drupal 10 .

From #14, marking as Needs Work, although we do need logged errors of what actually was shown to diagnose the issue.

Removing images from the attachments, as those are not necessary.

Can't reproduce issues mentioned in #14, the patch in #12 works fine and SVG images & related functionality works as before. I think this is ready to be released especially with D10 being out.

Hello wonder if this can get committed for a D10 release now that 10 is out.

Pretty sure that the usage of the file_url_generator service makes this no longer compatible with Drupal <9.3, as it was introduced in that version.

My suggestion would be to start a new branch supporting 9.4 and 10

@imyaro Do you have time to work on this module or do you need some (new) co-maintainers?

Here's an update patch that corrects the core_version_requirement to make it 9.3 and up. I also removed code related to cache context that is no longer needed as of #2669074: Convert file_create_url() & file_url_transform_relative() to service, deprecate it. That was a workaround before the url generator service was in here.

My suggestion would be to start a new branch supporting 9.4 and 10

At this point 9.2 is no longer supported so I don't think a new branch is required here.

The 'core' key must be removed if support for Drupal < 8.7 is dropped. The attached patch does this. It also uses dependency injection for the FileUrlGenerator service rather than calling \Drupal::service().

The 'core' key must be removed if support for Drupal < 8.7 is dropped.

I just learned that about an hour ago!

The updates in the latest patch look good to me. I haven't tested it though. Here's the interdiff between 22 and 23.

Drupal 10 is out, so this is important. Any maintainer plans here?

#23 Installed and enabled module on Drupal10. Applied patch. Allowed field to accept "SVG" image but did not work for me. after uploading sgv image got an error(
svg-error.png)

In log error: Entity view display 'node.article.default': Component 'comment' was disabled because its settings depend on removed dependencies.

@Sarika Wirtz can you post also your image field widget settings form?
Did you install and test it on a clean D10 installation ?

I tried to repeat the steps from #27, but cannot reproduce the problem.

Clean D10 installation, installed and enabled this module with the patch applied. Allowed field to accept the "SVG" format. Created new node and uploaded SVG image without any problems. The node detail page is displayed correctly with the SVG image.

Also I suppose we should leave the tags here just in case the bot comes with something new (or the maintainer should decide if/when to remove that tag).

This should be at NR. The errors in #27 appear unrelated to this module and it should not have been kicked back to NW. It would be great if someone who has tested (@poker10?) would RTBC this.

As @Martijn de Wit said. I installed fresh installation of Drupal10.

As @Martijn de Wit said. I installed fresh installation of Drupal10. Installed module. Applied patch, allowed field to accept svg and I must say it's working perfectly fine. I can not reproduce my own error anymore. moving to RTBC.

@poker10 By mistake i removed your tag. Added them again. My apologies.

RTBC +1. Couldn't find any missing deprecation errors, using the upgrade_status module and PHPStan. Installs successfully under Drupal 10.

I closed MR 13 for visibility's sake (since it was on the wrong issue fork branch). Removed patch #12 from "3299276-automated-drupal-10", applied patch #23 by @daniel_j to branch "3299276-automated-drupal-10" and opened an MR for easier review!

Thank you for this review and cleanup @Grevil! Also confirming RTBC! :)

Maintainers?

I sent a mail through contact form to the maintainer.

This is the one of few modules which prevent our upgraded to D10!
Please add a new version.

I can confirm, it's work ! thanks.

Checking patch, will do a release soon.
Thanks everyone for participating

Great job!
Merged. Release coming soon.