[META] Fix @todo items referencing closed issues

Issue #2552791: MigrateSqlSource should use dependency injection is listed twice in the above list. It is a duplicate of #2681869: Provide clean way to merge configuration into migration plugins which removed a todo and added a new one,

-    // @TODO, remove this in https://www.drupal.org/node/2681869.
-    $destination = $migration->getDestinationConfiguration();
-    if ($destination['plugin'] === 'entity:file') {
+    // @todo Find a way to avoid this in https://www.drupal.org/node/2804611.
+    if ($definition['destination']['plugin'] === 'entity:file') {

The added todo is correct and the issue referenced is open, #2804611: Migrate sources and destinations need a way to get their requirements.

I've updated the table in the IS to show that these migration issue are complete.

Nice novice meta!

Since these are docs corrections, we'd backport them all the way to the production branch.

I tried running the shell script in the description and received the following error multiple times:

sed: 1: "s/<[^]*//g": unbalanced brackets ([])

I installed html-xml-utils via Homebrew on OSX. It's probably not necessary but I'm assuming it makes it easier to find the files and line numbers of these @todos. Any ideas?

In case it is useful, this should fix that script:

grep -r "@todo .*[\r\n]* https://.*drupal.org/.*" . | grep -o  '/[0-9]\+' | while read -r line ; do
     markup=$(curl --silent "https://www.drupal.org/node$line" | hxnormalize -x) 
     status=$(echo $markup |  hxselect '.field-name-field-issue-status .field-item' | sed 's/<[^>]*//g')
     if [[ "$status" == *"Closed"* ]]; then
       echo "[#$line]" | sed 's/\///g'
     fi
 done | uniq

The [^] needed to be [^>].

@richardbporter, thanks for the updates. To encourage novice contributors I think it would be helpful that this is not assigned to anyone. I hope you don't mind but I am changing to unassigned.

No, not at all. I wasn't sure if meta issue should be assigned or not.

Added #2002138: Use an adapter for supporting typed data on ContentEntities

Used the new script to get an up to date list of issues. Sorted the results and removed the duplicates. Then Updated IS with the results. And finally removed the status column because we can get that information for the status of the issue in the 'fixed by' column.

Really remove the status column.

Ran the grep-script on the current 10.1.x-branch and updated the IS with the current @todos which have a link to a closed d.o. issue.

Sorted the issues by node ID ascending.

Ran the grep-script on the current 10.1.x-branch and updated the IS with the current @todos which have a link to a closed d.o. issue.

Sorted the issues by node ID ascending.

Ran the grep-script on the current 11.x-branch and updated the IS with the current @todos which have a link to a closed d.o. issue.

Sorted the issues by node ID ascending.

Removing `Novice`-tag, since simply opening a new issue for each @todo item referencing closed issues has shown to be non-productive.
Those issue will basically be un-noticed and be stuck in the queue for a long time.

However, opening issues with a proposed solution (even if not accepted) has been proven fruitfull: Either the proposed solution gets committed, or a better approach is suggested.

This is however not exactly novice-material.

Found an issue fixing one of these during RTBC queue triage.

I wanted to update this so ran the script in the issue summary sending the output to a file, todo-list.txt. There were 51 results and it was difficult to compare with the list in the issue summary. So, I wrote a script to sort the output and create a new table. Of course, I then had to update the second column by hand. It should be easier to maintain in the future if the first column is sorted.

I checked all the children and found a duplicate an updated the table.

#!/bin/bash

cat todo-list.txt | sed 's/\[#\(.*\)]/\1/' | sort -uh > sorted.txt

while read -r line
 do
  echo "<tr><td>[#$line]</td><td></td></tr>"
done < sorted.txt