Problem/Motivation

In #3123832: [META] Fix @todo items referencing closed issues we've discovered there's a @todo in \Drupal\Tests\pgsql\Kernel\pgsql\SchemaTest::testPgsqlSequences.
This @todo is linked to an d.o. issue that is already closed: #1060476: Multiple issues when PostgreSQL is used with non-public schema.

This is the @todo:

    // @todo replace 'public.' with defaultSchema when issue https://www.drupal.org/i/1060476 lands.
    $this->assertEquals('public.' . $this->connection->getPrefix() . 'sequence_test_uid_seq', $sequence_name);

Steps to reproduce

Proposed resolution

Use $schema = $options['schema'] ?? 'public'; as introduced in #1060476: Multiple issues when PostgreSQL is used with non-public schema.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3377381

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !4492

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

All green and simple cleanup.

  • quietone committed ebb63a39 on 11.x 
    Issue #3377381 by Spokje, smustgrave: Change hardcoded schema name "...
quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Fixed

I went looking for when the @todo was originally added to learn more. It seems to have been #3028706-65: New serial columns do not own sequences but I did see any discussion there about it.

Yes, this change does what the @todo intended.

Committed ebb63a3 and pushed to 11.x. Thanks!

Spokje closed merge request !4492

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.