Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
With https://www.drupal.org/project/drupal/issues/2928906 fixed, the manually specified IDs in EntitySchemaTest::testPrimaryKeyUpdate
can be removed.
Proposed resolution
Remove the ID parameters passed to $storage->create()
and the @todo comment.
Remaining tasks
Write patch.
User interface changes
None.
API changes
None.
Comment | File | Size | Author |
---|---|---|---|
#4 | 3159744-applied.png | 62.19 KB | Abhijith S |
#2 | remove-manually-specified-ids-3159744-1.patch | 1.08 KB | richardbporter |
Comments
Comment #2
richardbporter CreditAttribution: richardbporter as a volunteer commentedComment #3
richardbporter CreditAttribution: richardbporter as a volunteer commentedComment #4
Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commentedApplied patch #2 and it removes the ID parameters passed to $storage->create() and in the @todo comment.
RTBC +1
Comment #5
init90Looks like a nice cleanup.
Comment #7
catch@Abhijith S there's no need to upload screenshots of the patch applying since the testing infrastructure tells us this already.
Committed 6c8ee54 and pushed to 9.2.x. Thanks!