Problem/Motivation

With https://www.drupal.org/project/drupal/issues/2928906 fixed, the manually specified IDs in EntitySchemaTest::testPrimaryKeyUpdate can be removed.

Proposed resolution

Remove the ID parameters passed to $storage->create() and the @todo comment.

Remaining tasks

Write patch.

User interface changes

None.

API changes

None.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

richardbporter created an issue. See original summary.

richardbporter’s picture

richardbporter’s picture

Status: Active » Needs review
Abhijith S’s picture

FileSize
62.19 KB

Applied patch #2 and it removes the ID parameters passed to $storage->create() and in the @todo comment.

after

RTBC +1

init90’s picture

Version: 8.9.x-dev » 9.2.x-dev
Status: Needs review » Reviewed & tested by the community

Looks like a nice cleanup.

  • catch committed 6c8ee54 on 9.2.x
    Issue #3159744 by richardbporter: Remove manually specified IDs in...
catch’s picture

Status: Reviewed & tested by the community » Fixed

@Abhijith S there's no need to upload screenshots of the patch applying since the testing infrastructure tells us this already.

Committed 6c8ee54 and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.