Problem/Motivation

When reviewing #2961114: Migrate D6 i18n CCK field option translations during a migrate meeting it was decided that the the destination getIds() methods should not have any conditional logic. See Comment #20.

The code is:

    if ($this->isTranslationDestination()) {
      $ids['langcode']['type'] = 'string';
    }

and it is in at least these destionation classes:

core/modules/migrate/src/Plugin/migrate/destination/Config.php
core/modules/migrate/src/Plugin/migrate/destination/EntityConfigBase.php
core/modules/migrate/src/Plugin/migrate/destination/EntityContentBase.php
core/modules/migrate/src/Plugin/migrate/destination/EntityFieldInstance.php
core/modules/migrate/src/Plugin/migrate/destination/EntityRevision.php

Proposed resolution

Remaining tasks

Write a patch
Review
Commit

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 3004574-11.patch2.52 KBPooja Ganjage

Comments

quietone created an issue. See original summary.

jofitz’s picture

jofitz
he/him
commented

What should be used in place of the conditional logic to maintain the current functionality?

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Issue tags: +Migrate critical

Triaging issue queue.

quietone’s picture

quietone commented
Related issues: +#2820886: EntityRevision should calls parent::getIds();

Found this implementation of getids which moves the conditional logic to a new method. #2820886: EntityRevision should calls parent::getIds();

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

quietone’s picture

quietone commented

The migration of node revision translations, #2746541: Migrate D6 and D7 node revision translations to D8, introduces the entity_complete destination plugin which uses a deriver and has conditionals in the getIds() method. See comment #402

If we want to pursue this then we need to be sure that having some NULL destination IDs does not cause any problems.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

quietone’s picture

quietone commented
Issue tags: -Migrate critical

Discussed at a migrate meeting today. This issue is not migrate critical, so removing tag.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3004574-11.patch2.52 KB

Hi,

Creating a patch for this issue.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 11: 3004574-11.patch, failed testing. View results

quietone’s picture

quietone commented
Status: Needs work » Closed (won't fix)

@Pooja Ganjage, thanks for making the patch. Unfortunately, I got called away and didn't finish my comment.

At the meeting the migrate maintainers decided this was a won't fix.