Provide menu link with disable option [Node Add Form]

@abhaysaraf, can you please put a screenshot with the new checkbox? This also needs tests.

Just fixed a failed test from #2
Also attached a screenshot with this checkbox

Something I realised from the test-fail. Is the "Enabled" checkbox checked by default when the page loads? I think that would be a good idea.

+++ b/core/modules/menu_ui/menu_ui.module
@@ -304,6 +305,13 @@ function menu_ui_form_node_form_alter(&$form, FormStateInterface $form_state) {
+    '#default_value' => isset($defaults['enabled']) ? $defaults['enabled'] : 1,

This could be simplified to $defaults['enabled'] ?? 1

Or even just (bool) $defaults['enabled'].

hussainweb thanks for your advise. Your notice make sense.
Made changes in this patch

Hi, thank you for your work. It works like charm - tested previously with 9.0.x and now with 9.1.0

Btw: for D7 I used https://www.drupal.org/project/disable_node_menu_item, for D8 https://www.drupal.org/sandbox/pcranston/2920832. Now I'm happy with this simple, clean core patch.

Applied patch on 9.2.x and it works.The checkbox for showing menu items appears after this patch and it works well.Adding screenshots.

Before:

After:

I was having an issue with the patch in #9 when some of the content types did not show the menu on the node edit form. The attached patch corrects this.

I've expanded on patch #15 default enable link to the node type form, so that this setting can be have defaults defined for each content type.

I should also note, the above patches were exactly the feature I was looking nice work.

Verified and tested patch#17 on the drupal 9.3.x-dev version. Patch applied successfully But found one observation.

Testing Steps:

1. Install drupal 9.3.x-dev version.
2. Login as Administrator
3. Observe the "Menu link Enable/disable the checkbox" is not present on the Add/Edit form of any default content type (Article or basic page) or custom content type under the Menu Setting option.
4. Apply patch and
5. Verify "Menu link Enable/disable the checkbox" is provided on the Add/Edit form of any default content type (Article or basic page) or custom content type under the Menu Setting option.
6. Verify as per the Status menu link enable/disable.
7. Verify bydefault Status of menu link should display enable.

Expected Result:

1. The "Menu link Enable/disable the checkbox" option should be provided on the Add/Edit form of any default content type (Article or basic page) or custom content type under the Menu Setting option.
2. As per the Status of the checkbox menu, the link should enable/disable.
3. Bydefault Status of menu link should display enable.

Actual Results:

1. The "Menu link Enable/disable the checkbox" option is provided on the Add/Edit form of any default content type (Article or basic page) or custom content type under the Menu Setting option.
2. As per the Status of the checkbox menu, the link is enable/disable and working fine
3. Bydefault Status of menu link display disabled.

Observation:
By default status of the menu link displayed "disabled/unchecked" for all content types. It should Enable by default. Please refer attached screenshot (Bydefault Disabled_unchecked displayed.png ).

patch#17 working fine and applied cleanly for reference sharing screenshot ...
Thanks

Fixed CS error

What has changed

1. Updated failing test for new menu_link options in node form.
2. Fixed issue found in: #19 - checkbox is now checked if no setting has been configured.
3. Updated JS to hide the menu link enabled, if no menus are selected

Fixed the custom command fail issues.

What has changed

1. Added tests to check the content type configuration option.
2. Updated node form tests, to test the enable link functionality.

Fixed lint issue.

Picking this up for review in a MR, commited the most important patches from the issue for easier tracking of history.

Switched to 9.4.x-dev (and updated code from #29 accordingly)

Keeping #29 visible (applies to 9.3); hiding all other patches and interdiffs.

My review on this FWIW, with the hope this moves on, it's a wonderful feature.

Patch #29 was not applying in core 9.3.5 (some changes to the two js files it patches). Leaving the same patch updated for that version here in case anyone needs this.

Thanks for the 9.3 patch @Nelson Alves. Applied and works well in 9.3.9.

This is patch against 9.4.x. I rerolled the MR and made the suggested corrections. Only thing I couldn't figure out was the note about logical error on https://git.drupalcode.org/project/drupal/-/merge_requests/1443#note_57563.

I tested this on local, works fine and is useful feature.

Fixed Drupal CS issue of patch #37.

Included patch should resolve "Custom commands failed".

Maybe now the CI bot is happy.

Verified and tested patch #40.
Patch applied successfully and looks good for me.
Sharing screenshots for the reference.

Hi,
Applied patch #40 is working fine.
Thank you for the patch.

I'm using patch #35 with Drupal 9.3.9. I'm not seeing the "Enabled" option on the node edit form.

This patch works if I start a brand new website. If I use the one I'm testing on, there is no "Enabled" option.

Merge request is outdated, patch missing upgrade path

The feature provides the ability to create node's with a menu link that is disabled. What upgrade path would we be providing?

The module "Menu Link" disables the Menu UI module from adding to the node edit page.

Rerolled patch against 9.5.x

Applied #48 patch on 10.1.x-dev and it works.

Trying to update the PR, against 10.1.x and also including all the work that went into patch #40.

Regarding patch #48: Why is this patch missing so many of the changes from #40 if it is a reroll?
Gonna set this back to 'Needs work' till this gets clarified.

In the process of writing up a separate issue about the manage form display page i've noticed the problem and inconsistency this issue is going to solve. thanks for working on that! but one detail aside the points mentioned in #52 the issue also needs an issue summary. at the moment there isn't any at all anymore.

I think re-roll at #48 was mistake, its missing tests etc, my suggestion is to ignore it for now.

Re roll of #40 for Drupal 10.1.4

Patch for 11.x.

Fixed the failed test cases, Please have a look.

New schema will require an upgrade path

+    // Configure menu links to be disabled.
+    $edit = [
+      'menu_options[main]' => 1,
+      'menu_parent' => 'main:',
+      'link_enabled' => FALSE,
+    ];
+    $this->drupalGet('admin/structure/types/manage/page');
+    $this->submitForm($edit, 'Save');
+    $this->assertSession()->pageTextContains('The content type Basic page has been updated.');

Don't think all this is needed. Just using the config service should work. Unless there is testing of a new configuration option, which is missing.

@vsujeetkumar
@_utsavsharma
@manvinder12
vsujeetkumar
_utsavsharma
manvinder12
Your patch did not work for:
Drupal Version 10.1.5
MySQL Version 5.7.29
PHP 8.1.14

I use this module on D10: https://github.com/SakaSerbia/disable_node_menu_item

@19, we should be able to set the default as disabled or enabled per content type

I created a new MR on 11.x and rebased the existing changes.

Adapted the patch 3075230-58.patch for Drupal 11.1.x

Rebased this one but seems will still need upgrade path.

The latest patch from MR 11618 is needed for D11.4.x, but disabling the menu item in the node edit form no longer saves the unchecked value. So unchecking and saving keeps the menu item in the menu, and editing the node again shows the Enabled checkbox as checked. Worse: it prints the full menu for disabled menu items, and in our case we need the specific child-level menu on disabled menu items.

ETA: Did some further testing and the patch from #68 works as expected on D11.3.x but fails to install for D11.4.x so it looks like I'll be downgrading to D11.3.x until this is fixed.

Probably belongs to the menu_ui module