datetime date views filter: DateTime object not set

After applying the patch the date filter only accepts MM/DD/YYYY date format. My default date format is DD/MM/YYYY. When I select 13/05/2018 I get a "Wrong date format" error.

Seems like proper fix. Not sure about the format thing. Hmmm.

I wonder if we can really do anything about the format until #2648950: [PP-2] Use form element of type date instead textfield when selecting a date in an exposed filter lands. Date::opSimple() and ::opBetween() basically do the same thing. Since a format isn't chosen, you are at the whim of what DTP will do (the Rethans book probably has the best explanation).

+++ b/core/modules/datetime/src/Plugin/views/filter/Date.php
@@ -98,6 +99,50 @@ public static function create(ContainerInterface $container, array $configuratio
+      $convert = new DateTimePlus($value);

Wondering out loud if we want to add the timezone here (and below) to mirror what the filter does?

I am also facing the issue in on of the website. How to resolve this.

The website encountered an unexpected error. Please try again later.Exception: DateTime object not set. in Drupal\Component\Datetime\DateTimePlus->__call() (line 355 of core/lib/Drupal/Component/Datetime/DateTimePlus.php)

Any help would be appreciated. when I upgraded the site from drupal 8.3.9 to drupal 8.5.3.

Same problem with date between in my french website

The patch #6 is almost good. It lacks this workaround into validateExposed()

    $language = \Drupal::languageManager()->getCurrentLanguage()->getId();
    if($language == "fr")
    {
         $dt = date_create_from_format('d/m/Y', $value);
         if($dt!==FALSE)
            $value = $dt->format("m/d/Y");
    }

$dt might be false when using relative dates like "+1 month "

yes something like this :

    $language = \Drupal::languageManager()->getCurrentLanguage()->getId();
    $languages = ['fr', 'nl', 'de', 'en']; // I think the best place for retrieve this values is to create a method in languageManager object
    if ($operators[$operator]['values'] === 1) {
      if(in_array($language, $languages)) {
        $date_style = date_create_from_format('d/m/Y', $value);
        if($date_style !== FALSE) {
          $value = $date_style->format('m/d/Y');
        }
      }
      $convert = new DateTimePlus($value);
      if ($convert->hasErrors()) {
        $form_state->setError($form[$this->options['expose']['identifier']], $this->t('Invalid date format.'));
      }
    }
    elseif ($operators[$operator]['values'] === 2) {
      if(in_array($language, $languages)) {
        foreach ($value as $key => $date_value) {
          $date_style = date_create_from_format('d/m/Y', $date_value);
          if($date_style !== FALSE) {
            $value[$key] = $date_style->format('m/d/Y');
          }
        }
      }
      $min = new DateTimePlus($value['min']);

a code like this works in local with exposed dates filter
the difficulty is to extend to a global solution for all Europeans languages like fr, nl, de for example and formats for other countries like YMD
https://en.wikipedia.org/wiki/Date_format_by_country

I have a view which can be filtered by using a date exposed filter. The filtering didn't work properly. The patch https://www.drupal.org/project/drupal/issues/2966735#comment-12590809 works for me. But I had to alter it a little bit to remove the timezone data from the dates, which was causing the bug in my case.

My altered custom patch is attached to this comment. I think it's not the proper way of adding extra functions to the core file.

hello

i have the same problem

Exception: DateTime object not set. in Drupal\Component\Datetime\DateTimePlus

I have test the patch 6 and i have a blank page

any news please ?

i have error : Avalid date format,

i have put the last patch and i have theses errors :

core/modules/datetime/src/Plugin/views/filter/Date.php).
Drupal\datetime\Plugin\views\filter\Date->validateExposed(Array, Object) (Line: 140)
Drupal\views\Form\ViewsExposedForm->validateForm(Array, Object)
call_user_func_array(Array, Array) (Line: 82)
Drupal\Core\Form\FormValidator->executeValidateHandlers(Array, Object) (Line: 275)
Drupal\Core\Form\FormValidator->doValidateForm(Array, Object, 'views_exposed_form') (Line: 118)
Drupal\Core\Form\FormValidator->validateForm('views_exposed_form', Array, Object) (Line: 576)
Drupal\Core\Form\FormBuilder->processForm('views_exposed_form', Array, Object) (Line: 319)
Drupal\Core\Form\FormBuilder->buildForm('views_exposed_form', Object) (Line: 135)
Drupal\views\Plugin\views\exposed_form\ExposedFormPluginBase->renderExposedForm() (Line: 1238)
Drupal\views\ViewExecutable->build(NULL) (Line: 1391)
Drupal\views\ViewExecutable->execute(NULL) (Line: 1454)
Drupal\views\ViewExecutable->render() (Line: 131)
Drupal\views\Plugin\views\display\Block->execute() (Line: 1630)
Drupal\views\ViewExecutable->executeDisplay('listing', Array) (Line: 77)
Drupal\views\Element\View::preRenderViewElement(Array) (Line: 59)
Drupal\views\Plugin\Block\ViewsBlock->build() (Line: 163)
Drupal\block\BlockViewBuilder::preRender(Array)

thank you very much

Patch from #15 rerolled for D8.7.x

1. +++ b/core/modules/datetime/src/Plugin/views/filter/Date.php
   @@ -11,6 +11,7 @@
   +use Drupal\Core\Form\FormStateInterface;
   

   Nity, should be alphabetical.

2. +++ b/core/modules/datetime/src/Plugin/views/filter/Date.php
   @@ -179,4 +180,77 @@ protected function getOffset($time, $timezone) {
   +  public function removeTimezoneFromDate($date_data) {
   

   Prob should be protected. Also needs $date_data and return documented in the docblock.

Need to look at this closer but we need a test to demonstrate the problem in the IS, and then show that this fixes it. So, back to Needs Work.

I applied patch #17 and got the error:
( ! ) Fatal error: Cannot use Drupal\Core\Form\FormStateInterface as FormStateInterface because the name is already in use in /var/www/html/docroot/core/modules/datetime/src/Plugin/views/filter/Date.php on line 15

#17 works for me.
Drupal 8.7.5

The patch from #17 is working despite the fact that it introduces a couple of new minor issues. At least the major problem is gone.

Here I have added a new patch after making changes as suggested in comment #18.

I have also removed the commented code from patch #17.

But it still needs tests.

I'm experiencing this issue too, often triggered by crawlers.

category=22&field_publication_date_value[max]=nowfield_publication_date_value[min]=1990-01-01&items_per_page=50&language=***LANGUAGE_language_interface***&market=All&page=4&vt=4

Looking at the query I think my issue is more around a missing & in the GET string.

Not sure that the error deserves a WSOD of death though.

#17 works for me, Drupal 8.8.5

#23 don't works for me, I have problems with date formats. It only allows English format.

And if I set "greater than or equal to" filter I get:

Warning: Illegal string offset 'min' in Drupal\datetime\Plugin\views\filter\Date->validateExposed() (line 218 of core/modules/datetime/src/Plugin/views/filter/Date.php).
Warning: Illegal string offset 'max' in Drupal\datetime\Plugin\views\filter\Date->validateExposed() (line 218 of core/modules/datetime/src/Plugin/views/filter/Date.php).
Warning: Illegal string offset 'min' in Drupal\datetime\Plugin\views\filter\Date->validateExposed() (line 219 of core/modules/datetime/src/Plugin/views/filter/Date.php).
Warning: Illegal string offset 'min' in Drupal\datetime\Plugin\views\filter\Date->validateExposed() (line 219 of core/modules/datetime/src/Plugin/views/filter/Date.php).
Warning: Illegal string offset 'max' in Drupal\datetime\Plugin\views\filter\Date->validateExposed() (line 220 of core/modules/datetime/src/Plugin/views/filter/Date.php).
Warning: Illegal string offset 'max' in Drupal\datetime\Plugin\views\filter\Date->validateExposed() (line 220 of core/modules/datetime/src/Plugin/views/filter/Date.php).
Formato de fecha no válido.

I'm running into this too, on a multilingual site. Investigating now.

Hello there

I've just done a re-make for the patch for core 9.3.9. Hopefully, this will work ok.

Regards,
Andrei

Who can review the latest patch and say something in terms of coverage?

I rerolled #23 patch and added some changes.

@Odai Atieh Would you please post an interdiff illustrating those changes, and perhaps describe what they are?

This is a reroll of #30 for 9.4.x.

#33 may be interesting, but it isn't explained and it failed tests. I'd like to hear more about it.

I noticed the last patch was only working for the case when we expose the operator so I updated MR https://git.drupalcode.org/project/drupal/-/merge_requests/2151 to also consider the cases when operator is not exposed and when using operator IS BETWEEN

After Updating the Patch #37 is failing. Issue still not fixed in Drupal 9.4.x.

Steps to reproduce:
1. Create a date field in the Entity bundle.
2. Create a view with Date exposed filter.
3. Search any keyword and Date format will get the Error message in the Recents.

Latest MR as patch attached.

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

I also faced the same issue with the Date time object on the Views exposed filter having the wrong Date format. The issue is due to the Views Token filter module. After the proper token update it works fine.

But, expected to show a valid error or warning rather than a page break. The patch was not applied with the latest version of Drupal core 10.1.x. Rerolled the patch and resolved the page break.

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

added updated patch fixed CCF #45. modifies the validateExposed() function to use a local variable $form_element to hold the field element that needs to be set with the form error message. It also changes the if-else block to use the null coalesce operator instead of an if-else block for brevity.

Also look at the tags please. Was previously tagged for test which are still needed.

Patch works, but not in case the form element in the exposed form is placed inside a container or other wrapper. I added support for this case. Also, I faced an issue with the "reset" button while testing this patch: validation didn't let me perform the reset action. So I added improvement for that case as well.

Code style improvement.

I still get a PHP warning in AttributeArray (line 79) because the original input array is statically cached in ViewExecutable::getExposedInput() on line 726, which happens before the data is validated. We need to validate the data before it is saved. - This may be a project specific error, please ignore for now.

Saw this exception in my log slowing down my website because bots trigger this one a lot. Looks like there's been significant work done on this merge request since it's last review.

Seems will still need test coverage for this. MR should be updated for 11.x

I have reproduced the error in the UI of Drupal 11.x-dev. See screenshot of the test view

See the screenshot of the error message

The current solution seems not to solve the issue if a URL accessing the date field has an invalid date format.
For example, we received this request:

?to_date[date]=../admin/noop.cgi?foo=bar&test=blah

A bot trying to brute force and causing issues, in that case, it throws the same error:

User error: Exception thrown while calling __toString on a Drupal\Core\Datetime\DrupalDateTime object in /var/www/html/docroot/core/lib/Drupal/Component/Datetime/DateTimePlus.php on line 354: DateTime object not set. in Drupal\Component\Datetime\DateTimePlus->__toString() (line 20 of core/lib/Drupal/Component/Utility/ToStringTrait.php).
Drupal\Component\Datetime\DateTimePlus->__toString() (Line: 161)
Drupal\views\Plugin\views\filter\Date->acceptExposedInput(Array) (Line: 184)
Drupal\views\Form\ViewsExposedForm->submitForm(Array, Object)
call_user_func_array(Array, Array) (Line: 129)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 67)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 609)
Drupal\Core\Form\FormBuilder->processForm('views_exposed_form', Array, Object) (Line: 326)
Drupal\Core\Form\FormBuilder->buildForm('\Drupal\views\Form\ViewsExposedForm', Object) (Line: 134)
Drupal\views\Plugin\views\exposed_form\ExposedFormPluginBase->renderExposedForm() (Line: 1304)
Drupal\views\ViewExecutable->build(NULL) (Line: 1457)
Drupal\views\ViewExecutable->execute(NULL) (Line: 1520)
Drupal\views\ViewExecutable->render() (Line: 133)
Drupal\views\Plugin\views\display\Block->execute() (Line: 1696)
Drupal\views\ViewExecutable->executeDisplay('block_3', Array) (Line: 81)
Drupal\views\Element\View::preRenderViewElement(Array) (Line: 61)
Drupal\views\Plugin\Block\ViewsBlock->build() (Line: 106)
Drupal\layout_builder\EventSubscriber\BlockComponentRenderArray->onBuildRender(Object, 'section_component.build.render_array', Object)
call_user_func(Array, Object, 'section_component.build.render_array', Object) (Line: 97)
Drupal\tracer\EventDispatcher\TraceableEventDispatcher->dispatch(Object, 'section_component.build.render_array') (Line: 90)
Drupal\layout_builder\SectionComponent->toRenderArray(Array, ) (Line: 88)
Drupal\layout_builder\Section->toRenderArray(Array) (Line: 331)
Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay->buildSections(Object) (Line: 291)
Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay->buildMultiple(Array) (Line: 340)
Drupal\Core\Entity\EntityViewBuilder->buildComponents(Array, Array, Array, 'full') (Line: 24)
Drupal\node\NodeViewBuilder->buildComponents(Array, Array, Array, 'full') (Line: 282)
Drupal\Core\Entity\EntityViewBuilder->buildMultiple(Array) (Line: 239)
Drupal\Core\Entity\EntityViewBuilder->build(Array)
call_user_func_array(Array, Array) (Line: 113)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 870)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 432)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 248)
Drupal\Core\Render\Renderer->render(Array, ) (Line: 238)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 638)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 231)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 128)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
call_user_func(Array, Object, 'kernel.view', Object) (Line: 97)
Drupal\tracer\EventDispatcher\TraceableEventDispatcher->dispatch(Object, 'kernel.view') (Line: 186)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 263)
Drupal\shield\ShieldMiddleware->bypass(Object, 1, 1) (Line: 130)
Drupal\shield\ShieldMiddleware->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 38)
Drupal\tracer\StackMiddleware\TracesMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 741)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

I will check to apply a fix for that case too.

1. A new branch based on 11.x-dev has been created and is now the default branch
2. The new datetime field validation patch has been committed to a MR
3. The validation function code has been fixed including phpstan
4. The pipeline is running green
5. Testing locally in a test view with an exposed datetime filter, the fix validates wrongly formatted dates

The new validation function validating a view datetime field

Test coverage is now in place. Changing status to 'Needs review'.

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Applied bot fix

Why remove Needs Review Queue Initiative tag?

Good spot. Have restored the attribute.

Believe feedback has been addressed here.

I read the comments and the MR and tested the change locally. I find that all questions are answered. I also updated credit.

And, I'd like to remind committers that screenshots should be available from the issue summary.

Leaving at RTBC

Committed/pushed to 11.x and cherry-picked to 10.5.x, thanks!

oh heck yeah. Can't wait to upgrade. This is my only logged error.

@greg FYI the patch from gitlab applies nicely to 10.4.8

Tested the patch on Drupal 11.1.6, and it doesn’t apply.