Remove source entity from webform submission form ids

hello, Jacob! :)

Yes, that looks fine to me. I do not have much to suggest. The only thing I see is the new WebformSubmissionForm::getFormId() looks just as its parent. So we can remove the method as a whole and use parent's implementation of that method. Hehe, you can tell I really like removing code :)

Just out of curiosity I glanced into webform_form_webform_submission_form_alter() and there are some findings.
It seems that you're running another set of form_alters in there:

  $hooks = [];
  $hooks[] = 'form_webform_submission_' . $webform->id() . '_form';
  if ($source_entity) {
    $hooks[] = 'form_webform_submission_' . $webform->id() . '_' . $source_entity->getEntityTypeId() . '_' . $source_entity->id() . '_form';
  }

  $form_id = $form_object->getFormId();
  \Drupal::service('module_handler')->alter($hooks, $form, $form_state, $form_id);
  \Drupal::service('theme.manager')->alter($hooks, $form, $form_state, $form_id);

Notice, that webform_form_webform_submission_form_alter() has an IF statement to add one more hook if the current webform has source entity. Maybe you want to remove that part too?

Lastly, I attach the patch that removes ::getFormId().

Yep, it sounds reasonable to me. I do not expect many people would care for the source entity. And those (hopefully few) who do care, still can include necessary IF statements inside of their implementation of hook_form_webform_submission_WEBFORM_ID_form_alter().

I think with the patch committed there is still plenty machinery to alter the form for custom module developers.

FYI: One thing this broke for us is a captcha configuration for the old form_id. I know that this can be added directly in webform and I asume most people are doing it like that, and it actually only was there for historical reasons in the default config of our distribution (originally we used contact.module, had an captcha example form for it, that was then migrated to webform at some point but we kept the configuration in captcha).

Please re-open this. It is not fixed after commit revert. There is no easy solution to add Captcha now if you have webform shown on all nodes of certain type for example.

Probably there can be some setting on Webform entity.

Or maybe do something with getBaseFormId() ?