Problem/Motivation

As mentioned in #2647824-29: [policy and patch] Determine what should go in CHANGELOG.txt for 8.x core releases, for the Drupal 8.4.x minor release, we're going to use a single collaborative process for drafting the core release notes in a markdown format. This will allow us to use the collaborative process we've used in the past for minor CHANGELOGs (see, for example, #2846830: Add changelog for Drupal 8.3.0) and reduce the duplication of effort and manual labor for creating release notes for Drupal.org.

Proposed resolution

Identify important features or improvements that have been committed to 8.4.x only. Make sure these issues are tagged with 8.4.0 release notes.

Add an entry describing the change. Use markdown to draft the release notes and organize the entries in sections. Example entries:

## Third-party library updates

* [Drupal's Symfony dependency has been updated from Symfony 2.8 to Symfony
  3.2](https://www.drupal.org/node/2712647). This major version update is
  necessary because Symfony 2.8 support will end around the release of Drupal
  8.6.0 next year. [See the change record for information about Symfony 3 BC
  breaks that affected Drupal core](https://www.drupal.org/node/2743809).
  [Drupal 8 also requires Symfony 3.2.8](https://www.drupal.org/node/2871253)
  because of a bug in Symfony 3.2.7.
* [zendframework/zend-diactoros has been updated from 1.3.10 to 1.4.0](https://www.drupal.org/node/2874817).

Each entry should link the relevant issue. This both provides a way for users to learn more about the change, and allows us to parse the release notes and confirm that we've written entries for all the important changes. (So #2848192: Add issue #s to CHANGELOG.txt entries can be closed as a duplicate of this issue.)

For reference, here are the release notes and CHANGELOG from 8.3.0:

Note: #2191525: [policy, no patch] Markdown coding standards (adopt CommonMark spec) is open for Drupal markdown coding standards generally, and #1224506: Allow markdown on drupal.org comments (with a non-default markdown-tuned input format) is open to add support for Markdown on Drupal.org. However, for this release, the release managers will just use a third-party tool to convert this Markdown file into HTML that will be used for the body of the core release node.

Remaining tasks

Expand the stub patch with additional sections and entries.

CommentFileSizeAuthor
#93 interdiff.txt2.05 KBxjm
#93 2895685-92.patch7.95 KBxjm
#91 interdiff.txt1.35 KBcatch
#91 create_release_notes-2895685-91.patch7.33 KBcatch
#90 create_release_notes-2895685-90.patch7.41 KBcilefen
#90 interdiff-2895685-90.txt3.01 KBcilefen
#89 media-interdiff.txt1.45 KBxjm
#89 2895685-89.patch6.32 KBxjm
#88 2895685-88.patch5 KBxjm
#85 2895685-85.patch43.87 KBxjm
#85 interdiff-rewrap-85.txt42 KBxjm
#84 intediff-83-84.txt12.93 KBxjm
#84 2895685-84.patch17.98 KBxjm
#83 interdiff.txt610 bytesGábor Hojtsy
#83 2895685-81.patch12.08 KBGábor Hojtsy
#78 interdiff.txt3.73 KBGábor Hojtsy
#78 2895685-78.patch11.94 KBGábor Hojtsy
#77 interdiff.txt2.21 KBGábor Hojtsy
#77 2895685-77.patch9.78 KBGábor Hojtsy
#75 interdiff.txt3.3 KBGábor Hojtsy
#75 2895685-74.patch9.78 KBGábor Hojtsy
#71 interdiff.txt762 bytesGábor Hojtsy
#71 2895685-71.patch7.72 KBGábor Hojtsy
#70 interdiff.txt4.26 KBGábor Hojtsy
#70 2895685-70.patch7.11 KBGábor Hojtsy
#68 2895685-68.patch3.42 KBGábor Hojtsy
#56 changelog-2895685-56.patch26.37 KBxjm
#56 changelog-2895685-56.patch26.37 KBxjm
#52 changelog-2895685-51.patch25.64 KBxjm
#50 changelog-2895685-50.patch115 bytesxjm
#48 interdiff-45-48.txt1.71 KBeffulgentsia
#48 2895685-48.patch19.21 KBeffulgentsia
#45 interdiff-2895685-41-45.txt6.91 KBprestonso
#45 2895685-45.patch18.77 KBprestonso
#41 interdiff-2895685-39-41.txt1.38 KBDyanneNova
#41 2895685-41.patch17.63 KBDyanneNova
#39 interdiff-2895685-36-39.txt6.58 KBprestonso
#39 2895685-39.patch16.56 KBprestonso
#36 interdiff-2895685-30-36.txt17.28 KBprestonso
#36 2895685-36.patch14.54 KBprestonso
#30 2895685-30.patch13.85 KBtimmillwood
#30 interdiff-2895685-30.txt2.25 KBtimmillwood
#25 interdiff-2895685.txt4.28 KBdawehner
#25 2895685-25.patch12.63 KBdawehner
#24 interdiff-2895685-23-24.txt5.84 KBprestonso
#24 2895685-24.patch12.25 KBprestonso
#23 interdiff-22-23.txt1.23 KBeffulgentsia
#23 2895685-23.patch11.46 KBeffulgentsia
#22 2895685-20.patch10.71 KBWim Leers
#20 2895685-20.patch6.9 KBWim Leers
#20 interdiff.txt1.84 KBWim Leers
#19 2895685-19.patch10.32 KBWim Leers
#19 interdiff.txt5.39 KBWim Leers
#18 interdiff-2895685-14-18.txt6.7 KBprestonso
#18 2895685-18.patch8.69 KBprestonso
#15 interdiff-12-14.txt1.03 KBmpdonadio
#15 2895685-14.patch3.73 KBmpdonadio
#13 rn-interdiff-12.txt1.58 KBxjm
#13 rn-2895685-12.patch3.72 KBxjm
#10 rn-interdiff-10.patch2.79 KBxjm
#10 rn-2895685-10.patch3.68 KBxjm
#8 rn-2895685-8.patch2.65 KBgnuget
#8 rn-2895685-5-8-interdiff.txt571 bytesgnuget
#5 rn-2895685-3.patch2.56 KBxjm
#2 8.4.0-2895685-2.txt2.23 KBxjm
8.4.0-release-notes-draft.txt922 bytesxjm
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

xjm created an issue. See original summary.

xjm’s picture

Status: Needs work » Needs review
FileSize
2.23 KB

Here's a better draft outline for the release notes with some tricky things explained (but most issues still missing). FWIW, I'm editing this in https://github.com/xjm/drupal_core_release/blob/master/templates/CHANGEL... (a github repository we use for automating release processes).

xjm’s picture

xjm’s picture

This adds the markdown format to the CHANGELOG file for now. We won't necessarily actually ship it this way; the past changelog is probably going to be removed and instead kept in a handbook page on d.o. However, I thought it would be easier to provide interdiffs this way.

xjm’s picture

Actually attaching the patch.

gnuget’s picture

I'm new on this, the Upgrade of Jquery to 1.12 should be included in the release notes? #2809427: Update jQuery UI to 1.12

xjm’s picture

@gnuget, yep for sure! I've added the "8.4.0 release notes" tag to that issue. Would you like to add an entry to the patch here for it under the third-party libraries section?

gnuget’s picture

Sure.

New patch attached.

Thanks!

xjm’s picture

Thanks @gnuget!

For IFE, @andrewmacpherson suggested we draw on #2888189: Update hook_help and DO docs for Inline Form Errors.

xjm’s picture

Adding a couple more stub sections, and improving the sections on Media and Datetime Range.

xjm’s picture

Phooey, named interdiff as a patch. Sorry testbot.

Status: Needs review » Needs work

The last submitted patch, 10: rn-interdiff-10.patch, failed testing. View results

xjm’s picture

Status: Needs work » Needs review
FileSize
3.72 KB
1.58 KB

A few more textual improvements for Media.

xjm’s picture

Here's stub markdown for the issues that are already tagged but not yet included in the patch:

## Unlisted fixed issues

(Move these bullets into the appropriate sections above and draft more descriptive text for them if appropriate.)

* [Allow custom default form cache expiration/lifetime](https://www.drupal.org/node/1286154)
* [Replace dblog recent log entries with a view](https://www.drupal.org/node/2015149)
* [Change Save and keep un-/published buttons to a Published checkbox and an included Save button](https://www.drupal.org/node/2068063)
* [EntityResource POST routes all use the confusing default: use entity types' https://www.drupal.org/link-relations/create link template if available](https://www.drupal.org/node/2293697)
* [Config export key order is not predictable for sequences, add orderby property to config schema](https://www.drupal.org/node/2361539)
* [Allow field types to enforce the cardinality](https://www.drupal.org/node/2403703)
* [When deleting a content type field, users do not realize the related View also is deleted](https://www.drupal.org/node/2468045)
* [Provide a lazy alternative to service collectors which just detects service IDs](https://www.drupal.org/node/2472337)
* [Bring phpunit bridge into drupal and use it for unit tests and simpletest to handle Deprecation](https://www.drupal.org/node/2488860)
* [Toolbar implementation creates super annoying re-rendering.](https://www.drupal.org/node/2542050)
* [Add #maxlength to textarea in Form API](https://www.drupal.org/node/2594553)
* [Support rect property and nested render arrays in html_tag for dynamic SVGs](https://www.drupal.org/node/2694535)
* [Asset library DX: Non-helpful fatal error if CSS isn't nested under an existing category](https://www.drupal.org/node/2705037)
* [Let TimestampItem (de)normalize to/from RFC3339 timestamps, not UNIX timestamps, for better DX](https://www.drupal.org/node/2768651)
* [Support migration of node reference field values from Drupal 6](https://www.drupal.org/node/2814949)
* [Adopt airbnb javascript style guide v13 as new baseline javascript coding standards for Drupal 8 core and contrib](https://www.drupal.org/node/2815077)
* [EntityNormalizer::denormalize should not throw UnexpectedValueException, but \\Symfony\\Component\\HttpKernel\\Exception\\UnprocessableEntityHttpException, so we get a 422 response instead of 400](https://www.drupal.org/node/2827084)
* [ResourceResponse(Subscriber) + Dynamic Page Cache: making authenticated ResourceResponses significantly faster](https://www.drupal.org/node/2827797)
* [Bring Media entity module to core as Media module](https://www.drupal.org/node/2831274)
* [Select entity type / bundle in workflow settings](https://www.drupal.org/node/2843083)
* [Improve timezones selector with optgroups](https://www.drupal.org/node/2847651)
* [Prepare our phpunit tests to be BC compatible with phpunit 5.x/6.x](https://www.drupal.org/node/2850797)
* [Make it easy to get typed config representations of entities](https://www.drupal.org/node/2869809)
* [Split the internal page cache from the rest of the render cache](https://www.drupal.org/node/2889603)
* [Update CKEditor library to 4.7.1](https://www.drupal.org/node/2893566)


## Unlisted criticals

(These issues are fixed critical issues for this branch. Check each to ensure that it is not fixed in the previous branch. (If it is, update its branch field to be the lowest branch it was backported to.) Move these bullets into the appropriate sections above and draft more descriptive text for them if appropriate.)

* [Forward revisions + translation UI can result in forked draft revisions](https://www.drupal.org/node/2766957)
* [Don't render status messages if there are no messages but also include their assets if there might be](https://www.drupal.org/node/2853509)
* [Path alias changes for draft revisions immediately leak into live site](https://www.drupal.org/node/2856363)
* [Book storage and UI is not revision aware, changes to drafts leak into live site](https://www.drupal.org/node/2858431)
* [Menu changes from node form leak into live site when creating draft revision](https://www.drupal.org/node/2858434)
* [EntityOperations::entityPresave doesn't always set the correct default revision](https://www.drupal.org/node/2862988)
* [ResourceTestBase should not have a timeout](https://www.drupal.org/node/2866056)
* [Optimise \\Drupal\\Core\\Extension\\ThemeHandler::refreshInfo() for the early installer](https://www.drupal.org/node/2872611)
* [Fatal DefaultSelection has colliding constructor definitions coming from traits on PHP 5.5.9](https://www.drupal.org/node/2881874)


## Unlisted open issues

(These issues are tagged for the release notes, but still open. Some issues might be tagged to highlight a certain outstanding bug in the release notes. Others might have been reopened for a backport or followup. Some might have been tagged prematurely or incorrectly. Check the issue carefully, and if appropriate, move these bullets into the appropriate sections above and draft more descriptive text. Check with a release manager if you are unsure.)

* [Prevent drupal from deleting temporary files](https://www.drupal.org/node/2801777)
* [User roles field access is inconsistent, users with 'administer users' permission can gain full access](https://www.drupal.org/node/2846365)
* [[upstream] CORS breaks form submission unless allowed origins includes site's own host](https://www.drupal.org/node/2853201)
* [Add orderby key to third party settings](https://www.drupal.org/node/2860531)
* [Drush 8.x doesn't install Drupal 8.4.x and Drush master doesn't install Drupal 8.3.x](https://www.drupal.org/node/2874827)
* [Config export key order for sequences: orderedby does not support cases where the order actually matters](https://www.drupal.org/node/2885368)

The script for this is in the core metrics repository: http://cgit.drupalcode.org/sandbox-xjm-core_metrics/tree/core_release/mi...
(For up-to-date data, someone with access must run the relevant query set on staging.)

mpdonadio’s picture

I swore I saved this...

Minor tweak to the DTR section. Hoping to get a better DT and DTR REST UX in 8.5.x, with some additional validators and normalizers.

xjm’s picture

Thanks @mpdonadio!

We also should add a similar mention for media (from #2835767: Media + REST: comprehensive test coverage for Media + MediaType entity types). Probably:

Similarly, the REST API for Media is not final and support for decoupled applications will be improved in a future release.

xjm’s picture

For this issue:
[Drush 8.x doesn't install Drupal 8.4.x and Drush master doesn't install Drupal 8.3.x](https://www.drupal.org/node/2874827)

It's already addressed by the first section of the release notes; we just need to link it.

prestonso’s picture

This patch categorizes the issues from the stubs in #14 into their respective sections and directly addresses #16 and #17.

There is still a lot of work to be done here; I flagged any issues that will need additional prose with a prepended asterisk, and issues that remain open are prepended with "(open)". I did my best to categorize things correctly, but this might need additional review.

Hopping back on this tomorrow to bring in necessary prose about major changes and to refine further.

Wim Leers’s picture

As the REST maintainer, I figured it'd make sense for me to write something for that section. From what the patch looks like so far, that's at least what I thought needed to be done. For REST, several issues were in the wrong bucket. One in REST belonged in config DX (closest bucket being DX improvements). One in performance & scalability belonged in REST, as well as one in DX improvements.
I also went over #2852860: REST: top priorities for Drupal 8.4.x to ensure I didn't miss anything. I decided to also tag #2846554: Make the PathItem field type actually computed and auto-load stored aliases, #2853300: Standardize fatal error/exception handling: backtrace for all formats, not just HTML, #2847708: RPC endpoint to reset user password

Wim Leers’s picture

@xjm asked me to add an entry for #2801777: Give users the option to prevent drupal from automatically marking unused files as temporary , which is the critical issue that introduced a stopgap solution to prevent files from being deleted unwantedly/unexpectedly.

Status: Needs review » Needs work

The last submitted patch, 20: 2895685-20.patch, failed testing. View results

Wim Leers’s picture

Status: Needs work » Needs review
FileSize
10.71 KB

The patch in #20 is wrong, the interdiff is right. This is the correct patch.

effulgentsia’s picture

Added a section for the changes to browser requirements.

prestonso’s picture

Fixed a few Markdown issues, converted "Content authoring and site administration improvements" into prose with change records, and added asm89/stack-cors to "Third-party library updates" section.

dawehner’s picture

The current changelog is a bit weird, given it mixes up general features and really specific issues. Is there a specific reason for this verbosity? There are a lot of small bugs listed, which, in case we take it serious, would have to expand even more?

Changes:

  • Added two entries for phpunit
  • Mentioned the comment view
  • Fixed some minor formatting details.
xjm’s picture

Status: Needs review » Needs work

Thanks everyone!

  1. +++ b/core/CHANGELOG.txt
    @@ -1,3 +1,202 @@
    +## Content authoring and site administration improvements
    ...
    +### Comment module
    +
    +* [#1986606: The comment administration page /admin/content/comment is a view now]
    

    Thanks @dawehner!

    Let's move the comment view up to the site admin improvements section.

  2. +++ b/core/CHANGELOG.txt
    @@ -1,3 +1,202 @@
    +## REST and API-first improvements
    +
    +* Authenticated REST API performance increased by 15% by utilizing the
    +  Dynamic Page Cache.
    +* POSTing entities can now happen at `/node`, `/taxonomy/term` and so on,
    +  instead of `/entity/node`, `/entity/taxonomy_term`. Instead of confusingly
    +  different URLs, they therefore now use the URLs you'd expect. Backwards
    +  compatibility is maintained. [Change record](https://www.drupal.org/node/2737401)
    +* Added dedicated resource for resetting a user's password.
    +* Time fields now are normalized to RFC3339 timestamps by default, fixing time
    +  time ambiguity. Existing sites continue to receive UNIX timestamps, but can
    +  opt in. [Change record](https://www.drupal.org/node/2859657)
    +* Path alias fields now are normalized too.
    +* When denormalization fails, a 422 response is now returned instead of 400,
    +  per the HTTP specification.
    +* With CORS enabled to allow origins besides the site's own host, submitting
    +  forms was broken unless the site's own host was also explicitly allowed.
    +* Fatal errors and exceptions now show a backtrace also for all non-HTML
    +  requests, which makes for far easier debugging and better bug reports.
    +* Massive expansion of the test coverage.
    +
    +* [#2293697: EntityResource POST routes all use the confusing default: use entity types' https://www.drupal.org/link-relations/create link template if available](https://www.drupal.org/node/2293697)
    +* [#2768651: Let TimestampItem (de)normalize to/from RFC3339 timestamps, not UNIX timestamps, for better DX](https://www.drupal.org/node/2768651)
    +* [#2827084: EntityNormalizer::denormalize should not throw UnexpectedValueException, but \Symfony\Component\HttpKernel\Exception\UnprocessableEntityHttpException, so we get a 422 response instead of 400](https://www.drupal.org/node/2827084)
    +* [#2827797: ResourceResponse(Subscriber) + Dynamic Page Cache: making authenticated ResourceResponses significantly faster](https://www.drupal.org/node/2827797)
    +* [#2846554: Make the PathItem field type actually computed and auto-load stored aliases](https://www.drupal.org/node/2846554)
    +* [#2847708: RPC endpoint to reset user password](https://www.drupal.org/node/2847708)
    +* [#2853300: Standardize fatal error/exception handling: backtrace for all formats, not just HTML](https://www.drupal.org/node/2853300)
    +* [#2853201: [upstream] CORS breaks form submission unless allowed origins includes site's own host](https://www.drupal.org/node/2853201)
    

    For the REST improvements, let's make each item link its issue. Right now it looks like the issues are in a separate list under the text descriptions, so it's just a matter of linking some of the text for the bullet to the relevant issue. (Probably this is just an accident.) If there are any bullets that don't have matching items, we should add them to the first list with their links.

  3. +++ b/core/CHANGELOG.txt
    @@ -1,3 +1,202 @@
    +* [#2361539: Config export key order is not predictable for sequences, add orderby property to config schema](https://www.drupal.org/node/2361539)
    ...
    +* (open) [#2860531: Add orderby key to third party settings](https://www.drupal.org/node/2860531)
    +* (open) [#2885368: Config export key order for sequences: "orderedby" does not support cases where the order actually matters](https://www.drupal.org/node/2885368)
    

    These three items should be under the aforementioned bug fixes section mentioned below. (They're data integrity issues.) We should describe the benefits of the first issue and link/summarize its change record, then explain that the second two are still open and what the effect of that is.

  4. +++ b/core/CHANGELOG.txt
    @@ -1,3 +1,202 @@
    +* [#2766957: Forward revisions + translation UI can result in forked draft revisions](https://www.drupal.org/node/2766957)
    ...
    +* [#2856363: Path alias changes for draft revisions immediately leak into live site](https://www.drupal.org/node/2856363)
    +* [#2858431: Book storage and UI is not revision aware, changes to drafts leak into live site](https://www.drupal.org/node/2858431)
    +* [#2862988: EntityOperations::entityPresave doesn't always set the correct default revision](https://www.drupal.org/node/2862988)
    

    These should be under a section above "New stable modules" for "Important bugfixes since 8.3.x". I'd make it one paragraph something like: "This release includes numerous data integrity bug fixes for revision data, including... These fixes improve revision support for both stable features and the experimental Content Moderation module. ([See below for additional experimental Content Moderation improvements](link).)

  5. +++ b/core/CHANGELOG.txt
    @@ -1,3 +1,202 @@
    +The new core [Media module](https://www.drupal.org/node/2895059) provides an
    ...
    +Entity, the top priority for this release is to provide a stable core API and
    +data model for a smoother transition for these modules. Developers and expert
    ...
    +* [#2831274: Bring Media entity module to core as Media module](https://www.drupal.org/node/2831274)
    

    Ah I see what's going on here. There are two issues, the initial main patch and the issue to mark it stable. Let's link the original issue in the first sentence instead, and link the second issue where it says "provide a stable core API and data model" in the second paragraph.

  6. +++ b/core/CHANGELOG.txt
    @@ -1,3 +1,202 @@
    +* [#2472337: Provide a lazy alternative to service collectors which just detects service IDs](https://www.drupal.org/node/2472337)
    

    On the issue, effulgentsia tagged it because it could be used for performance improvements, so let's move it to the performance section.

  7. Something we can do in general is describe the importance of each issue. In many cases the comment where the issue was tagged will indicate why (so we can check each issue link). Otherwise the CR should provide a clear explanation.
xjm’s picture

+++ b/core/CHANGELOG.txt
@@ -1,3 +1,202 @@
+* [#2594553: Add #maxlength to textarea in Form API](https://www.drupal.org/node/2594553)

I untagged this one, because I don't think it's quite important enough for a release notes mention. The CR should be sufficient. So we can remove it here as well.

xjm’s picture

Oh @dawehner, I agree in general that we should only mention the important issues. If there are any that seem not worth mentioning, could you highlight those? Then we can either untag them, or better explain their significance.

dawehner’s picture

At least for me CHANGELOG.txt seems to be a high level overview, rather a list of change records. Maybe a general paragraph like:

For a list of API changes/additions, please have a look at the change records.

Here is a list of stuff which is a bit meh.

+* Options in timezones selector [are now grouped by regions](https://www.drupal.org/node/2847651)
+  and represent cities instead of timezone names.

This feels like a minor change, but maybe I'm totally wrong.

+
+## REST and API-first improvements
+
+* When denormalization fails, a 422 response is now returned instead of 400,
+  per the HTTP specification.
+* With CORS enabled to allow origins besides the site's own host, submitting
+  forms was broken unless the site's own host was also explicitly allowed.
+* Fatal errors and exceptions now show a backtrace also for all non-HTML
+  requests, which makes for far easier debugging and better bug reports.
+* Massive expansion of the test coverage.
+
+* [#2827084: EntityNormalizer::denormalize should not throw UnexpectedValueException, but \Symfony\Component\HttpKernel\Exception\UnprocessableEntityHttpException, so we get a 422 response instead of 400](https://www.drupal.org/node/2827084)
+* [#2853300: Standardize fatal error/exception handling: backtrace for all formats, not just HTML](https://www.drupal.org/node/2853300)
+* [#2853201: [upstream] CORS breaks form submission unless allowed origins includes site's own host](https://www.drupal.org/node/2853201)
+

These issues seem to be bug fixes, which are of course nice to see fixed, but it feels like to be on the same order of magnitude as probably hundred other bug fixes.

+## Performance and scalability improvements
+
+* [#2853509: Don't render status messages if there are no messages but also include their assets if there might be](https://www.drupal.org/node/2853509)
+* [#2872611: Optimise \Drupal\Core\Extension\ThemeHandler::refreshInfo() for the early installer](https://www.drupal.org/node/2872611)
+

Same comment as above.

+## Developer experience improvements
+
+* [#2403703: Allow field types to enforce the cardinality](https://www.drupal.org/node/2403703)
+* [#2472337: Provide a lazy alternative to service collectors which just detects service IDs](https://www.drupal.org/node/2472337)
+* [#2694535: Support rect property and nested render arrays in html_tag for dynamic SVGs](https://www.drupal.org/node/2694535)
+* [#2705037: Asset library DX: Non-helpful fatal error if CSS isn't nested under an existing category](https://www.drupal.org/node/2705037)
+* [#2869809: Make it easy to get typed config representations of entities](https://www.drupal.org/node/2869809)
fffffffffffffffffffffffffffff+* (open) [#2860531: Add orderby key to third party settings](https://www.drupal.org/node/2860531)
+* (open) [#2885368: Config export key order for sequences: "orderedby" does not support cases where the order actually matters](https://www.drupal.org/node/2885368)
+

Many of those feels like good for change records, but not necessarily for a CHANGELOG.txt. Keep in mind that the bigger the changelog is, the less important media and the other experimental module improvements seems to be.

timmillwood’s picture

FileSize
2.25 KB
13.85 KB

Added a bunch of workflows/content moderation issues.

xjm’s picture

At least for me CHANGELOG.txt seems to be a high level overview, rather a list of change records. Maybe a general paragraph like:

For a list of API changes/additions, please have a look at the change records.
Here is a list of stuff which is a bit meh.

Yes, the release notes always include this. Those standard paragraphs are not included in the draft here but will be in the release notes themselves.

xjm’s picture

* Options in timezones selector [are now grouped by regions](https://www.drupal.org/node/2847651)
+  and represent cities instead of timezone names.

This feels like a minor change, but maybe I'm totally wrong.

For this one, the usability and accessibility contributors involved were very excited about this change, so that seems reason to include it I guess.

I'll ask the people who tagged the other issues to weigh in on why they proposed them for inclusion. Thanks!

xjm’s picture

Oh on this one:
+* (open) [#2885368: Config export key order for sequences: "orderedby" does not support cases where the order actually matters](https://www.drupal.org/node/2885368)

See #26.3; it's included because it's a pending followup related to an important config change. So it's not going to be mentioned on its own.

xjm’s picture

For my and others' convenience, here are the remaining issues we're discussing whether to untag:

  1. #2827084: EntityNormalizer::denormalize should not throw UnexpectedValueException, but \Symfony\Component\HttpKernel\Exception\UnprocessableEntityHttpException, so we get a 422 response instead of 400 tagged by alexpott
  2. #2853300: Standardize fatal error/exception handling: backtrace for all formats, not just HTML tagged by Wim Leers
  3. #2853201: [upstream] CORS breaks form submission unless allowed origins includes site's own host tagged by alexpott
  4. #2853509: Don't render status messages if there are no messages but also include their assets if there might be un-backported critical, so included for that reason. Should go under the "important bugfixes" section.
  5. #2872611: Optimise \Drupal\Core\Extension\ThemeHandler::refreshInfo() for the early installer un-backported critical and should go under the "important bugfixes" section.
  6. #2403703: Allow field types to enforce the cardinality tagged by alexpott
  7. #2472337: Provide a lazy alternative to service collectors which just detects service IDs tagged by effulgentsia:

    Tagging for release notes mention, since this is a new tool that developers can leverage for performance optimizing.

  8. #2694535: Support rect property and nested render arrays in html_tag for dynamic SVGs tagged by Manuel Garcia
  9. #2705037: Asset library DX: Non-helpful fatal error if CSS isn't nested under an existing category tagged by Wim Leers:

    This will make such a huge DX difference. Tentatively tagging 8.4.0 release notes.

  10. #2869809: Make it easy to get typed config representations of entities tagged by alexpott

Edit: Updated with who tagged them and any explanation given.

prestonso’s picture

Assigned: Unassigned » prestonso

Working actively on a new patch taking into account all the commentary since last patch. Assigning to myself.

prestonso’s picture

Progress with intervening comments fully (#27, #33) or partially (#25, #26) addressed.

All issues except bugfixes in the "Important bugfixes since 8.3.x" section have initial draft descriptions alongside. Still remaining:

  • Flesh out "Important bugfixes since 8.3.x" section
  • Address empty sections without issues tagged "8.4.0 release notes"
  • Reorder or eliminate issues based on relative impact and need for inclusion in release notes.
tim.plunkett’s picture

Field Layout
- Only minor bug fixes from 8.3.x to 8.4.x, nothing worth noting

Layout Discovery
- Minor bug fixes
- #2885877: Add support for per-region attributes to Layout Templates, probably not worth calling out
- Marked as stable

Place Block
- Minor bug fix
- #2898267: Mark Place Block as a hidden module marks the module as hidden

drpal’s picture

+++ b/core/CHANGELOG.txt
@@ -1,3 +1,247 @@
+* [Adopted Airbnb JavaScript style guide 14.1] as the new baseline set of

I don't think we should specify a version here. We're already a major version behind and there's an issue to update it, #2878620: Update AirBnB Coding standards to most recent major versions.

prestonso’s picture

Fills out "Important bug fixes since 8.3.x" section with configuration and Content Moderation issues. Addresses #26, #38, and #39.

Currently working with @heddn on the last remaining empty section around Migrate, Migrate Drupal, and Migrate Drupal UI.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

DyanneNova’s picture

Adds some notes for Settings Tray. I'm currently working on looking through the queue and adding more.

andypost’s picture

mpdonadio’s picture

Version: 8.5.x-dev » 8.4.x-dev
xjm’s picture

  1. +++ b/core/CHANGELOG.txt
    @@ -1,3 +1,294 @@
    +## Note for Drush users: Update to Drush 8.1.12
    

    I guess we can remove the words "Note for" here.

  2. +++ b/core/CHANGELOG.txt
    @@ -1,3 +1,294 @@
    +## Note for sites using file uploads
    

    This is most sites, so I would put this under "Important bugfixes in this release". I'd also add a paragraph to the effect that the file usage bugs themselves are still outstanding and discussion on how to evolve the file usage tracking system is underway in #2821423: Dealing with unexpected file deletion due to incorrect file usage.

  3. +++ b/core/CHANGELOG.txt
    @@ -1,3 +1,294 @@
    +## Note about browser requirements
    

    Let's change this to "Updated browser requirements: Internet Explorer 9 and 10 no longer supported".

  4. +++ b/core/CHANGELOG.txt
    @@ -1,3 +1,294 @@
    +* [#2361539: Config export key order is not predictable for sequences, add orderby property to config schema](https://www.drupal.org/node/2361539)
    +  resolves an issue where sequences in configuration were not sorted unless
    +  the code responsible for saving configuration explicitly performed a sort.
    

    "...resulting in unpredictable changes in the ordering of configuration and confusing diffs even when nothing had changed."

  5. +++ b/core/CHANGELOG.txt
    @@ -1,3 +1,294 @@
    +  This bug fix [adds an `orderby` key in the config schema definition](https://www.drupal.org/node/2852566).
    

    "To resolve this issue, we've [added an `orderby` key to the config schema] that allows it to be sorted either by key or by value. Adding a preferred sort is strongly recommended.

prestonso’s picture

Status: Needs work » Needs review
FileSize
18.77 KB
6.91 KB

This patch:

Still outstanding; will tackle tomorrow:

  • Verify all issues tagged "8.4.0 release notes" have been either considered or included.
  • Reorder or eliminate issues based on relative impact and need for inclusion in release notes.
  • Ensure all sections match in formatting and style.
  • Check if any CRs are not included with their corresponding issues.
xjm’s picture

Here's the latest from my script

## Unlisted fixed issues

(Move these bullets into the appropriate sections above and draft more descriptive text for them if appropriate.)

* [Adopt airbnb javascript style guide v14.1 as new baseline javascript coding standards for Drupal 8 core and contrib](https://www.drupal.org/node/2815077)


## Unlisted criticals

(These issues are fixed critical issues for this branch. Check each to ensure that it is not fixed in the previous branch. (If it is, update its branch field to be the lowest branch it was backported to.) Move these bullets into the appropriate sections above and draft more descriptive text for them if appropriate.)

* [EntityOperations::entityPresave doesn't always set the correct default revision](https://www.drupal.org/node/2862988)
* [Fatal DefaultSelection has colliding constructor definitions coming from traits on PHP 5.5.9](https://www.drupal.org/node/2881874)
effulgentsia’s picture

#47.1 hasn't been committed yet, so I'm guessing doesn't need a changelog.txt entry yet?

This patch adds for #47.4 and #47.5.

#46, #47.2, and #47.3 are not yet addressed.

xjm’s picture

Assigned: prestonso » xjm
Status: Needs review » Postponed

We're iterating on these in real time in a Google doc. We'll resume this issue for 8.4.0 after the alpha ships. Thanks everyone!

xjm’s picture

Assigned: xjm » Unassigned
Status: Postponed » Needs review
FileSize
115 bytes

Alright, the attached is the result of hours of work by @prestonso, @webchick, and myself. I've proofread all but the following sections:

## REST and API-first improvements
## Performance and scalability improvements
## Developer experience improvements
## Automated testing improvements
## Third-party library updates
### Migrate Drupal and Migrate Drupal UI

No interdiff since we changed pretty much every line in one way or another.

Status: Needs review » Needs work

The last submitted patch, 50: changelog-2895685-50.patch, failed testing. View results

xjm’s picture

Status: Needs work » Needs review
FileSize
25.64 KB

/facepalm

xjm’s picture

xjm’s picture

For both Workflows and Content Moderation, we should add a section like:

"This module has significant backwards compatbility and data model breaks from early experimental versions. (As experimental modules, they do not officially require a a stable data model or backwards-compatible APIs.) However, unnofficial upgrade paths are available in #2890187: [META] Unofficial content_moderation upgrade path. Now that both these modules in beta, after 8.4.0-beta1 with its final breaks, users can expect backwards compatibility and officially supported upgrade paths from now on.

xjm’s picture

Oh and it still needs review for accuracy and clarity, especially the sections I listed in my comment in #50.

xjm’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
26.37 KB
26.37 KB

Okay, here's the finalish version we're using for the alpha.

If you have additions to make as we go through the beta and RC toward 8.4.0, please make sure the issue is tagged with "8.4.0 release notes" and feel free to add your additions here!

  • xjm committed cd2e324 on 8.4.x
    Issue #2895685 by xjm, prestonso, Wim Leers, effulgentsia, gnuget,...

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 56: changelog-2895685-56.patch, failed testing. View results

xjm’s picture

Status: Needs work » Needs review

Yes, that's because I committed it.

The last submitted patch, 41: 2895685-41.patch, failed testing. View results

The last submitted patch, 52: changelog-2895685-51.patch, failed testing. View results

  • xjm committed 4b81a59 on 8.4.x
    Issue #2895685 followup by Wim Leers: Correct a few CHANGELOG entries.
    

  • xjm committed e5cbae7 on 8.4.x
    Issue #2895685 followup by xjm: Add references to string changes and...

  • xjm committed 57bbd95 on 8.4.x
    Issue #2895685 followup by xjm: Fix header levels for display on release...
jibran’s picture

All the commits which are in 8.4.x and not backported to 8.3.x git log --oneline --reverse --no-merges --cherry-pick --right-only origin/8.3.x...origin/8.4.x. I think this also helps us finding new issues.

cilefen’s picture

As we are working on the beta1 release notes right now, the idea has been the beta1 notes should contain just the updates since alpha1. That's ok, and that's what we would usually put on drupal.org. But, what goes in CHANGELOG.txt at beta1? It would be something different than what we would put on drupal.org because CHANGELOG.txt should contain what is building up to be the 8.4.0 notes. In other words: notes about alpha1 + beta1. Any ideas?

xjm’s picture

Thanks @jibran; I spent a bunch of time trying to get a good git command but never found one that worked quite as needed. I'll check that one out.

For the changelog, I don't think we need to commit an update until the minor. Committing the initial draft for the alpha was just an experiment.

However, we could definitely use subject matter experts' help supplying patches on this issue to add to it with additional improvements since alpha1!

Gábor Hojtsy’s picture

I started processing issues since alpha1 but indeed, subject matter experts would have a MUCH easier time. I think the ones I did not mark with a @todo I figured out fine but I failed at some things. Also this is just a start of processing the issues since alpha1, not all of them are added yet.

xjm’s picture

Here's the issues that are tagged but not yet included in #68:

## Unlisted fixed issues

(Move these bullets into the appropriate sections above and draft more descriptive text for them if appropriate.)

* [Orphaned menu links when nodes are deleted if menu_link_ui is not enabled](https://www.drupal.org/node/2350797)
* [Clearing cache via UI in translated language resets config translation of field labels to default language](https://www.drupal.org/node/2650434)
* [The Page Title block's title behaves in a confusing way with Settings Tray and the Help block incorrectly has Settings Tray styling](https://www.drupal.org/node/2782891)
* [Break BrowserTestBase & children dependency on Simpletest, deprecate stub BC traits](https://www.drupal.org/node/2803621)
* [Convert Migrate's cckfield plugins to use the new field plugins](https://www.drupal.org/node/2833206)
* [[policy, no patch] Drop IE9 and IE10 support from Drupal 8.4.x](https://www.drupal.org/node/2842298)
* [BaseFieldOverride entities created by content_translation break content_moderation because they don't support computed fields](https://www.drupal.org/node/2848775)
* [fastcgi_finish_request and shutdown functions (e.g. batch) do not play nicely together](https://www.drupal.org/node/2851111)
* [Rewrite the 'Latest revision' views filter and remove the revision_tracker table](https://www.drupal.org/node/2865579)
* [Non-persistent fields become unpurgeable zombies without their target entity type](https://www.drupal.org/node/2884202)
* [Update CKEditor library to 4.7.1](https://www.drupal.org/node/2893566)
* [Prevent enabling the media module if media_entity contrib 1.x is already enabled](https://www.drupal.org/node/2896427)
* [Provide the 'revision_translation_affected' base field by default for all revisionable and translatable entity types](https://www.drupal.org/node/2896845)
* [Mark workflows module as stable](https://www.drupal.org/node/2897130)
* [Add filters to the comments administration pages](https://www.drupal.org/node/2898344)
* [Update jquery-once to latest release](https://www.drupal.org/node/2899156)
* [Specify minimum phpspec/prophecy version in core/composer.json](https://www.drupal.org/node/2900800)


## Unlisted criticals

(These issues are fixed critical issues for this branch. Check each to ensure that it is not fixed in the previous branch. (If it is, update its branch field to be the lowest branch it was backported to.) Move these bullets into the appropriate sections above and draft more descriptive text for them if appropriate.)

* [Orphaned menu links when nodes are deleted if menu_link_ui is not enabled](https://www.drupal.org/node/2350797)
* [Database cache bins allow unlimited growth: cache DB tables of gigabytes!](https://www.drupal.org/node/2526150)
* [fastcgi_finish_request and shutdown functions (e.g. batch) do not play nicely together](https://www.drupal.org/node/2851111)
* [Non-persistent fields become unpurgeable zombies without their target entity type](https://www.drupal.org/node/2884202)
* [Refactor D7 FieldInstance source plugin and other field instance related source plugins](https://www.drupal.org/node/2891935)
* [Create a ProcessField plugin to process the field types](https://www.drupal.org/node/2893061)
* [Random segfault currently in FileFieldWidgetTest::testMultiValuedWidget()](https://www.drupal.org/node/2898721)
* [Fatal error when saving a node type without content moderation](https://www.drupal.org/node/2900687)
* [CSS animations cause \\Drupal\\Tests\\outside_in\\FunctionalJavascript\\OutsideInBlockFormTest random fails](https://www.drupal.org/node/2901626)


## Unlisted open issues

(These issues are tagged for the release notes, but still open. Some issues might be tagged to highlight a certain outstanding bug in the release notes. Others might have been reopened for a backport or followup. Some might have been tagged prematurely or incorrectly. Check the issue carefully, and if appropriate, move these bullets into the appropriate sections above and draft more descriptive text. Check with a release manager if you are unsure.)

* [Only having one default revision per entity forces translations to be kept in sync](https://www.drupal.org/node/2860097)
* [Unofficial content_moderation 8.3.7 to 8.4.0 upgrade path](https://www.drupal.org/node/2896630)
* [Update CKEditor library to 4.7.3](https://www.drupal.org/node/2908864)


And the release notes for the beta and RC:
https://www.drupal.org/project/drupal/releases/8.4.0-beta1
https://www.drupal.org/project/drupal/releases/8.4.0-rc1

Gábor Hojtsy’s picture

  • Moved workflows to the stable modules.
  • Added a two line paragraph to the workflows section about standalone use.
  • Updated settings tray to beta.

I think this reflects the current experimental module statuses well. Did not yet add any new issues to the patch.

Gábor Hojtsy’s picture

Processed the unlisted open issues. In #2860097: Ensure that content translations can be moderated independently @timmillwood argues that is not a regression to list but a task to do. Nothing happened in #2908864: Update CKEditor library to 4.7.3 yet, not sure that is still feasible before 8.4.0? Integrated the only one open issue left. Moving on to the other sections.

Status: Needs review » Needs work

The last submitted patch, 71: 2895685-71.patch, failed testing. View results

Gábor Hojtsy’s picture

Assigned: Unassigned » Gábor Hojtsy
xjm’s picture

  1. +++ b/core/CHANGELOG.txt
    @@ -153,6 +155,23 @@ and polished enough for production use. See the core
    +While the module can be installed as-is, it is not useful in itself without
    +either Content Moderation and/or some other module that requires it.
    

    Here, I think we should say "...it is not useful in itself without Content Moderation (still considered experimental for this release) or some other module that extends it."

  2. +++ b/core/CHANGELOG.txt
    @@ -321,21 +343,9 @@ Drupal versions.
    +* Field type mapping became easier with ¶
    

    Minor: trailing space.

  3. +++ b/core/CHANGELOG.txt
    @@ -357,6 +367,10 @@ stable in time for 8.4.0! Notable improvements in this release:
    +As per the experimental module process, there were some backwards incompatible
    

    It should be hyphenated as "backwards-incompatible", but maybe we could be more direct and say "backwards compatibility breaks from Drupal 8.3.x". And in addition to the upgrade path, maybe we can link them something that shows what the BC breaks are? I imagine it's some list of change records. Also, maybe we should move this paragraph to above the list of specific improvements as it's pretty important information.

Gábor Hojtsy’s picture

Status: Needs work » Needs review
FileSize
9.78 KB
3.3 KB

Processed the missing critical issues. I contest inclusion of the last three.

Theoretically I added all other criticals from your list @xjm. Your unlitsed fixed issues list also includes unlisted fixed criticals, so after deduping, only these seem to be left from that list:

* [Clearing cache via UI in translated language resets config translation of field labels to default language](https://www.drupal.org/node/2650434)
* [The Page Title block's title behaves in a confusing way with Settings Tray and the Help block incorrectly has Settings Tray styling](https://www.drupal.org/node/2782891)
* [Break BrowserTestBase & children dependency on Simpletest, deprecate stub BC traits](https://www.drupal.org/node/2803621)
* [Convert Migrate's cckfield plugins to use the new field plugins](https://www.drupal.org/node/2833206)
* [[policy, no patch] Drop IE9 and IE10 support from Drupal 8.4.x](https://www.drupal.org/node/2842298)
* [BaseFieldOverride entities created by content_translation break content_moderation because they don't support computed fields](https://www.drupal.org/node/2848775)
* [Rewrite the 'Latest revision' views filter and remove the revision_tracker table](https://www.drupal.org/node/2865579)
* [Prevent enabling the media module if media_entity contrib 1.x is already enabled](https://www.drupal.org/node/2896427)
* [Provide the 'revision_translation_affected' base field by default for all revisionable and translatable entity types](https://www.drupal.org/node/2896845)
* [Add filters to the comments administration pages](https://www.drupal.org/node/2898344)
* [Update jquery-once to latest release](https://www.drupal.org/node/2899156)
* [Specify minimum phpspec/prophecy version in core/composer.json](https://www.drupal.org/node/2900800)

Integrated this too:

* [Mark workflows module as stable](https://www.drupal.org/node/2897130)

Removing the tag from this one because this is superseded by the also committed #2904142: Update CKEditor library to 4.7.2

* [Update CKEditor library to 4.7.1](https://www.drupal.org/node/2893566)
Nebel54’s picture

+++ b/core/CHANGELOG.txt
@@ -92,6 +94,21 @@ is underway.
+ensures that (the current batch state is written completely to the database before starting the next batch)[https://www.drupal.org/node/2851111].

Sorry, flipped the brackets [] and () when linking the issue...

Should be:

A race condition occured in the Batch API when using fastcgi. The Batch API now ensures that [the current batch state is written completely to the database before starting the next batch](https://www.drupal.org/node/2851111).

Gábor Hojtsy’s picture

Fixed that and two whitespace issues at end of lines.

Gábor Hojtsy’s picture

Status: Needs review » Needs work

The last submitted patch, 78: 2895685-78.patch, failed testing. View results

xjm’s picture

Status: Needs work » Needs review
xjm’s picture

Latest script output:

## Unlisted fixed issues

(Move these bullets into the appropriate sections above and draft more descriptive text for them if appropriate.)

* [Clearing cache via UI in translated language resets config translation of field labels to default language](https://www.drupal.org/node/2650434)
* [The Page Title block's title behaves in a confusing way with Settings Tray and the Help block incorrectly has Settings Tray styling](https://www.drupal.org/node/2782891)
* [Break BrowserTestBase & children dependency on Simpletest, deprecate stub BC traits](https://www.drupal.org/node/2803621)
* [BaseFieldOverride entities created by content_translation break content_moderation because they don't support computed fields](https://www.drupal.org/node/2848775)
* [Rewrite the 'Latest revision' views filter and remove the revision_tracker table](https://www.drupal.org/node/2865579)
* [Prevent enabling the media module if media_entity contrib 1.x is already enabled](https://www.drupal.org/node/2896427)
* [Provide the 'revision_translation_affected' base field by default for all revisionable and translatable entity types](https://www.drupal.org/node/2896845)
* [Update non-Symfony dependencies in lock file before 8.4.0](https://www.drupal.org/node/2900112)
* [Again update non-Symfony dependencies in lock file before 8.4.0](https://www.drupal.org/node/2909743)

## Unlisted criticals

(These issues are fixed critical issues for this branch. Check each to ensure that it is not fixed in the previous branch. (If it is, update its branch field to be the lowest branch it was backported to.) Move these bullets into the appropriate sections above and draft more descriptive text for them if appropriate.)

* [Redirects for translation set migration path in Drupal 6 and 7](https://www.drupal.org/node/2850085)
* [Migration for forum and article comments: duplicate comment types and incorrect comment_entity_statistics](https://www.drupal.org/node/2853872)
* [Fatal error when saving a node type without content moderation](https://www.drupal.org/node/2900687)
* [CSS animations cause \\Drupal\\Tests\\outside_in\\FunctionalJavascript\\OutsideInBlockFormTest random fails](https://www.drupal.org/node/2901626)
* [Determine cause and fix random fail in \\Drupal\\Tests\\settings_tray\\FunctionalJavascript\\SettingsTrayBlockFormTest::testBlocks](https://www.drupal.org/node/2902191)
* [File migration from D6 to D8 version using Migrate Drupal UI](https://www.drupal.org/node/2907233)
* [Orphaned menu routes breaking site installs and module uninstalls](https://www.drupal.org/node/2907654)


## Unlisted open issues

(These issues are tagged for the release notes, but still open. Some issues might be tagged to highlight a certain outstanding bug in the release notes. Others might have been reopened for a backport or followup. Some might have been tagged prematurely or incorrectly. Check the issue carefully, and if appropriate, move these bullets into the appropriate sections above and draft more descriptive text. Check with a release manager if you are unsure.)

* [Update CKEditor library to 4.7.3](https://www.drupal.org/node/2908864)


xjm’s picture

Assigned: Gábor Hojtsy » xjm

Making some edits.

Gábor Hojtsy’s picture

Added #2850085: Redirects for translation set migration path in Drupal 6 and 7. Tried unassigning so you can do it @xjm, but then needed to step away and the form stopped submitting in the crosspost, sorry.

xjm’s picture

Attached:

  • Incorporates some of the missing items.
  • Updates the "known issues" section from changes added since the alpha.
  • Removes a couple issues I untagged.
  • Rewraps some lines.

There are still a couple marked with @todo and others missing. We probably also should still remove some of the unneeded items for Migrate and Settings Tray in particular since both are quite long.

xjm’s picture

Attached rewraps a lot more lines that were miswrapped with links (the closing ] for the text and the opening ( for the link need to be on the same line, but other than that they can wrap normally.

I also consolidated some more points on Migrate API changes and changed the remaining @todo bits into actual links.

  • xjm committed 047d5cb on 8.4.x
    Issue #2895685 by xjm, Gábor Hojtsy, prestonso, Wim Leers, effulgentsia...
xjm’s picture

Committed that since it made the interdiff basically unreadable. That still leaves all these:

* [Clearing cache via UI in translated language resets config translation of field labels to default language](https://www.drupal.org/node/2650434)
* [The Page Title block's title behaves in a confusing way with Settings Tray and the Help block incorrectly has Settings Tray styling](https://www.drupal.org/node/2782891)
* [Break BrowserTestBase & children dependency on Simpletest, deprecate stub BC traits](https://www.drupal.org/node/2803621)
* [BaseFieldOverride entities created by content_translation break content_moderation because they don't support computed fields](https://www.drupal.org/node/2848775)
* [Rewrite the 'Latest revision' views filter and remove the revision_tracker table](https://www.drupal.org/node/2865579)
* [Prevent enabling the media module if media_entity contrib 1.x is already enabled](https://www.drupal.org/node/2896427)
* [Provide the 'revision_translation_affected' base field by default for all revisionable and translatable entity types](https://www.drupal.org/node/2896845)
* [Update non-Symfony dependencies in lock file before 8.4.0](https://www.drupal.org/node/2900112)
* [Again update non-Symfony dependencies in lock file before 8.4.0](https://www.drupal.org/node/2909743)

xjm’s picture

Alright, I summarized a bunch of Settings Tray fixes in a single paragraph, and then added in the rest as stubs.

xjm’s picture

Incorporating the bit about the media_entity contrib module.

cilefen’s picture

Added more library update details and some words on the translated cache-clear bug, and the BrowserTestBase/Simpletest dependency.

catch’s picture

Status: Needs review » Needs work

The last submitted patch, 91: create_release_notes-2895685-91.patch, failed testing. View results

xjm’s picture

Status: Needs work » Needs review
FileSize
7.95 KB
2.05 KB

Building off #91 and moving the revision_translation_affected issue up after the one that spawned it, since it's not in itself specific to Content Moderation.

  • xjm committed 5f97d64 on 8.4.x
    Issue #2895685 by cilefen, catch, xjm: Finalize release notes.
    

  • xjm committed 0ed54ff on 8.4.x
    Issue #2895685 followup by xjm: Remove outdated CHANGELOG references to...
xjm’s picture

Assigned: xjm » Unassigned
Status: Needs review » Fixed

All done. Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.