Closed (won't fix)
Project:
Drupal core
Version:
8.9.x-dev
Component:
javascript
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 Jan 2010 at 20:46 UTC
Updated:
23 Feb 2021 at 13:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mfer commentedComment #2
casey commentedNeeds a reroll.
Comment #3
nod_Comment #4
nod_need reroll
Comment #5
nod_tag
Comment #6
giammi commentedtrying the reroll
Comment #7
giammi commentedneeds review
Comment #8
realityloop commentedcurrent version in core is v1.4.0
current version in core is 1.2.3
has been removed
Ad
Comment #9
realityloop commentedRerolled as per #8
Also added additional jquery libraries that weren't mentioned
Comment #10
rhysmdnz commentedHi, I'm in high school and this is my first contribution to Drupal Core. I updated the version numbers of the JavaScript libraries to match what is currently in core. Attached is the patch and interdiff.
Comment #11
wim leersLooks great, thank you! :)
Comment #12
alexpottThis needs updating - as of today :(
Comment #13
wim leersIndeed, #2403269: Update to jQuery UI 1.11.2 bumped the version to 1.11.2.
Comment #14
alexpottAlso I think we should be adding #2396307: Update JS lib: html5shiv to 3.7.2
Comment #15
rhysmdnz commentedUpdated jQuery UI version number and added html5shiv
Comment #16
jamesharv commentedAdded full stops at the end of some lines where missing. Increased the version of jQuery UI Touch Punch to 0.2.3 as per #2409121: Update jQuery Touch Punch library to 0.2.3
Comment #17
nod_Comment #18
nod_Versions of js libs needs to be updated.
Comment #19
googletorp commentedRerolled the patch and updated version numbers.
Comment #20
nod_Wrong interdiff :D
Actually since we'll update libs a couple of times before realease let's postpone, sorry to make you roll that.
Comment #21
nod_Let's try now.
Comment #22
sdstyles commentedUpdated.
Comment #26
dimaro commentedNeeds reroll against 8.1.x but what is the status of this issue?
Comment #27
swarad07Rerolling the patch in #22.
Comment #28
swarad07Also the interdiff.
Comment #29
chrowe commentedComment #30
droplet commentedNeed to remove all non-JS changes :)
Comment #31
swarad07Hi droplet,
Can you elaborate on what do you mean by "Need to remove all non-JS changes"?
Comment #32
mohit_aghera commented@droplet
Updating patch as per your suggestion.
I have rearranged Tremendously improved language support all around: text and moved below javascript changes.
Comment #35
wturrell commentedChanges:
- Remove any text that's essentially marketing.
- Fix capitalisation.
- Group all the updated libraries together first.
- Then the new ones.
- Finally the one removed at bottom (and explain what it is)
Comment #36
andypostComment #37
kwoxer commentedI checked all the versions in my local 8.0.-dev branch:
So the patch is wrong. Please fix the patch with changing:
jQuery Once 2.0.2 to jQuery Once v2.1.1.
Comment #38
kwoxer commentedComment #39
kwoxer commentedAlso tested the 8.4.0-dev branch and there is nothing about jQuery 3.2.1 for instance. So also add information about those change there I would say.
8.3.0-dev seems to be fine.
Comment #44
nod_This file now points to the change notice page.