Add changelog for Drupal 8.3.0

This #1446932: Improve statistics performance by adding a swappable backend seems quite relevant for performance and scalability.

I just now committed #2796173: Add experimental Field Layout module to allow entity view/form modes to switch between layouts

Updated with Field Layout module. Also removing extra whitespace that should not be there. I think while this needs work, the more appropriate status may be needs review, since it also need to get stuff identified to add :)

It seems like the interdiff in #5 is not based on #3 because some items have been removed but aren't displayed in the interdiff.

Fixing #6.

Wups, sorry I thought I was using the latest patch :/ @timmillwood: are the content moderation/workflow items well represented? Any other major change that should be here (and in the release notes?)

I don't think there are any major changes, but here's a summary of some and you can choose if they're worth adding:
- Moderation now works on non-translatable entity type.
- Moderation can be enabled on entity types without a bundle (but not via the UI).
- EntityPublishedInterface and EntityPublishedTrait have been added and are being used by Node and Comment
- originalRevisionId property has been added to revisionable entities and is populated with previous revision ID when the ID is updated.
- When setting an entity to published it now gets published (as long as the entity implements EntityPublishedInterface) this only used to work for Nodes.
- Better handling of errors when trying to bulk (un)publish moderated entities.
- When reverting to a previous revision the moderation state now gets reverted too.

@timmillwood: most of those sound like worthy improvements to mention to me. Similar to how we recited such improvements for REST earlier. Eg. mentioning the new published interface would help people adopt it. This one sounds the most obscure, but the others could IMHO be fleshed out a bit to include in the changelog:

Better handling of errors when trying to bulk (un)publish moderated entities.

#1999722: [policy] Define coding standards for anonymous functions (closures) should also go into the coding standards list.

Some small improvement.

Adding some of my suggestions from #9 which @Gábor Hojtsy suggested would be good additions in #11.

I'm not sure if 8.3.x will ship with Symfony 3; discuss here: #2712647: Update Symfony components to ~3.2

@timmillwood: can you also make sure the respective issues are tagged "8.3.0 release notes"? Thanks a lot!

@Gábor Hojtsy - Done!

1. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,69 @@
   +    * @todo: CKEditor 4.6.0: https://www.drupal.org/node/2828494
   

   Confirming this.

2. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,69 @@
   +- Improved REST API and decoupled site features:
   +    * REST API now supports anonymous registration requests.
   +    * Anonymous REST request performance increased by 60% by utilizing the page
   +      cache.
   +    * Improved the response messages and status codes for requests with missing
   +      or incorrect headers and wrong sent data.
   +    * Massive overhaul of the test coverage.
   

   The first one is rather confusingly named, so much so, that it's actually wrong.

   Second and fourth are accurate.

   Third is also confusing.

Improved it.

WTF, d.o ate my files!? Apparently they're there in the "files" table just below the IS, but it's missing from my comment. I think I just found a pretty big bug…

Couple notes from editing the release notes draft:

1. We should list improvements to experimental APIs separately from improvements to stable APIs. In particular, we can group the Content Moderation improvements into their own list.

2. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,71 @@
   +    * @todo: Update CKEditor to 4.6.0: https://www.drupal.org/node/2828494
   

   Done now!

3. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,71 @@
   +    * @todo: Add phpcs/coder to dev requirements: https://www.drupal.org/node/2744463
   

   In addition to the standards changes above, PHP CodeSniffer and Drupal Coder have been added as development requirements.

   (and put it at the end)

4. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,71 @@
   +    * Improved backward compatibility with WebTestBase.
   +    * Enlargement of JS test coverage.
   

   * Improved backward compatibility between BrowserTestBase and WebTestBase.
   * Expanded automated test coverage for JavaScript.

@xjm: Is PHP CodeSniffer and Drupal Coder being added as new development requirements really the least important coding standards change (since you suggest to move it last). It sounds like the biggest coding environment change ever to me. Am I overlooking something?

It's not in itself a coding standards change.

I came here to add #2808233: REST 403 responses don't tell the user *why* access is not granted: requires deep Drupal understanding to figure out to the changelog, but it's already in there :)

I also came here to update the CKEditor-related changelog entry, because both #2828494: Update CKEditor library to 4.6 and #2848215: Update CKEditor library to 4.6.2 landed, yay!

@Gábor Hojtsy Yeah the addition of the dev requriements is basically just adding another couple libraries that composer will slurp down if you are composing it for development (but not in packaged releases and not if you follow the instructions to use --no-dev for production). They were already the tools our coding standards rules were written for; we just didn't indicate that in our composer.json and so you had to know to install them manually.

Or the IS of #2744463: Add phpcs, coder 8.2.8 as --dev requirements for drupal/core puts it clearly:

That way we don't have to instruct people how to install them beyond saying "run composer install --dev"

Maybe we could state that in the CHANGELOG to make it clear to people what "add dev dependencies" means here. Something like:

In addition to the standards changes above, PHP CodeSniffer and Drupal Coder have been added as composer dev requirements, so that can be installed automatically with `composer install --dev` rather than requiring separate installation. (Do not use `composer install --dev` for production sites.)

- Add testing improvements #25 xjm item 4
- Move phpcs/coder to bottom of Coding Standards, using xjm's text #30 (verbatim, - typo)
- Mention new Status report.

Great, thanks @wturrell!

1. +++ b/core/CHANGELOG.txt
   @@ -32,6 +32,7 @@ Drupal 8.3.0, 2017-04-05
   +    * Redesigned Status report.
   

   Since it's not a proper noun, I think we should lowercase "status".

2. +++ b/core/CHANGELOG.txt
   @@ -58,13 +59,19 @@ Drupal 8.3.0, 2017-04-05
   +    * In addition to the standards changes above, PHP CodeSniffer and Drupal Coder
   +      have been added as composer dev requirements, so they can be installed
   +      automatically with `composer install --dev` rather than requiring separate
   +      installation. (Do not use `composer install --dev` for production sites.)
   +      https://www.drupal.org/node/2744463
   

   This goes over 80 chars on the first line, so we should rewrap it.

I think then the outstanding things are to make a Content Moderation section, and then just adding additional things that go in as they come.

(Updating issue credit.)

Not entirely clear if we just want to split 'Improved developer APIs' (adding a new Content Moderation API section) or merge the two content mod items there with the non-API ones in 'Improved authoring features'.

I think the next top-level bullet after "Improved site administration experience" could be something like "Content Moderation improvements (experimental)". Then that would include all the authoring, admin, and DX improvements for that module that are currently spread between other categories (as well as #2844594: Default workflow states and transitions which is not added yet since it was just committed yesterday).

We would keep this one where it is under "Added modules", maybe shortening or simplifying it a bit from what it is now:

Added the Workflows module (experimental) which abstracts the transitions
and states system from Content Moderation into a separate component so that
it can be re-used by other modules that implement non-publishing workflows.

But then also add under the Content Moderation header:

Refactored the module to use new experimental Workflows module.

Thanks, great questions.

Grateful if somebody could check my summation of #2844594: Default workflow states and transitions.

Marking for review of #36; thanks @wturrell.

There are numerous specific improvements to the plugin system that unblock contrib to depend on the new layout API; we should add a bullet for those too. @tim.plunkett is working on a CR to summarize them and once that CR is available we can use it to come up with CHANGELOG text. Marking NW for that.

The workflows improvements look good. Let's work on the text for these two:

+++ b/core/CHANGELOG.txt
@@ -23,16 +23,26 @@ Drupal 8.3.0, 2017-04-05
+    * A new initializeWorkflow() method in WorkflowTypeInterface to add
+      default states and transitions to workflows of that type.
+    * New WorkflowTypeInterface reads workflow type annotation for a list of
+      required states. These cannot be deleted via UI; if not present on save()
+      RequiredStateMissingException is thrown.

I think we should describe these changes in a way that is helpful for a less technical audience. @timmillwood, any suggestions on how to improve these?

Provisionally add #2852636: Update jQuery to version 2.2.4 (intentionally not troubling Testbot with this)

[Edit] On related note, should anyone feels like reviewing #686892: Update JavaScript section of Changelog - these are library updates that apparently got left out of the 8.0 release.

Per #2824548: Move token info cache to data cache bin and #2824547: Change ViewsData to use the default cache bin instead of discovery.

And back to work per #38

Add (provisionally) #2842298: [policy, no patch] Drop IE9 and IE10 support from Drupal 8.4.x.
I felt it unnecessary to mention April 11 specifically (seems that's more about killing off the last OS that can run them.)

+++ b/core/CHANGELOG.txt
@@ -14,6 +14,11 @@ Drupal 8.3.0, 2017-04-05
+    * Internet Explore 9 and 10 no longer supported - Microsoft have now ended
+      support for these browsers; maintaining compatibility is hard and costly.
+      Drupal will still support Internet Explorer 11 and it's replacement, Edge.

Good idea mentioning this. Rather than using a dash I'd start a new sentence for "Microsoft". I'd also remove the clause about it being hard and costly because we don't need to make excuses; just communicate the info.

Thanks @wturrell.

Browser support text changes, per #43.

There is an "it's" vs "its" typo in that patch which can be fixed in the next addition.

@wturrell, by the way, leaving the issue NW does not actually save anything testbot-wise. All untested patches will be tested when the issue is marked NR, including the old ones. So same number of test runs either way and it is just better to mark the status that makes sense, i.e. NR for the changes. :)

If you do want to prevent testbot from testing something, you should be able to add a .txt extension, or I think ending the filename with -do-not-test.patch might still work.

I've been working through some of the tagged issues…

- Fixed indenting of whole 'Added modules' section
- Fix it's/its typo, #45
- Added Twig and random_compat upgrades
- Mentioned CK Editor includes a new skin
- Added 'Allowed HTML tags' input -> texture
- Mentioned shortened Twig cache directory length + warning for Windows users.
- Mentioned the EntityType collection label and have given "Workflows" as an example.
- Explicitly mentioned the first batch of the WTB to BTB conversion.
- Added a 'Package Management' section (could maybe be elsewhere) with note about use of new module/theme repo endpoint.

@xjm (re: Testbot) - thanks, I should have guessed it would do that… I'm aware of (read: overly obsessive about) the amount of CPU needed to run each job, so like to skip them if the changes make it unnecessary and will hold up the queue/waste energy.

@wturrell: looks good!

+++ b/core/CHANGELOG.txt
@@ -35,6 +37,8 @@ Drupal 8.3.0, 2017-04-05
+    * The "Allowed HTML tags" input has been converted to a text area to remove
+      the limit on the number of tags that can be specified.

@@ -70,8 +77,12 @@ Drupal 8.3.0, 2017-04-05
+    * Add a collection label to EntityType. This is a plural uppercase label for
+      a collection of entities - e.g. "Workflows".
...
+    * Node constants (e.g. NODE_PUBLISHED, NODE_PROMOTED) have been moved to
+      NodeInterface. The old constants will be removed in Drupal 9.0.x.

I doubt these merit a changelog mention?

+++ b/core/CHANGELOG.txt
@@ -35,6 +37,8 @@ Drupal 8.3.0, 2017-04-05

+    * The "Allowed HTML tags" input has been converted to a text area to remove
+      the limit on the number of tags that can be specified.

@@ -70,8 +77,12 @@ Drupal 8.3.0, 2017-04-05
+    * Add a collection label to EntityType. This is a plural uppercase label for
+      a collection of entities - e.g. "Workflows".
...
+    * Node constants (e.g. NODE_PUBLISHED, NODE_PROMOTED) have been moved to
+      NodeInterface. The old constants will be removed in Drupal 9.0.x.

I doubt these merit a changelog mention?

The first Gábor and I agreed to mention since it was actually a compelling usability fix with security implications even because of the user impact, even though small. We can probably make it sound a little more exciting. ;)

The "Allowed HTML tags" input has been converted to a textarea, which significantly improves the usability of HTML filter configuration.

The second, not sure, we should check what we said when it was tagged.

The third should not specifically be about those constants. It should instead be mentioned as a general best practices change:

Most global constants in Drupal 8 have been deprecated in favor of class constants. As a best practice, use appropriate class constants rather than global constants.

Or something like that.

This version has xjm's revised text and placement for items 1 and 3 (which I can't improve on).

Background on item 2 if it helps, (as someone coming to it relatively fresh):

This is the tagged issue #2767025: Add entity type label for a collection of entities. It was spun off from #1850080: Entity type labels lack plurality, cannot generate UI text based on label if plural is needed, and was intended (so says the issue summary) for things like page titles that needed an uppercase plural (e.g. Workflows).

Webchick also cited it as making issues like #2811407: "Workflow entities" admin page title should be "Workflows" considerably easier to fix - i.e. compare the work needed in 2811407-27.patch to change a title from "Moderation state entities" to "Workflows" versus the rather cleaner 2811407-30.patch we were able to commit.

#49: thanks, that all makes a ton of sense :)

+++ b/core/CHANGELOG.txt
@@ -1,3 +1,108 @@
+    * @todo: Standardize on whitespace for anonymous functions (closures) https://www.drupal.org/node/1999722

Line exceeding 80 characters

Modified one line which contain more than 80 characters. Applying the patch, Please check

@Pavan, thanks for keeping an eye on coding standards. That line was just a todo during development, not part of the intended final patch, so we did not need to worry about it.

- jQuery 2.2.4 confirmed IN (NB: jQuery UI 1.12, which wasn't in changelog, is pushed back to 8.4.x)
- normalize.css 5.0.0 OUT (pushed back to 8.4.x)
- Have left the IE9/10 IN (now 8.4.x), but labelled "Advance notice:" – though more likely you just want to delete...

Another refresh:

- Short array syntax is done.
- Clarify what the new anonymous function coding standard actually is.

1. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,108 @@
   +- Improved site administration experience:
   

   Add https://www.drupal.org/node/2513534 :)

   Also https://www.drupal.org/node/2846782 should be added here IMHO.

2. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,108 @@
   +    * Redesigned status report.
   

   Can we move this to the first item of this sublist? That sounds like the biggest change here honestly.

3. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,108 @@
   +- Content Moderation improvements (experimental):
   

   Add a "Migration improvements (experimental)" section and add https://www.drupal.org/node/2669964 and https://www.drupal.org/node/2225717 (which are tagged for release notes)

4. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,108 @@
   +- Improved REST API and decoupled site features:
   

   This needs https://www.drupal.org/node/2751325 added.

5. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,108 @@
   +- Improved developer APIs:
   

   *Maybe* this should be added here, but also maybe in a misc improvements section, but https://www.drupal.org/node/2075889 definitely needs a mention.

6. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,108 @@
   +    * @todo: Somehow explain this change: https://www.drupal.org/node/2721179
   

   Still todo. Maybe "Replaced the deprecated Symfony ExecutionContextInterface by subclassing from ConstraintValidator to prepare for an update to Symfony 3."

7. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,108 @@
   +    * Add a collection label to EntityType. This is a plural uppercase label for
   

   Added

8. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,108 @@
   +    * @todo: A space is required between 'function' and opening parenthesis
   +      in anonymous functions (closures). https://www.drupal.org/node/1999722
   

   This did not land in 8.3.x so should be removed from here. (Based on https://www.drupal.org/node/2572795)

9. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,108 @@
   +    * In addition to the standards changes above, PHP CodeSniffer and Drupal
   

   Remove the intro text and keep from "PHP CodeSniffer..." onwards

10. +++ b/core/CHANGELOG.txt
    @@ -1,3 +1,108 @@
    +    * Enlargement of JS test coverage.
    ...
    +    * Expanded automated test coverage for JavaScript.
    

    Are these two the same? Or are they different? How?

11. +++ b/core/CHANGELOG.txt
    @@ -1,3 +1,108 @@
    +    * composer.json now uses new official endpoint for modules and themes,
    

    "uses the new" IMHO sounds better

I think "Enlargement of JS test coverage." got re-added in a reroll or something; let's remove it again please. :)

Accommodated the #57 and #58 changes
#57.1 - Done
#57.2 - Done. Moved it to top as its a big UX win.
#57.3 - Done
#57.4 - Done
#57.5 - Pending
#57.6 - Pending
#57.7 - Done
#57.8 - Done. Removed
#57.9 - Done
#57.10 - Pending
#57.11 - Done
#58 - Pending

P.S. Using this issue as an example to explain how to address the feedback and post the rerolled patches.
//Naveen

@naveenvalecha: I think I needed to review and change all the changes you made. Reasons:

1. You included the issue titles verbatim. Issue titles normally explain the problem. Changelog normally explains what changed, not what the problem was. Eg. "Migrate Drupal 7 core node translations to Drupal 8." (issue title) should become something like "Drupal 7 core node translations are now migrated to Drupal 8." (changelog). Even worse was "All serialized values are strings, should be integers/booleans when appropriate." where what we need to explain is that they are NOT strings anymore, right? So "Serialized boolean and integer values that used to be strings are now booleans and integers."
2. In several cases the changed or added lines exceeded the line limit.

Also resolved the remaining todos, one of which I directly provided suggested text above (and used it verbatim now).

+++ b/core/CHANGELOG.txt
@@ -78,33 +80,36 @@ Drupal 8.3.0, 2017-04-05
+      requirements, so they can be installed automatically with ¶

Duh end of line space. May be fixed on commit if no other problems?

+++ b/core/CHANGELOG.txt
@@ -1,3 +1,116 @@
+    * Updated to Twig 1.25.
+    * Updated to jQuery 2.2.4.
+    * Updated to CKEditor 4.6.2 (with new skin).
+    * Updated to paragonie/random_compat 2.0.2.

#2862254: Update non-Symfony dependencies before 8.3.0 and #2859772: Update Symfony components to ~2.8.18 are missing.

1. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,116 @@
   +    * PHP CodeSniffer and Drupal Coder have been added as composer dev
   +      requirements, so they can be installed automatically with ¶
   +      `composer install --dev` rather than requiring separate installation. (Do
   +      not use `composer install --dev` for production sites.)
   

   Should we mention coder version in vendor library section?

2. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,116 @@
   +- Package management:
   +    * composer.json now uses the new official endpoint for modules and themes,
   +      packages.drupal.org
   

   This is missing #2866109: Composer/installers update to 1.2.0 adding support for installing custom modules and themes to directories other than /vendor

+++ b/core/CHANGELOG.txt
@@ -1,3 +1,116 @@
+- Testing improvements:
+    * Integrated PHPUnit verbose output in SimpleTest UI.
+    * Improved backward compatibility with WebTestBase.
+    * Improved backward compatibility between BrowserTestBase and WebTestBase.
+    * Many old WebTestBase tests have been moved to BrowserTestBase.
+    * Expanded automated test coverage for JavaScript.

This should also include #2850797: Prepare our phpunit tests to be BC compatible with phpunit 5.x/6.x imo.

Just a reminder we still need to decide what to do about #2848192: Add issue #s to CHANGELOG.txt entries

I'm neither strongly pro or anti, but this patch will need to be committed first before anybody attempts it…

Thanks @wturrell. @webchick and I agreed to do that for 8.4.x but not for 8.3.x since we're out of time. (Sorry, I forgot to post that on the issue. Will do so now.)

1. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,116 @@
   +      states from Content Moderation into a separate component for re-use by
   

   No hyphen in "reuse" (the noun and verb forms are spelled the same).

2. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,116 @@
   +- Updated vendor libraries:
   

   Need to add the thingy for #2866109: Composer/installers update to 1.2.0 adding support for installing custom modules and themes to directories other than /vendor.

3. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,116 @@
   +    * Updated to CKEditor 4.6.2 (with new skin).
   

   Should we name MoonaLisa here?

4. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,116 @@
   +      8.4.x, due October 2017. Microsoft have now ended support for these
   

   s/due/scheduled for/

   Also "Microsoft has" would be more idiomatic these days I think, although there's a grammar debate possible there.

5. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,116 @@
   +    * Image fields are now limited to only accepting images, not also videos.
   

   I recommend the same change here we made in the FP post. (Pretty sure I also pointed this out in a previous review.) The FP post draft has:

   Image fields are now limited to only accepting images, so that users on mobile clients are not offered a confusing and non-functional video upload option.

6. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,116 @@
   +    * A new initializeWorkflow() method in WorkflowTypeInterface to add
   +      default states and transitions to workflows of that type.
   +    * New WorkflowTypeInterface reads workflow type annotation for a list of
   +      required states. These cannot be deleted via UI; if not present on save()
   +      RequiredStateMissingException is thrown.
   

   These still don't describe the actual impact of the change. (See #38.)

7. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,116 @@
   +    * Serialized boolean and integer values that used to be strings are now
   +      booleans and integers.
   

   This is confusing and does not indicate why it matters. I'd suggest:

   Serialized values for Booleans and integers are now returned as the correct data type,
   rather than incorrectly typed as strings.

8. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,116 @@
   +    * Shorten length of Twig cache directory. Lengthy file/directory names could
   +      be problematic in some circumstances. Warn Windows users if public file
   +      path is too long.
   

   How is this performance and scalability?

9. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,116 @@
   +    * Various variations of routers merged into either AccessAwareRouter or
   

   "Various variations" is weird and redundant. :)

10. +++ b/core/CHANGELOG.txt
    @@ -1,3 +1,116 @@
    +    * Switch to short array syntax.
    

    "Officially adopted short array syntax and updated all of core accordingly." or something. "Switch" is the wrong tense and implies it wasn't there before, whereas there was already a lot of both syntaxes.

11. +++ b/core/CHANGELOG.txt
    @@ -1,3 +1,116 @@
    +      requirements, so they can be installed automatically with ¶
    

    Trailing space here. :)

12. +++ b/core/CHANGELOG.txt
    @@ -1,3 +1,116 @@
    +      packages.drupal.org
    

    Missing final period.

13. +++ b/core/CHANGELOG.txt
    @@ -1,3 +1,116 @@
    +- Miscellaneous changes:
    +    * Incoming paths are again case-insensitive for routing, similar to earlier
    +      major Drupal versions.
    

    Hm, this is more important than "miscellaneous" and we should maybe not have a miscellaneous header for one thing. It's a UX, site builder, and developer improvement.

+++ b/core/CHANGELOG.txt
@@ -1,3 +1,116 @@
+- Package management:

I think it's worth mentioning the addition of a package.json file and subsequent dependencies for core JavaScript development, which happened here, #2809477: Add ES6 to ES5 build process.

---

Something along the lines of, “Added Package.json enabling new JavaScript language features” in Package Management.

Should we mention coder version in vendor library section?

Nah.

DONE:

----
61/a: added a summary
61/b: added
---
63/1: nope as per @xjm in 68
63/2: done
----
66/1: done
66/2: added in the package manegement section as per Jibran in 63/2
66/3: done, also looked up the actual name Moono-Lisa ;)
66/4: done
66/5: done
66/7: done, I lowercased boolean since I think you did not intend it to be uppercase
66/9: done
66/10: done
66/11: done
66/12: done
-----
67: done

TODO:
66/6: still todo
66/8: still todo; don't know https://www.drupal.org/node/2606772 only mentioned performance once
66/13: still todo; did not find a better place

Duh should not have done what @Jibran suggested in #64 because that is 8.4.x only.

1. +++ b/core/CHANGELOG.txt
   @@ -66,8 +72,8 @@ Drupal 8.3.0, 2017-04-05
   +    * Serialized values for booleans and integers are now returned as the ¶
   +      correct data type, rather than incorrectly typed as strings.
   

   I did mean to capitalize "Boolean" actually; it's a person's name. See on https://en.wikipedia.org/wiki/Boolean:

   In most computer programming languages, a Boolean data type is a data type with only two possible values: true or false.

   (We discussed around the time of that issue whether lowercase was acceptable but erred on the side of capitalized IIRC.)

2. +++ b/core/CHANGELOG.txt
   @@ -78,7 +84,7 @@ Drupal 8.3.0, 2017-04-05
   -    * Various variations of routers merged into either AccessAwareRouter or
   +    * Variations of routers merged into either AccessAwareRouter or ¶
          DynamicRouter to simplify the routing system.
   

   Maybe:

   Deprecated several routing services in favor of two more unified services.

3. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,125 @@
   +      mobile clients are not offered a confusing and non-functional video ¶
   

   Here (and elsewhere): A few more trailing spaces crept in.

4. +++ b/core/CHANGELOG.txt
   @@ -1,3 +1,125 @@
   +    * Custom modules and themes can now be installed to correct locations using
   +      composer
   

   Missing trailing period.

66/8: still todo; don't know https://www.drupal.org/node/2606772 only mentioned performance once

So I think the answer is "it doesn't really". It is miscategorized in the same way in the release notes draft. It's included because it's one of the handful of non-test-failure criticalish bugs fixed in 8.3.x only. See also: https://www.drupal.org/project/issues/search/drupal?project_issue_follow...

Related mystery solved: #2809227: Store revision id in originalRevisionId property to use after revision id is updated is a critical, not a DX improvement. So I don't think we should list it in the CHANGELOG, only the release notes. Same for the Twig change (#2606772: Long Twig cache directories can cause failures on some filesystems) and other 8.3.x-only non-regression criticals, which include:

• #2640496: Revision ID in {node} and {node_revision} can get out of sync
• #2846782: Bulk operation actions might not act on the selected items
• #2826047: 6-8 user picture migration must create new fids, which can conflict with fids used by other migrations

All right, I don't agree with the Boolean capitalization and neither the removal of mentioning the cue words for routers (I think their inclusion would have helped people figure out what is this even about), but its also 11pm here, so not interested in arguing...

I believe this resolves all of #71, #72 and #73.

What definitely remains is 66/6 and 66/13.

Also resolved 66/13 after discussion with @xjm.

This should cover 66/6.

I'm going to break protocol a tiny bit so @xjm can commit this and we can release the product.

Alright yeah, I think we've taken this about as far as we can.

Moving this to the correct branch (lol).

Thanks especially to @wturrell for all the help updating this patch over the past couple months, and to @Gábor Hojtsy for painstaking review! Committed to 8.4.x and 8.3.x.

#60,
Fair enough. That was the quick reroll :)
Thanks for the review!

//Naveen