Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Previously on "Random Fails":
- #2830485: \Drupal\Tests\outside_in\FunctionalJavascript\OutsideInBlockFormTest fails randomly
- #2848177: More \Drupal\Tests\outside_in\FunctionalJavascript\OutsideInBlockFormTest random fails
Today:
Drupal\Tests\outside_in\FunctionalJavascript\OutsideInBlockFormTest::testBlocks with data set "block-powered" ('system_powered_by_block', 'Can you imagine anyone showin... block', 'span a', 'h2', 'Save Powered by Drupal', '#toolbar-item-user')
Failed asserting that a NULL is not empty./var/www/html/core/modules/outside_in/tests/src/FunctionalJavascript/OutsideInJavascriptTestBase.php:143
Examples:
Comment | File | Size | Author |
---|---|---|---|
#13 | 2901626-13.patch | 1.19 KB | tedbow |
#13 | interdiff-10-13.txt | 1.05 KB | tedbow |
#10 | 2901626-10.patch | 1.16 KB | tedbow |
#6 | 2848177-14.patch | 1.16 KB | Anonymous (not verified) |
#5 | 2901626-5-x30-no_transitions.patch | 1.71 KB | tedbow |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedvaplas created an issue. See original summary.
Comment #2
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #4
Anonymous (not verified) CreditAttribution: Anonymous commentedI confused the place of error. It seems this is what was said here #2848177-14: More \Drupal\Tests\outside_in\FunctionalJavascript\OutsideInBlockFormTest random fails.
Comment #5
tedbowOk I was working with @drpal the yesterday and we were seeing similar random fail on this local.
We fixed it by removing all animations for testing. Could this a solution? We don't actually test anything in relation to animation transitions in our tests. Why do we need them?
This patch adds removing all transitions to core/modules/outside_in/tests/modules/outside_in_test_css/css/css_fix.theme.css which will already use because our testing doesn't work pointer events CSS.
I am also uploading at patch with only changes being the running the test 30 times. To test if we are likely to get a random fail.
Comment #6
Anonymous (not verified) CreditAttribution: Anonymous commentedConstantly worrying about turning off the animation for a stable passing of tests seems a little tedious, although it probably makes sense.
What if we add a patch from #2848177-14: More \Drupal\Tests\outside_in\FunctionalJavascript\OutsideInBlockFormTest random fails?
Comment #7
Anonymous (not verified) CreditAttribution: Anonymous commentedI overlooked that all transitions were canceled globally. Good idea! Enhanced testing was launched.
Comment #8
Anonymous (not verified) CreditAttribution: Anonymous commentedWell, #5 looks nice. I created another issue to solve the problem of stability tests due to CSS rules. So, we can add it like @todo for current solution, or not. In any case, +1 to RTBC with #5. This will help to quickly solve random fails of tests such types. Thanks!
Comment #9
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #10
tedbowSince @vaplas +1 rtbc for #5 here is the patch with only the needed test change
We also already have follow to see if there is better way to test animations #2901792: Disable all animations in Javascript testing
Comment #11
tim.plunkettThese two comments should have whitespace before and after the words. And maybe punctuation?
And it leads me to wonder what exactly the first section is, can it get a comment too?
Comment #12
tedbowComment #13
tedbow#11 fixed
Comment #14
GrandmaGlassesRopeManThis looks good, and probably needed until we can migrate away from Phantom.
🚀
Comment #15
catchCommitted/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!
Comment #18
xjm🚀
Comment #19
tacituseu CreditAttribution: tacituseu commentedComment #21
tedbowComment #22
xjm