[D8] Page Scroll Indicator

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2883767

Project 2: https://www.drupal.org/node/2811601

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxamitdrupal2883766git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Amit,

Kindly see the automated review of your project and solve them as its showing some errors.

Link: https://pareview.sh/node/1979

There is an issue as your project git URL default branch is not set.

For more information: https://www.drupal.org/node/1659588

Great work.

Looks fine to me except hook_preprocess_HOOK(). Libraries should be attached in hook_page_attachment(). Also I think js code can use some refactoring.

I'm agreed with #16 and also think that many if - else there would be better to replace by switch statement.

@amit.drupal, I'm seeing serious performance issues in JavaScript code. You are calling jQuery with static selector on every scroll scroll event.

Also, probably you may consider https://github.com/BR0kEN-/scroll-breakpoint.js (I don't insist to use my own lib, but technique to prevent unnecessary operations executions) for usage.

@amit.drupal,

I think this module is duplicated, i found same module with same java script files D7 version, you should contact that person and merge your D8 version to the same module instead creating your own, below is the link of the module,

https://www.drupal.org/project/scroll_progress

Thanks,

@amit.drupal

Just ping that guy and ask him to maintainer access and he can release his module and create release without review process along with that you can commit your D8 version with the same module, no need to create separate module, and i looked at the js and these are same as the D7 module. Below is the link for release process :

https://www.drupal.org/node/1068944

Thanks,

Abandoned? Why did you decide this? As I can see the last commit was there just one week ago.

@amit.drupal please look at @BR0kEN comment.

Thanks,

@amit.drupal Yes i understand, but again the issue is your project will be duplicated because there is no way to delete a full project it will always available for the community so the ideal way is to merge your project with the actual one and provide your D8 version to that project, you can then create a separate issue for review by doing that you will be able to get full project access once it passed by the community.

Thanks,

http://git.drupal.org/project/page_scroll_indicator.git 8.x-1.x.

I am trying to check this project on Pareview.sh. It is showing git cloned failed. Please do check.

Please update your issue with proper git details of your project.

There is a similar project voor Drupal 7 : https://www.drupal.org/project/reading_progress_bar

Review

1. config/install/reading_progress_bar.configure.yml is missing with default values
2. scroll_option uses numbers, but it's better to use system names for maintaining new options in the near future.
3. scroll_progress_color vs colour > choose one
4. "Go to <a href=":link">configuration page </a>." .. space before </a>
5. $config->get('scroll_progress_color') needs to be escaped (XSS)
6. 'scroll_for_admin' isn't implemented
7. scroll_option isn't required in your config form, but it has a default selection in your switch, see function page_scroll_indicator_page_attachments .. it looks like scroll_option must be required
8. DocBlock '@file' in .module file has a typo
9. README.txt is far from finished

I tried this module and I couldn't access the configuration page :(

Great work
RTBC +1

Review of the 8.x-1.x branch (commit bbe3888):

• Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting
  

  ./js/global.js:                                  ASCII text, with CRLF line terminators
  js/global.js
  

• PHP Fatal error: Cannot use Drupal\Component\Utility\String as String because 'String' is a special class name in ./page_scroll_indicator.module on line 4
  Errors parsing ./page_scroll_indicator.module
• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
• ESLint has found some issues with your code (please check the JavaScript coding standards). See attachment.
• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: ...reviewsh/pareview_temp/src/Form/PageScrollIndicatorConfigureForm.php
  --------------------------------------------------------------------------
  FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
  --------------------------------------------------------------------------
   58 | WARNING | There must be no blank line following an inline comment
  --------------------------------------------------------------------------
  
  Time: 17ms; Memory: 4Mb
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version.

FILE: /root/repos/pareviewsh/pareview_temp/README.txt
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 23 | WARNING | Line exceeds 80 characters; contains 88 characters
 26 | WARNING | Line exceeds 80 characters; contains 87 characters
----------------------------------------------------------------------


FILE: /root/repos/pareviewsh/pareview_temp/page_scroll_indicator.module
-----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------
  1 | ERROR | [x] Missing file doc comment
 49 | ERROR | [ ] Blank lines are not allowed after DEFAULT statements
 50 | ERROR | [x] Whitespace found at end of line
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------


FILE: ...reviewsh/pareview_temp/src/Form/PageScrollIndicatorConfigureForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
 54 | ERROR   | [ ] Comment indentation error, expected only 1 spaces
 55 | WARNING | [ ] Line exceeds 80 characters; contains 115 characters
 57 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
 58 | WARNING | [x] There must be no blank line following an inline
    |         |     comment
 58 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 71ms; Memory: 6Mb

/root/repos/pareviewsh/pareview_temp/js/global.js: line 1, col 20, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 2, col 1, Error - Expected space or tab after '//' in comment. (spaced-comment)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 2, col 29, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 3, col 1, Error - Use the function form of 'use strict'. (strict)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 3, col 10, Error - 'fadeIn' is defined but never used. (no-unused-vars)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 3, col 29, Error - Missing space before opening brace. (space-before-blocks)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 3, col 30, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 4, col 24, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 5, col 33, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 5, col 41, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 6, col 1, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 7, col 21, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 8, col 44, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 9, col 30, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 10, col 30, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 11, col 35, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 12, col 6, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 13, col 8, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 14, col 2, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 15, col 1, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 16, col 1, Error - Expected space or tab after '//' in comment. (spaced-comment)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 16, col 30, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 17, col 1, Error - Use the function form of 'use strict'. (strict)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 17, col 10, Error - 'fadeOut' is defined but never used. (no-unused-vars)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 17, col 21, Error - Missing space before opening brace. (space-before-blocks)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 17, col 22, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 18, col 24, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 19, col 1, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 20, col 21, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 21, col 40, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 22, col 26, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 22, col 33, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 23, col 5, Error - Closing curly brace appears on the same line as the subsequent block. (brace-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 23, col 13, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 24, col 35, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 25, col 6, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 26, col 8, Error - Expected linebreaks to be 'LF' but found 'CRLF'. (linebreak-style)
/root/repos/pareviewsh/pareview_temp/js/global.js: line 27, col 2, Error - Newline required at end of file but not found. (eol-last)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 6, col 48, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 8, col 1, Error - Trailing spaces not allowed. (no-trailing-spaces)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 9, col 31, Error - Trailing spaces not allowed. (no-trailing-spaces)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 10, col 49, Error - Missing space before function parentheses. (space-before-function-paren)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 16, col 26, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 16, col 53, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 16, col 102, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 16, col 152, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 16, col 155, Error - Missing semicolon. (semi)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 17, col 27, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 17, col 73, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 17, col 76, Error - Missing semicolon. (semi)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 18, col 26, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 18, col 77, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 18, col 80, Error - Missing semicolon. (semi)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 24, col 47, Error - Infix operators must be spaced. (space-infix-ops)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 28, col 27, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 33, col 10, Error - Trailing spaces not allowed. (no-trailing-spaces)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_bottom.js: line 36, col 14, Error - Newline required at end of file but not found. (eol-last)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_circular.js: line 6, col 48, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_circular.js: line 7, col 364, Error - Trailing spaces not allowed. (no-trailing-spaces)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_circular.js: line 8, col 1, Error - Trailing spaces not allowed. (no-trailing-spaces)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_circular.js: line 11, col 1, Error - Trailing spaces not allowed. (no-trailing-spaces)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_circular.js: line 14, col 1, Error - Trailing spaces not allowed. (no-trailing-spaces)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_circular.js: line 16, col 49, Error - Missing space before function parentheses. (space-before-function-paren)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_circular.js: line 19, col 11, Error - Expected indentation of 8 spaces but found 10. (indent)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_circular.js: line 19, col 26, Error - Trailing spaces not allowed. (no-trailing-spaces)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_circular.js: line 20, col 29, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_circular.js: line 22, col 11, Error - Expected indentation of 8 spaces but found 10. (indent)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_circular.js: line 25, col 11, Error - Expected indentation of 8 spaces but found 10. (indent)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_circular.js: line 31, col 46, Error - Infix operators must be spaced. (space-infix-ops)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_line.js: line 6, col 40, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_line.js: line 6, col 47, Error - Trailing spaces not allowed. (no-trailing-spaces)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_line.js: line 7, col 48, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_line.js: line 9, col 33, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_line.js: line 10, col 1, Error - Trailing spaces not allowed. (no-trailing-spaces)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_line.js: line 11, col 7, Error - Expected space or tab after '//' in comment. (spaced-comment)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_line.js: line 12, col 49, Error - Missing space before function parentheses. (space-before-function-paren)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_line.js: line 14, col 21, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_line.js: line 14, col 48, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_line.js: line 14, col 98, Error - Strings must use singlequote. (quotes)
/root/repos/pareviewsh/pareview_temp/js/page_scroll_indicator_line.js: line 14, col 149, Error - Strings must use singlequote. (quotes)

80 problems

After I enable this module I get this error:

Fatal error: Cannot use Drupal\Component\Utility\String as String because 'String' is a special class name in /page_scroll_indicator/page_scroll_indicator.module on line 4

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

module is working fine.

Thank you for your contribution!

Looking at the list of the committers, I see there are other users who made commits. Since the purpose of this application is checking what the user who applies understands about writing secure code and following Drupal coding standards, we cannot use a project with commits from other users. We need a project with commits from the user who applies only.

(The link to the project is https://www.drupal.org/sandbox/amitdrupal/2883766.)

If you are still interested on being able to opt into security coverage for projects you create, please open a new application using a project for which the only commits (for the time required to set the application's status to Fixed) are from you.
Please don't open a new application if you aren't sure to have time to dedicate to the application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.