Clone Url:

git clone --branch 7.x-1.x https://git.drupal.org/project/available_hooks.git
cd available_hooks

Project Url:
https://www.drupal.org/project/available_hooks

Project description:
Available Hooks module provide all hooks from currently installed modules into your project.

https://pareview.sh/node/1378

Manual reviews of other projects :

Comments

yogesh.kushwaha89 created an issue. See original summary.

yogesh kushwaha’s picture

yogesh kushwaha commented
Issue summary: View changes
deepanker_bhalla’s picture

deepanker_bhalla commented

Hi,

Kindly see the automated review of your project as some errors can be seen.

Link: https://pareview.sh/node/1378

deepanker_bhalla’s picture

deepanker_bhalla commented
Status: Needs review » Needs work
manish.upadhyay’s picture

manish.upadhyay commented

Hi yogesh.kushwaha89,

Please fix below issues:

1) There are several errors for code formatting so please fix them, you can find those at : https://pareview.sh/node/1378
2) In "available_hooks_view_module_hook" function please return render array instead of theme.
3) In "available_hooks_view_module_hook" use attached method to attach css and js to the template.

Thanks,

yogesh kushwaha’s picture

yogesh kushwaha commented
Status: Needs work » Needs review

Issue has been fixed. Manish Please review changes.

yogesh kushwaha’s picture

yogesh kushwaha commented
Issue summary: View changes
ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented
ankush_03’s picture

ankush_03
Location Gurgaon, India 🇮🇳
commented

Hi yogesh,
Below is my manual review :
1. Add hook_help in your module file.
2. In your js file change Accordion view logic for hook list page to js file for available_hooks

PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

yogesh kushwaha’s picture

yogesh kushwaha commented

Hi agautam,

I have been added hook_help and also change js file comment. Please review.

yogesh kushwaha’s picture

yogesh kushwaha commented
Priority: Normal » Major
yogesh kushwaha’s picture

yogesh kushwaha commented
Issue tags: +PAreview: security
yogesh kushwaha’s picture

yogesh kushwaha commented
Issue summary: View changes
yogesh kushwaha’s picture

yogesh kushwaha commented
Issue summary: View changes
yogesh kushwaha’s picture

yogesh kushwaha commented
Issue summary: View changes
yogesh kushwaha’s picture

yogesh kushwaha commented
Issue summary: View changes
yogesh kushwaha’s picture

yogesh kushwaha commented
Issue summary: View changes
Issue tags: +PAreview: review bonus
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes
Issue tags: -PAreview: review bonus

Removing review bonus tag, you have not done all manual reviews, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects, as requested on the review bonus page.

yogesh kushwaha’s picture

yogesh kushwaha commented
Issue summary: View changes
yogesh kushwaha’s picture

yogesh kushwaha commented
Issue tags: +PAreview: review bonus
yogesh kushwaha’s picture

yogesh kushwaha commented

Any status update?

mehul.shah’s picture

mehul.shah commented

Hi @Yogesh,

Please add the below line in available_hooks.info

configure = admin/config/development/available-hooks

Along with this comment, the status of the module remains "Needs Work"

mehul.shah’s picture

mehul.shah commented
Status: Needs review » Needs work
yogesh kushwaha’s picture

yogesh kushwaha commented

@mehul.shah line configure = admin/config/development/available-hooks has been added to available_hooks.info file.

Thanks for your review.

yogesh kushwaha’s picture

yogesh kushwaha commented
Status: Needs work » Needs review
amit.drupal’s picture

amit.drupal commented

Improve your module README.txt
I think include some basic points.

1 - Features
2 - Configuration

README Template:

https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...

yogesh kushwaha’s picture

yogesh kushwaha commented

Hi @amit.drupal,

I have been changed README.txt file as per read me template. Is there anything else I have to correct. If yes please review else make it as RTBC.

Thanks

yogesh kushwaha’s picture

yogesh kushwaha commented
Issue summary: View changes
yogesh kushwaha’s picture

yogesh kushwaha commented
Priority: Major » Critical
iyyappan.govind’s picture

iyyappan.govind
he/him
Primary language Tamil
Location Chennai, India
commented
Status: Needs review » Closed (duplicate)

Hi,

I can see this feature is already done by "Developer Docs"module.

Thanks

yogesh kushwaha’s picture

yogesh kushwaha commented
Status: Closed (duplicate) » Needs review

Hi iyyappan.govind,

As I see Developer Docs module only list hook name but my module display complete implementation of the hook. If you read module description then you can find the motive of the module. Developer Docs module display name of the hook and again you need to search hook implementation code.

Available hook module is light weight module which display complete code with parameter and function comment.

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

Git clone failed for https://git.drupal.org/sandbox/yoges89/2861064.git while invoking http://pareview.sh/pareview/httpsgitdrupalorgsandboxyoges892861064git

Git clone failed. Aborting.

I'm a robot and this is an automated message from Project Applications Scraper.

yogesh kushwaha’s picture

yogesh kushwaha commented
Issue summary: View changes
yogesh kushwaha’s picture

yogesh kushwaha commented
Status: Needs work » Needs review
PA robot’s picture

PA robot commented
Issue summary: View changes

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

yogesh kushwaha’s picture

yogesh kushwaha commented
Issue summary: View changes

Git url has been uddated

yogesh kushwaha’s picture

yogesh kushwaha commented
Issue summary: View changes
yogesh kushwaha’s picture

yogesh kushwaha commented
Issue summary: View changes
yogesh kushwaha’s picture

yogesh kushwaha commented

Any Update?

pankajsachdeva’s picture

pankajsachdeva commented

Hi @yogesh,

I have manually reviewed your module's code and also check the functionality. Its looking good to me.

NICE WORK!!!!

I am doing it RTBC.

pankajsachdeva’s picture

pankajsachdeva commented
Status: Needs review » Reviewed & tested by the community
pankajsachdeva’s picture

pankajsachdeva commented
pankajsachdeva’s picture

pankajsachdeva commented
yogesh kushwaha’s picture

yogesh kushwaha commented

Thanks pankajsachdeva

yogesh kushwaha’s picture

yogesh kushwaha commented

Any Update???

visabhishek’s picture

visabhishek commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -PAreview: security

Thanks for your contribution, Yogesh Kushwaha!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

visabhishek’s picture

visabhishek commented

Assigning Credits.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.