[D8] Auto Menu Title

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

Please see: https://pareview.sh/node/1166

Manual Reviews

File: auto_menutitle.info

core: '8.x'

Core: 8.x

dependencies:
  - menu_ui

Dependency should in format :
:. See here.

name: Automatic menutitles
Just a small suggestion: Automatic Menu Titles

Filename: auto_menutitle.module

$type = $form_state->getFormObject()->getEntity()->get("type");

Can be replaced by $form['type']['#default_value'];

if (empty($selected)) {
      $form_state->setErrorByName('menu_options', t("To 'Provide a menu link by default' you must also select one or more 'Available menus'."));
    }

As I understand the lines you want to highlight some text, so placeholder can be used of highlighting.

$form_state->setErrorByName('menu_options', t('To %menu_link you must also select one or more %available_menus.', [
        '%menu_link' => t('Provide menu link'),
        '%available_menus' => t('Available Menus'),
      ]));

Refer here for Placeholders info.

$form_state->getValues()['auto_menutitle'];

Can be done as : $form_state->getValue('auto_menutitle');.

getValues : https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Form!FormState.ph...
getValue: https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Form!FormStateInt...

The checkbox option for auto menu title results in wrong option selected in menu_parent element. See attached screenshot.

I have filed an issue in core related to my problem of wrong options in default parent item.

https://www.drupal.org/node/2854190

Apart from the issue reported in core, this module works fine if menu options are selected properly.

Improve your module README.txt
I think include some basic points.

1 - Features
2 - Configuration

README Template:

https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...

@yogesh.kushwaha89 We never change it to Needs Work until and unless it is a PA application blocker.

Looks like the project is already covered under security advisory policy, and also the owner of the project is also a git vetted user.

Also, you are having the maintainer rights for this project, so closing this issue.

Thank you for your contribution!

As reported in Apply for permission to opt into security advisory coverage, the first step is creating your repository. You are using a project maintained from another user.
Since the purpose of this application is checking what the user who applies understands about writing secure code and following Drupal coding standards, we cannot use a project with commits from other users.

This issue queue is for project owners who wish to apply for permission to opt into security advisory coverage. Also, you have access to commit code, edit project and maintain issues of the project. Please reach out to module owner if you need any additional access to the module.