This Hebrew Calendar module is based on the widely used "Calendar" module. This module adds additional functionality, including: displaying Hebrew dates, Jewish holidays, sunset times, havdalah times, weekly Torah reading/parasha, rosh hodesh, and related Jewish calendar information. This module does not remove any functionality of the original calendar module. The reason I did not submit my changes to the maintainer of the calendar module, is that its only a very small niche of users of that module, would potentially be interested in the Hebrew calendar functionality.

There is a configuration screen so that you have full control over which items you want displayed on your calendar. There is a screen print of the admin area attached to this issue. There is also a screen print of how the front-end calendar would appear to a website visitor.

The project page for this module is: https://www.drupal.org/sandbox/fountaintribe/2830659

The git clone command for this project is:
git clone --branch 7.x-1.x https://git.drupal.org/sandbox/fountaintribe/2830659.git hebrew_calendar

CommentFileSizeAuthor
DrupalHebCal_admin.png39.49 KBfountaintribe
DrupalHebCal.png46.73 KBfountaintribe
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fountaintribe created an issue. See original summary.

fountaintribe’s picture

fountaintribe CreditAttribution: fountaintribe commented
Title: [D7]Hebrew Calendar » [D7] Hebrew Calendar
fountaintribe’s picture

fountaintribe CreditAttribution: fountaintribe commented
Issue tags: -internationalization calendar +internationalization, +calendar
PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxfountaintribe2830659git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Drupal8’s picture

Drupal8 CreditAttribution: Drupal8 commented

See the errors https://pareview.sh/node/1296.
Some to highlight 

The "?>" PHP delimiter at the end of files is discouraged, see https://www.drupal.org/node/318#phptags

./includes/PersonalCalendar.inc

No need for if else at PersonalCalendar.inc

if( $cur->category == "holiday" &&  $hebcal_date_tmp == $date_parm ){
	
				...
	
				}else{
					// keep looking.
				}

Remove the comments that add no value

	//define("foo", "bar"); 
	//if (empty(foo)) echo "empty";

No uninstall for variables

Yogesh Kushwaha’s picture

Yogesh Kushwaha CreditAttribution: Yogesh Kushwaha at Kellton Tech Solutions Ltd commented

HI fountaintribe,

Here are my manual review for your module

  • You have given module name as "Hebrew Calendar" but files are name as calendar.info, calendar.module.
  • There are another contributed module with same file name Calendar. Please make sure module folder and file name should be same and unique.
  • on .module file line no 465 and 471 you have written db_select query which is giving error Recoverable fatal error: Argument 2 passed to SelectQuery::fields() must be of the type array, string given, called in ......
  • ->fields('v', 'name')Should be ->fields('v', array('name'))
PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.