[D7] Google Drive Field

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectfield_gdrivegit

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

HI sharma.amitt16,

Here are my manual code review.

• .module file line 8

use module_load_include function instead of require_once

• Use proper function commenting
• .module line no 340

Do not use hard coded gmail id

• .install file there is no need to implement hook_install if you are not doing anything there.

Hi,

There are many errors .Please first resolve these error and check on http://pareview.sh

Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting

./field_gdrive.module: PHP script, ASCII text, with CRLF, LF line terminators
./field_gdrive.field.inc: PHP script, ASCII text, with CRLF, LF line terminators
./README.txt: ASCII text, with CRLF line terminators
README.txt
field_gdrive.field.inc
field_gdrive.module
Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
DrupalPractice has found some issues with your code, but could be false positives.

FILE: /root/repos/pareviewsh/pareview_temp/field_gdrive.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
1 | WARNING | File has mixed line endings; this may cause incorrect
| | results
226 | WARNING | Unused variable $authUrl.
283 | WARNING | Unused variable $authUrl.
308 | WARNING | Variable $result is undefined.
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/field_gdrive.field.inc
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
1 | WARNING | File has mixed line endings; this may cause incorrect
| | results
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/field_gdrive.install
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
126 | WARNING | Do not use DELETE queries with db_query(), use
| | db_delete() instead
144 | WARNING | Unused variable $field_name.
--------------------------------------------------------------------------

Time: 80ms; Memory: 6Mb
DrupalSecure has found some issues with your code (please check the Writing secure core handbook).

FILE: /root/repos/pareviewsh/pareview_temp/field_gdrive.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
1 | WARNING | File has mixed line endings; this may cause incorrect
| | results
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/field_gdrive.field.inc
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
1 | WARNING | File has mixed line endings; this may cause incorrect
| | results
--------------------------------------------------------------------------

Time: 37ms; Memory: 6Mb
No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: /root/repos/pareviewsh/pareview_temp/field_gdrive.module
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
1 | WARNING | File has mixed line endings; this may cause incorrect
| | results
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/css/field_gdrive.css
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
63 | ERROR | [x] Spaces must be used for alignment; tabs are not allowed
63 | ERROR | [x] Expected 1 space before opening brace of class
| | definition; tab found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/field_gdrive.field.inc
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
1 | WARNING | File has mixed line endings; this may cause incorrect
| | results
167 | WARNING | Only string literals should be passed to t() where
| | possible
---------------------------------------------------------------------

Hi Amit ,

Please add module exist in field_gdrive_upload_to_drive function line no 309

Hi Amit,

Refer this link https://www.drupal.org/node/1015226
You have following branches -

• 7.x-1.x
• 7.x-1.2
• 7.x-1.2-Final
• 7.x-1.0-dev
• 7.x-1.0-configuration
• 8.x-1.0-dev

I suppose you should have following branches -

• 7.x-1.x
• 8.x-1.x

and you should create new TAG for each release. So following should be tags not branches.

• 7.x-1.0
• 7.x-1.1
• 7.x-1.2

Refer these links -
https://www.drupal.org/node/1015226
https://www.drupal.org/project/field_gdrive/git-instructions

The solution should be -
Merge all 7 branches into 7.x-1.x
Create 8.x-1.x branch from 8.x-1.0-dev and delete 8.x-1.0-dev
Post this start using tags for creating release.

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2891185

Project 2: https://www.drupal.org/node/2874772

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.