Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
18 Apr 2017 at 13:05 UTC
Updated:
26 May 2017 at 10:26 UTC
Jump to comment: Most recent
Comments
Comment #2
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectuserpoints_balance_h...
Fixed the git clone URL in the issue summary for non-maintainer users.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
cchanana commentedHi Dirst,
Kindly see the automated review of your project as its showing some errors.
Link: https://pareview.sh/node/1662
Comment #4
Dirst commentedOk done.
Comment #5
player259 commentedComment #6
sharma.amitt16 commentedHi @Dirst,
My manual review,
1) user_points_balance_history.install
At line no 18, please add check for table(userpoints_txn) existence in implementation of hook_install(). It will give error if table doesn't exists. It's safe to check the table
first before altering the table.
2) Also the same in hook_uninstall().
Comment #7
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.