[D8] ColoFilters CSS Integration

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I tried the module with two themes, Bartik and Zen, and on both the css applied colors to divs outside the image field.

Is it an accepted practice to include css from 3rd party sites? I get that you wouldn't have to update the module everytime they made an update but that seems like too big a risk to take on a production site.

Just to clarify, it was the hosting the css elsewhere instead of including it in the module that I was worried about, not that it had been developed by someone else. It's putting a lot of trust in them never making a change that happened to negatively impact your site.

Hi Swarad,

I installed this module. This Module is very useful.

I have taken a latest code from git.

1. Still, Image effect are coming for entire DIV for few Effects like blend-red , blend-blue..

   

2. There is one more issue which I found is for some effect text color of title , body is changing.

   

Hi Swarad,

Yes after taking new clone your last commit was missing.

So, now I taken git pull so all your changes are present.

Now it's working fine. Both the issue which I mention in #9 are fixed.

Thank you.

Hi Swarad,

Module works perfectly fine. Just one thing, that the image label also gets the applied colour effect. Please refer the screenshot for more detail.

Review of the 8.x-1.x branch (commit e44ff21):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /home/klausi/pareview_temp/colofilters.module
  ----------------------------------------------------------------------
  FOUND 2 ERRORS AFFECTING 2 LINES
  ----------------------------------------------------------------------
   117 | ERROR | [x] Expected 1 space after IF keyword; 0 found
   118 | ERROR | [x] Whitespace found at end of line
  ----------------------------------------------------------------------
  PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
  ----------------------------------------------------------------------
  
  
  FILE: /home/klausi/pareview_temp/css/colofilters.local.css
  ----------------------------------------------------------------------
  FOUND 1 ERROR AFFECTING 1 LINE
  ----------------------------------------------------------------------
   15 | ERROR | Style definitions must end with a semicolon
  ----------------------------------------------------------------------
  
  Time: 92ms; Memory: 8Mb
  

• Codespell has found some spelling errors in your code.
  

  ./README.md:13: dont  ==> don't
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. colofilters_field_formatter_third_party_settings_form(): do not overwrite the $form incoming parameter like this, because that is confusing. Create a new variable like $element for your form elements. See for example https://api.drupal.org/api/drupal/core!modules!field_ui!field_ui.api.php...

But otherwise looks good to me.

Thanks for your contribution, Swarad!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.