Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
26 Sep 2016 at 12:05 UTC
Updated:
6 Nov 2018 at 12:17 UTC
Jump to comment: Most recent
Comments
Comment #2
PA robot commentedGit clone command for the sandbox is missing in the issue summary, please add it.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
revechat commentedComment #4
revechat commentedadded git clone command.
Comment #5
PA robot commentedFixed the git clone URL in the issue summary for non-maintainer users.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #6
visabhishek commentedAutomated Review
Please fix issue reported on : http://pareview.sh/pareview/httpsgitdrupalorgsandboxrevechat2805861git
Manual Review
and use following text
The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
Comment #7
revechat commentedmodified the code according to the issues.
Comment #8
varghese commentedHaving issue in coding standards and drupal errors. Please click this link to more info
Comment #9
revechat commentedfixed the issues
Comment #10
harishh commentedPlease check the following code and correct it.
revechat_admin.js
severity: normalreview: i18n_3Line 134: Javascript strings should be passed through Drupal.t(). [i18n_3]
alert('Please enter your full name.');
severity: normalreview: i18n_3Line 140: Javascript strings should be passed through Drupal.t(). [i18n_3]
alert('Please enter a valid email address.');
severity: normalreview: i18n_3Line 146: Javascript strings should be passed through Drupal.t(). [i18n_3]
alert('Please enter your phone number.');
Comment #11
visabhishek commented@harish.h : Looks like you forgot to change the status. Is this now RTBC after your review or are there application blockers left and this should be "needs work"?
Comment #12
harishh commentedComment #13
harishh commented@visabhishek: Status updated. Yes I forgot to change the status. Thanks for letting me know.
Comment #14
revechat commented@harish.h: fixed the issues
Comment #15
revechat commentedComment #16
avpadernoTo the reviewers: Please change back the priority to Normal after doing a review.
Comment #17
sleitner commentedAutomated Review
Pareview details: https://pareview.sh/pareview/https-git.drupal.org-project-revechat_livec...
Review of the 8.x-1.x branch (commit d756112):
hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .This automated report was generated with PAReview.sh, your friendly project application review script.
Manual Review
fontawesome in readme.htmlThe starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
Comment #18
sleitner commentedComment #19
avpadernoComment #20
avpadernoComment #21
sleitner commentedAutomated Review
Pareview details: https://pareview.sh/pareview/https-git.drupal.org-project-revechat_livec...
Review of the 7.x-1.x branch (commit 3179551):
This automated report was generated with PAReview.sh, your friendly project application review script.
Manual Review
fontawesome in readme.htmlThe starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
Comment #22
avpadernoIf you are still working on this application, you should fix all known problems and set the status to Needs review. (See also the project application workflow.)
Please don't change status of this application if you aren't sure you have time to dedicate to this application, or it will be closed again as won't fix.
I am closing this application due to lack of activity.