[D7] Vide

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi inzor,

Please see my comments below.

1. Video is not showing for anonymous user, but it visible in admin pages. Seems like issue with some css attributes. Also restrict playing video in admin pages. I'm using default Bartik theme.
2. Add vide.install file and implement hook_requirements() to check availability of Vide video background library.
3. vide_preprocess_page(): if you are only adding stuff to the page, use hook_page_build() instead. In hook_page_build(), you can use #attached property to include css and js in to the pages. It would make d8 upgrade easier and would be cache-safe. drupal_add_js() is deprecated in Drupal 8. Refer https://www.drupal.org/node/2169605
4. Make sure all variables set by the module is deleting while unistall the module, using hook_unistall().
5. Add configuration url in vide.info file to display it in module listing page.

Thanks,
ARUN AK

I tried this module in a fresh Drupal installation. Still not able to see video background for the pages. But I can hear the audio.

Hi Inzor

I have tried this module in my local and found the following issues

1. Video background is not showing in any blocks, html element and body element.
2. When I configured the video background for the "Video background" block, i got 404 error for thumbnail images. Attaching screenshot(vide_error.png). Same error for other blocks, html element and body element.
3. Please update more possible issues and solution under "Troubleshooting" section in README.txt

Thanks,

Ganesan

Sorry, forgot to place a greeting: Hi and yes, your module works good, but needs a lot of hands and input for such a "simple" feature right now...

Regards.
uh

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Probably yes: Does not cause module duplication and/or fragmentation. It's a dedicated solution for an existing js library but there are other modules that offer similar features.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements. Please see my proposals for the module.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code. But please see recommendations bellow..

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (*) This seems a "for skilled admins only module" right now. The module includes a requirement check for the runtime mode in vide_requirements (vide.install) but this is far from being intuitive. (Apart from the fact that Drupal is week on checking external library requirements during the install phase.) Your current implementation will oblige less experienced administrators to find the "not found" message through the Status report and that's the only place where it will show up once the module is active. Even with no library present users can configure everything with result 0. As the absence of the js library is a show-stopper I recommend to change this.
2. (+) I put this with a plus, but in fact it's a recommendation related with the "needs work"-issue above: This is a dedicated module with no other purpose than to implement a video background based on a single purpose js library. The js library is offered with a MIT license (compatible with the Drupal licensing model) and in this case you should simply include the js version with your module inside of a js folder. As you will maintain the project I don't see negative side effects for such a small js. For big third party libraries this is not recommended but in this case, given that we are talking about a 1 to 1, module for purpose specific js situation, I think you could offer a win-win solution here that makes your module much more user friendly or as the introduction for the js library states: Easy as hell jQuery plugin for video backgrounds.
3. If you like to maintain your current approach you should inform on the administration page of the module about the absence of the library instead of showing the administration form.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

The module setup alone should not be an application blocker, anything else that you found or should this be RTBC instead?

@Inzor, when you visit the project home page
https://www.drupal.org/sandbox/babko/2792849
one is not able to see your commits made on this project, this should be because of your git configurations on your machine.
checkout this for having the settings https://www.drupal.org/node/1022156

Hi Inzor.

I've tested your module with blocks and as well with html tags. All this works, but as I told you it's not "Easy as hell" and an implementation for a jQuery plugin for video backgrounds that pretends this should as well try to be easy, maybe not as hell, but not to far from it :-). Once you figure out how it works, e.g. that you need content for example for the element the background is attached to, everything plays nicely.

Hi Klausi.

Thanks for mentoring a bit. As you set this back to needs review indicating that the reasons exposed by me do not deserve a "needs work" flag, I put the module in Reviewed & tested by the community (= RTBC for newbies like me) as that is what I did. You may promote if nobody else finds additional problems.

Regards.
uh

manual review:

• project page is too short. Why would I need the module, what is the use case in Drupal? How do I use it? Please expand the project page with https://www.drupal.org/node/997024

Otherwise looks good to me!

Thanks for your contribution, Aleksey!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.