[D7] DrupalStatus

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Marcus,

Thanks for your contribution!

There is my review of the 7.x-1.x branch:

Drupal Code Sniffer has found some minor code style issues (please check the Drupal coding standards). See attachment.

Manual review of the 7.x-1.x branch:

It seems that your hook_form_alter() isn't fire. After installing the module, the button "Save configuration" is still on form. Try reinstall module to reproduce this issue.
I think, for resolving this issue you can to put this hook into .module file or add 'files[] = drupalstatus.admin.inc' into .info file.

Automated Review

[Best practice issues identified by http://pareview.sh/pareview/httpsgitdrupalorgsandboxmburnette2799673git-7x-1x identified some minor formatting issues.

Manual Review

Individual user account

[Yes: Follows / No: Does not follow] the guidelines for individual user accounts.

No duplication

I have seen other services and similar but not for this service.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows / No: Does not follow] the guidelines for 3rd party assets/code.

README.md

[Yes: Follows] the guidelines for in-project documentation and/or the README Template. Some of the lines are longer than 80 characters

Code long/complex enough for review

[Yes: Follows the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements. / No: List of security issues identified.]

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

I noticed in the install you use a function drupalstatus_generate_random_string. Drupal has a generator function drupal_random_bytes and user_password. Would either do the same or close enough job?

This review uses the Project Application Review Template.

@lionslair : Looks like you forgot to change the status. Is this now RTBC after your review or are there application blockers left and this should be "needs work"?

Yes sorry. Changed now.

https://bespin.cc is no longer active.